Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): disable tox -e tests-develop in github actions #515

Merged
merged 3 commits into from
Apr 18, 2024
Merged

chore(ci): disable tox -e tests-develop in github actions #515

merged 3 commits into from
Apr 18, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Apr 18, 2024 •
edited

🗒️ Description

Disables fixture filling for Prague from geth master (branch configured via evm-config.yaml) in Github Actions. This will likely cause many sporadic fails at this early stage of Prague developement.

🔗 Related Issues

To remind us to re-enable it in the future: #514.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. Skipping CHANGELOG for this CI only change.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

marioevz
marioevz approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danceratopz danceratopz added scope:ci Scope: Continuous Integration type:chore Type: Chore labels Apr 18, 2024
@danceratopz danceratopz mentioned this pull request Apr 18, 2024
Open
@danceratopz danceratopz merged commit 6820baf into main Apr 18, 2024
9 checks passed
marioevz added a commit that referenced this pull request May 17, 2024
@marioevz
Revert "chore(ci): disable filling of dev forks in github actions (#515…
a67dbd1 
…)"

This reverts commit 6820baf.
@marioevz marioevz mentioned this pull request May 17, 2024
Merged
marioevz added a commit that referenced this pull request May 17, 2024
@marioevz
chore(ci): re-enable tox -e tests-develop in github actions (#563)
6d5c8b7 
* Revert "chore(ci): disable filling of dev forks in github actions (#515)"

This reverts commit 6820baf.

* evm-config: devnet-0 evm

* tox: Ignore EOF for now

* github: Ignore EOF for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danceratopz @marioevz