Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on non-returning sections #517

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

shemnon
Copy link
Collaborator

@shemnon shemnon commented Apr 19, 2024

🗒️ Description

Update tests to conform with besu

  • sample code needs non-returning and data
  • all codesection zeros need to be non-returning
  • RETF is not valid in non-returning sections
  • CALL is not in EOF, use EXTCALL

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@shemnon shemnon force-pushed the eof/non-returning-functions-fixes branch 2 times, most recently from 1ad2639 to 6c3790e Compare April 19, 2024 18:29
Update tests to conform with besu
* sample code needs non-returning and data
* all codesection zeros need to be non-returning
* RETF is not valid in non-returning sections
* CALL is not in EOF, use EXTCALL

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon force-pushed the eof/non-returning-functions-fixes branch from 6c3790e to cdc868c Compare April 22, 2024 20:32
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_execution_function.py Outdated Show resolved Hide resolved
@marioevz marioevz merged commit 750bb22 into ethereum:main Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants