Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Revert CI to use macOS and Ubuntu latest releases #525

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Apr 25, 2024

🗒️ Description

Resolves the github actions CI issues that have occured over the past few days:

  • Reverts OS versions back to macos-latest and ubuntu-latest.
  • For macOS only - sets a fallback environment required for the cairosvg package within the tox ini file:
    • This allows tox to find libcairo-2, that is installed and linked within homebrew.
    • It seems to be the only viable solution for now and is highlighted within the mkdocs-material documentation.
    • Note this has to be set within tox as it uses an isolated environment. The environment variable set is exclusive to macOS so won't cause issues for other OS's.
    • Please see related issues below for more context.

Past hotfix PRs:

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:chore Type: Chore labels Apr 25, 2024
@spencer-tb spencer-tb self-assigned this Apr 25, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit c9b9307 into ethereum:main Apr 25, 2024
5 checks passed
@danceratopz
Copy link
Member

Thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants