Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF: efExample validInvalid tests #535

Merged
merged 9 commits into from
May 8, 2024
Merged

EOF: efExample validInvalid tests #535

merged 9 commits into from
May 8, 2024

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Apr 30, 2024

🗒️ Description

Translate Ori's eof example tests into .py

while working on the tests I realized 3 breaking changes

  • opcode JUMPF is 0xe5 not b1 as we had
  • opcode JUMPV first length byte is len(args) - 1, c++ style
  • and a few tweaking flags to the Container.Code section auto calculation in eof bytes

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
    (I didn't count this tests for convertion, because it is in EIP tests folder)
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added the scope:tests Scope: Test cases label Apr 30, 2024
@winsvega winsvega changed the base branch from call-evmone-eofparse-during-fill to main May 2, 2024 10:11
@winsvega winsvega requested a review from marioevz May 2, 2024 12:47
src/ethereum_test_tools/vm/opcode.py Outdated Show resolved Hide resolved
src/ethereum_test_tools/vm/opcode.py Outdated Show resolved Hide resolved
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one other comment on parameterization but looks good overall, thanks!

tests/prague/eip3540_eof_v1/test_example_validInvalid.py Outdated Show resolved Hide resolved
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tests/prague/eip3540_eof_v1/test_example_valid_invalid.py Outdated Show resolved Hide resolved
tests/prague/eip3540_eof_v1/test_example_valid_invalid.py Outdated Show resolved Hide resolved
@marioevz marioevz merged commit 0dee752 into main May 8, 2024
9 checks passed
@marioevz marioevz deleted the efExample branch May 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants