Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): EOF folder structure re-org #554

Merged
merged 4 commits into from
May 15, 2024
Merged

feat(tests): EOF folder structure re-org #554

merged 4 commits into from
May 15, 2024

Conversation

marioevz
Copy link
Member

🗒️ Description

Re-orgs all EOF tests under ./tests/prague/eip7692_eof_v1, which is the meta-EIP that contains all the feature EIPs.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:chore Type: Chore labels May 14, 2024
chfast
chfast approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winsvega
winsvega approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats affect one of my ongoing prs. will have to adjust

@marioevz marioevz merged commit e7a6182 into ethereum:main May 15, 2024
5 checks passed
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request May 20, 2024
@marioevz @spencer-tb
feat(tests): EOF folder structure re-org (ethereum#554)
cdb8a76 
* move(tests): create EOF meta-eip folder

* new(tests): create EOF tracker

* fix(tests): eof tracker fix

* fix(tests): eof tracker fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Test cases type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marioevz @chfast @winsvega