Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add solc-select to fill stage of build fixtures #618

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jun 11, 2024

πŸ—’οΈ Description

Fixes the new solc-select dependency required to build fixtures, for both stable/develop fixture releases as well and feature (EOF/Verkle) fixture releases.

πŸ”— Related Issues

This was an oversight from the following PR: #604

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md - no addition.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@spencer-tb spencer-tb added type:bug Something isn't working scope:ci Scope: Continuous Integration labels Jun 11, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in here!

.github/actions/build-fixtures/action.yaml Outdated Show resolved Hide resolved
Co-authored-by: danceratopz <danceratopz@gmail.com>
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danceratopz danceratopz merged commit 2321199 into ethereum:main Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants