Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test eof container custom_size field #620

Merged
merged 1 commit into from
Jun 18, 2024
Merged

test eof container custom_size field #620

merged 1 commit into from
Jun 18, 2024

Conversation

winsvega
Copy link
Collaborator

🗒️ Description

test eof container custom_size field
this analyze ori test collection and extend with pyspec his test cases

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added the scope:pytest Scope: Pytest plugins label Jun 11, 2024
@winsvega winsvega requested a review from marioevz June 11, 2024 11:33
marioevz
marioevz reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but overall it looks good 👍

tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_example_valid_invalid.py Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_section_size.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_section_size.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_section_size.py Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_section_size.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_section_size.py Outdated Show resolved Hide resolved
@winsvega
Copy link
Collaborator Author

winsvega commented Jun 12, 2024 •
edited
Loading

hm, maybe create some test IntEnum with str method predefined so not to have this str method defined in test file.

appled suggestions

@winsvega winsvega requested a review from marioevz June 12, 2024 13:05
marioevz
marioevz approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz merged commit b2a27f5 into main Jun 18, 2024
9 checks passed
@marioevz marioevz deleted the validInvalidFix branch June 18, 2024 15:59
spencer-tb pushed a commit that referenced this pull request Jun 26, 2024
@winsvega @spencer-tb
new(tests): EOF - EIP-3540: Test container custom_size field (#620)
2605b20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:pytest Scope: Pytest plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@winsvega @marioevz