Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): complete header_not_terminated tests #633

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jun 19, 2024

πŸ—’οΈ Description

While investigating tests coverage for evmone I stumbled upon an opportunity to add/complete/migrate some tests for a specific piece of validation logic (the coverage turned out to be there in the end, in ethereum/tests, so the prompt to work on this turned out to be a false trail). Nevertheless, I wanted to contribute this little migration (and some extra tests on the subject). (I ticked it off in the tracker.md)

πŸ”— Related Issues

na

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit eb9083f into ethereum:main Jun 19, 2024
5 checks passed
@marioevz marioevz deleted the terminator-tests branch June 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants