Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run single thread pytest in github actions #757

Merged
merged 1 commit into from
May 16, 2023

Conversation

gurukamath
Copy link
Collaborator

@gurukamath gurukamath commented May 1, 2023

Alternative to #751

Instead of re-running the tests as proposed in #751, we simply run a single thread of pytest if we are on GitHub actions (for the pypy env). When run locally, pytest falls back to-n auto.

@gurukamath gurukamath mentioned this pull request May 1, 2023
@petertdavies
Copy link
Collaborator

Why is this only for PyPy and not CPython?

@gurukamath
Copy link
Collaborator Author

Why is this only for PyPy and not CPython?

PyPy is the only environment that is facing memory issues currently. We don't want to run single thread CI jobs unless we absolutely have to in my opinion. If CPython has similar issues in the future, we can re-visit this at that point.

@SamWilsn SamWilsn merged commit 9bf5111 into ethereum:master May 16, 2023
@gurukamath gurukamath deleted the github-actions branch May 20, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants