WIP: Guest book compilation #11
Conversation
lifetime cleanup other stuff function def checkpoint used custom type def test passing
Tying some loose ends.
|
This has been fun to watch coming along. Will you ping us when you feel this is ready for someone to give it 👀 Also, you might start thinking about how you can break this up into smaller pieces. The current size of this PR is a bit too large to be effectively reviewed. |
|
Thanks for checking this out @pipermerriam. I think there are a few components that could be split out and reviewed independently after I do some cleanup. Here's what I'm thinking: First create two PRs that include support for...
Then create another PR with the Vyper to bytecode compiler and module-level tests. The module tests use rust-evm to create and execute contracts and ethabi to form contract input. Currently, everything mentioned above is working. After these are all merged, support for maps, arrays, events, and other features used in |
|
Hey Grant. I also wanted to jump in and say that the work you're doing is really amazing. You're doing a huge amount to prove the viability of this project. When I initially began work on Rust Vyper, I had serious questions as to whether or not it would really pan out. I'm really thrilled that you've been able to move so quickly on top of the work that was done on the parser. |
|
I'm picking this apart and creating smaller PRs. |
Addresses #10