Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement release process #157

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented Dec 10, 2020

What was wrong?

We didn't have a process to cut releases.

How was it fixed?

  1. This adds support for towncrier so we get release notes similar to the Trinity release notes except that they are in markdown for us

Working with towncrier is explained here

  1. Cutting releases is a two command process and its explained in more depth here

  2. After the make release command Github automatically picks up the release, produces binaries and puts it on the release page.

  3. The current version was moved back to 0.0.1 just so that we free up 0.1.0 for the first real release.

@codecov-io
Copy link

Codecov Report

Merging #157 (5591f96) into master (931d659) will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   82.23%   81.39%   -0.85%     
==========================================
  Files          44       44              
  Lines        3028     3133     +105     
==========================================
+ Hits         2490     2550      +60     
- Misses        538      583      +45     
Impacted Files Coverage Δ
compiler/src/yul/constructor.rs 53.84% <0.00%> (-9.80%) ⬇️
compiler/src/abi/elements.rs 73.91% <0.00%> (-7.04%) ⬇️
semantics/src/namespace/events.rs 94.44% <0.00%> (-5.56%) ⬇️
semantics/src/namespace/types.rs 56.85% <0.00%> (-5.03%) ⬇️
semantics/src/traversal/expressions.rs 76.16% <0.00%> (-2.76%) ⬇️
semantics/src/traversal/functions.rs 45.28% <0.00%> (-0.44%) ⬇️
semantics/src/errors.rs 5.55% <0.00%> (-0.33%) ⬇️
compiler/src/yul/mod.rs 0.00% <0.00%> (ø)
semantics/src/traversal/contracts.rs 100.00% <0.00%> (ø)
compiler/src/yul/mappers/functions.rs 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931d659...5591f96. Read the comment docs.

@cburgdorf cburgdorf force-pushed the christoph/feat/release-machinery branch 3 times, most recently from 28694b4 to 75e00be Compare December 10, 2020 15:47
@cburgdorf cburgdorf force-pushed the christoph/feat/release-machinery branch from 7d0fb09 to ad1501d Compare December 10, 2020 15:50
@cburgdorf cburgdorf changed the title Christoph/feat/release machinery Implement release process Dec 10, 2020
@g-r-a-n-t g-r-a-n-t self-requested a review December 10, 2020 16:20
@cburgdorf cburgdorf marked this pull request as ready for review December 10, 2020 17:18
@cburgdorf cburgdorf merged commit 00121f5 into ethereum:master Dec 10, 2020
This was referenced Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants