Do over/underflow checks for addition (SafeMath) #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/checked_addition
branch
from
12a6ce7
to
2f96c9d
Compare
g-r-a-n-t
reviewed
Feb 23, 2021
| @@ -239,7 +239,10 @@ pub fn expr_bin_operation( | |||
| .typ; | |||
|
|
|||
| return match op.node { | |||
| fe::BinOperator::Add => Ok(expression! { add([yul_left], [yul_right]) }), | |||
| fe::BinOperator::Add => match typ.is_signed_integer() { | |||
There was a problem hiding this comment.
i imagine at some point we'll add more checking functions for smaller integers?
There was a problem hiding this comment.
Ah, good point. I will expand this PR to include checks for all integer sizes for additions.
There was a problem hiding this comment.
Ok, done. Additions for all supported sizes should now be checked.
g-r-a-n-t
approved these changes
Feb 23, 2021
cburgdorf
force-pushed
the
christoph/feat/checked_addition
branch
from
2f96c9d
to
39988a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 94.03% 94.00% -0.04%
==========================================
Files 54 55 +1
Lines 3791 3834 +43
==========================================
+ Hits 3565 3604 +39
- Misses 226 230 +4
Continue to review full report at Codecov.
|
cburgdorf
force-pushed
the
christoph/feat/checked_addition
branch
from
39988a5
to
6e51389
Compare
cburgdorf
force-pushed
the
christoph/feat/checked_addition
branch
from
6e51389
to
71c7224
Compare
|
looks great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As explained in #153 artihmetic operations should check for under/overflows by default and revert if such are detected.
How was it fixed?
This adds checks for all additions of both signed and unsigned integers.
checked_add_u256andchecked_add_i256functions to runtimefe::BinOperator::Addin mapper