Need help with 1.10.22 regression, in 1.10.23 I get Unhandled trie error: missing trie node
#25589
Labels
Comments
|
I just tried restaring Full log: INFO [08-24|12:33:53.395] Disk storage enabled for ethash caches dir=/Users/sajjode/Library/Ethereum/geth/ethash count=3
INFO [08-24|12:33:53.396] Disk storage enabled for ethash DAGs dir=/Users/sajjode/Library/Ethash count=2
INFO [08-24|12:33:53.398] Initialising Ethereum protocol network=1 dbversion=8
INFO [08-24|12:33:53.437] Loaded most recent local header number=15,378,033 hash=db6612..1c3690 td=56,803,191,999,581,582,767,893 age=3d20h28m
INFO [08-24|12:33:53.438] Loaded most recent local full block number=15,378,033 hash=db6612..1c3690 td=56,803,191,999,581,582,767,893 age=3d20h28m
INFO [08-24|12:33:53.438] Loaded most recent local fast block number=15,378,033 hash=db6612..1c3690 td=56,803,191,999,581,582,767,893 age=3d20h28m
INFO [08-24|12:33:53.438] Loaded last fast-sync pivot marker number=12,467,495
WARN [08-24|12:33:53.439] Head state missing, repairing number=15,378,033 hash=db6612..1c3690 snaproot=07944c..a49773 |
|
indeed, that debug.setHead("0xEAFF88") gives me the exact same message Error: Post "http://localhost:3334": EOF but my journal log seems to suggest it is still syncing. just don't know what state it is. This release(.22 and .23) seems to be too rush and the 'patch' is my scary(without warning that the above command may not return immediately and not sure what exactly the above message means |
|
and now my log is showing huge amount of this ERROR[08-24|12:09:27.894] Demoting invalidated transaction hash=41b422..127396 this regression is a nightmare and now I see these Tries missing error(and the imported new chain segment is extremely slow, at this rate I would further lag behind as my other node which I haven't done the rewind is importing faster which is already like 10k block ahead and counting) |
|
@RisingPaw can't say for sure without logs. "trie missing errors" -- in what context? |
|
@RisingPaw indeed. I usually would delay my upgrade or at least test them out on a spare setup for a while. But this time it is about the merge, sigh. @holiman, thanks. I would just sync from fresh. |
|
and I really strongly suggest to not even mentioning that debug.setHead patch, just re-sync with the ancient data kept(based on what I see only about 1 week of data). It seems to cause my trouble. |
|
@RisingPaw that's a lot of errors. I'd recommend to just resync with the ancient data kept. |
|
geth removedb but keep the ancient data when asked |
|
that is what I have done, and waiting the re-sync about a week behind |
|
I took me about 15 hours, to sync from scratch, so it's not that bad. The snapshot sync is now enabled by default and it helps a lot. |
Am I (OP) borked too? |
|
We are running archive nodes with The command Thanks |
|
The EOF error is most likely a timeout between geth cli and geth daemon and can be ignored. Just check the log of your daemon and you will see that geth is indeed rewinding the blockchain. But I have these errors, too, but geth is still syncing. |
|
Now that I think about it... Archive nodes should not be affected. They don't have a node garbage collector, so everything is immediately flushed. You should be fine.
|
|
@karalabe You wrote in another thread:
But I think maybe it works for me now, maybe here is a gist with hundred log entries, and I don't see any errors anymore? Unindexed transactions blocks=1 txs=39 tail=13,054,155 elapsed="313.875µs"
INFO [08-24|19:13:44.624] Generating state snapshot root=5ad928..cd0ba1 at=0593cc..e22cb3 accounts=3,926,565 slots=17,271,639 storage=1.51GiB dangling=0 elapsed=3m17.830s eta=2h28m2.607s
INFO [08-24|19:13:52.626] Generating state snapshot root=5ad928..cd0ba1 in=05ed74..370d0d at=edbbef..af99d4 accounts=4,173,799 slots=17,887,309 storage=1.56GiB dangling=0 elapsed=3m25.832s eta=2h24m43.708s
INFO [08-24|19:13:56.159] Aborting state snapshot generation root=5ad928..cd0ba1 in=061039..c5fd4e at=39d3c7..b4d670 accounts=4,269,191 slots=18,208,306 storage=1.59GiB dangling=0 elapsed=3m29.365s eta=2h23m50.218s
INFO [08-24|19:13:56.159] Resuming state snapshot generation root=606014..8c7dbd in=061039..c5fd4e at=39d3c7..b4d670 accounts=4,269,191 slots=18,208,306 storage=1.59GiB dangling=0 elapsed=3m29.365s eta=2h23m50.218s
INFO [08-24|19:13:56.190] Imported new chain segment blocks=1 txs=208 mgas=21.150 elapsed=131.092ms mgasps=161.338 number=15,404,155 hash=58cd64..ce066e dirty=216.45MiB
INFO [08-24|19:13:56.193] Unindexed transactions blocks=1 txs=402 tail=13,054,156 elapsed=2.885msFuthermore, when I {
currentBlock: 15404013,
healedBytecodeBytes: 1380778,
healedBytecodes: 169,
healedTrienodeBytes: 311875891,
healedTrienodes: 1088686,
healingBytecode: 0,
healingTrienodes: 1181,
highestBlock: 15404111,
startingBlock: 15400840,
syncedAccountBytes: 44688733182,
syncedAccounts: 181096005,
syncedBytecodeBytes: 1570849,
syncedBytecodes: 184,
syncedStorage: 229585039,
syncedStorageBytes: 50173550930
}
> eth.syncing.highestBlock - eth.syncing.currentBlock
98
> eth.syncing.highestBlock - eth.syncing.currentBlock
NaN
> eth.syncing.highestBlock - eth.syncing.currentBlock
NaN
>So am I all good now? |
|
Same for me. I saw many |
|
@c0deright, @Sajjon, I also saw many many Since that seemed OK, I went ahead and did it on a Here is the console output from eth.syncing the first one was just before it finished and a short time later we see Here is the eth1.service logs when I stopped seeing the "Unhanded trie error": And on the Here is the complete logs for the So @karalabe, same q, is the db wipe needed? |
|
Even when a db wipe, after the with the pending value increasing instead of decreasing. |
|
I deleted everything in but eventually it reached |
|
state heal in progress, how long it would take ? this really is a nightmare now. |
|
I had the same issue, and I opted to removedb, but not ancient. |
|
I think it is probably better to remove everything. a single account state heal took 1 hour(since my last post) and I don't know how many are there that need this. This is not a super fast machine but not slow either(nvme, standard intel server CPU, not VM and the CPU usage is very low so it seems to be all about graining slowly). |
No. It's better to remove chaindata but leave ancients in place. It saves ~300GB of download. The "unexpected xxx packets" thing is not directly related, although there might inefficiencies (#25600) we can improve upon. |
There's no such thing -- state heal heals the entire trie. I don't know what it could have been that happened during that hour ? Maybe it simply finished the state heal (i.e: completed sync) in that hour? The generation of snapshot data is a post-sync operation, when it's doing that you're already in sync. |
|
but it seems that it is still not in normal mode where I should see the normal message of Aug 25 06:54:45 hqprdubada startmainnet.sh[2723248]: INFO [08-25|06:54:45.646] Imported new chain segment blocks=1 txs=49 mgas=3.414 elap still seeing import header and that state heal which the account # changed after about an hour to another one and I don't know where that would be done |
|
like this(that 24088 is increasing but it can stay the same for an hour before it changes, if there are 1M accounts, it would take how many hours but I don't know the meaning of it) Aug 25 13:59:13 hqprdubeth startmainnet.sh[3945015]: INFO [08-25|13:59:13.377] State heal in progress accounts=24088@1.21MiB slots=7672@612.17KiB codes=55@509.58KiB nodes=665,196@298.98MiB pending=128,150 twelve hours later, this is what I am seeing so it seems that it is fixing the account one at a time and no way to tell how many more remains. probably better to just scrap the whole thing and sync from fresh ! As it is still not in normal state AFAICT Aug 26 01:20:40 hqprdubeth startmainnet.sh[3945015]: INFO [08-26|01:20:40.850] State heal in progress accounts=137,843@7.32MiB slots=96077@7.24MiB codes=254@2.05MiB nodes=2,388,175@962.15MiB pending=88563 syncing: { |
|
I got it working eventually; what worked for me:
Did anyone have any success with rewinding the chain? if there was a corruption introduced at some point in time it should have been possible to do Hopefully nothing explodes during the merge 🤞 |
|
My Geth client seems to be working as well, I did NOT delete any db, just did the setHead, saw nasty errors, waited and some restary later all good. Lighthouse reports ready for merge 🥳 |
|
I too was successful using just |
Would you care to run a |
Can I do this while geth is running @rjl493456442 ?? EDIT: Apparently not, I get |
|
@rjl493456442 is it possible to get some kind of time estimate based on 15 min of running? Can I make it go faster somehow? Increasing cache? This is a Mac Mini M1 with 16 GB RAM |
|
@Sajjon if your state is totally complete, then it will take ~3 days to finish. I guess if you can run a day without any error, then your state should be fine. Now I have some hunch about this |
|
@rjl493456442 successfully running for 23 hours now, I will let it run for 24 hours more at least and write an update then. |
|
@Sajjon thanks for your help! And I think there is nothing wrong right? I think you can stop the checking and recover your node! I think I have figured out the issue for And it's a long existent issue, just be surfaced by a recent change(printed as log). |
|
@rjl493456442 I'm still letting it run, it has been running for ~65 hours now: Is there a point in letting it complete? Maybe it will complete in 24 hours @rjl493456442 ? |
|
@Sajjon I am almost certain that your node is good.
|
holiman
pushed a commit
that referenced
this issue
Aug 31, 2022
It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets #25613 #25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
|
This issue is identified, it's not critical at all, you can either run 1.10.23 ignore the logs, or run the latest master. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this issue
Sep 2, 2022
It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
|
@rjl493456442 Now I see So do I need to removedb and resync from scratch? Here are some more lines in geth log: INFO [09-08|09:16:40.150] Unindexed transactions blocks=1 txs=231 tail=13,145,252 elapsed=1.517ms
INFO [09-08|09:16:43.154] Imported new chain segment blocks=1 txs=22 mgas=3.152 elapsed=66.354ms mgasps=47.500 number=15,495,252 hash=619041..a5cdf4 dirty=1021.28MiB
INFO [09-08|09:16:43.155] Unindexed transactions blocks=1 txs=80 tail=13,145,253 elapsed="580.333µs"
INFO [09-08|09:16:46.157] Imported new chain segment blocks=1 txs=28 mgas=1.832 elapsed=49.963ms mgasps=36.672 number=15,495,253 hash=568e8b..ed3de1 dirty=1019.45MiB
INFO [09-08|09:16:46.160] Unindexed transactions blocks=1 txs=427 tail=13,145,254 elapsed=3.050ms
INFO [09-08|09:16:49.814] Imported new chain segment blocks=1 txs=75 mgas=9.047 elapsed=63.565ms mgasps=142.332 number=15,495,254 hash=85aa45..af0ff2 dirty=1019.98MiB
INFO [09-08|09:16:49.816] Unindexed transactions blocks=1 txs=226 tail=13,145,255 elapsed=2.129ms
ERROR[09-08|09:16:49.922] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:17:14.271] Imported new chain segment blocks=1 txs=225 mgas=19.735 elapsed=546.946ms mgasps=36.081 number=15,495,255 hash=0d799a..702882 dirty=1021.77MiB
INFO [09-08|09:17:14.272] Unindexed transactions blocks=1 txs=87 tail=13,145,256 elapsed="985.416µs"
INFO [09-08|09:17:20.111] Imported new chain segment blocks=1 txs=67 mgas=8.094 elapsed=87.611ms mgasps=92.386 number=15,495,256 hash=125e6b..481c97 dirty=1019.83MiB
INFO [09-08|09:17:20.112] Unindexed transactions blocks=1 txs=109 tail=13,145,257 elapsed="733.25µs"
INFO [09-08|09:17:26.303] Imported new chain segment blocks=1 txs=76 mgas=5.558 elapsed=66.384ms mgasps=83.717 number=15,495,257 hash=ee1865..aa4f98 dirty=1019.94MiB
INFO [09-08|09:17:26.306] Unindexed transactions blocks=1 txs=374 tail=13,145,258 elapsed=2.755ms
INFO [09-08|09:17:40.013] Imported new chain segment blocks=1 txs=252 mgas=28.427 elapsed=161.146ms mgasps=176.405 number=15,495,258 hash=052c18..cc8a5d dirty=1020.49MiB
INFO [09-08|09:17:40.016] Unindexed transactions blocks=1 txs=397 tail=13,145,259 elapsed=2.327ms
ERROR[09-08|09:17:49.924] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:18:44.214] Imported new chain segment blocks=1 txs=479 mgas=29.981 elapsed=641.382ms mgasps=46.744 number=15,495,259 hash=e912e6..814cef age=1m4s dirty=1023.82MiB
INFO [09-08|09:18:44.215] Unindexed transactions blocks=1 txs=174 tail=13,145,260 elapsed=1.724ms
ERROR[09-08|09:18:49.929] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:19:01.945] Imported new chain segment blocks=1 txs=269 mgas=29.995 elapsed=312.686ms mgasps=95.926 number=15,495,260 hash=e72e2a..4cdaa8 dirty=1022.09MiB
INFO [09-08|09:19:01.949] Unindexed transactions blocks=1 txs=563 tail=13,145,261 elapsed=4.298ms
INFO [09-08|09:19:08.443] Imported new chain segment blocks=1 txs=221 mgas=19.487 elapsed=130.210ms mgasps=149.655 number=15,495,261 hash=a094fb..a25df3 dirty=1022.88MiB
INFO [09-08|09:19:08.445] Unindexed transactions blocks=1 txs=411 tail=13,145,262 elapsed=2.715ms
INFO [09-08|09:19:14.354] Imported new chain segment blocks=1 txs=52 mgas=5.300 elapsed=83.791ms mgasps=63.249 number=15,495,262 hash=ad3c21..e706ab dirty=1020.63MiB
INFO [09-08|09:19:14.354] Unindexed transactions blocks=1 txs=43 tail=13,145,263 elapsed="512.459µs"
INFO [09-08|09:19:32.874] Imported new chain segment blocks=1 txs=254 mgas=17.538 elapsed=111.988ms mgasps=156.608 number=15,495,263 hash=1ff527..e43297 dirty=1021.59MiB
INFO [09-08|09:19:32.874] Unindexed transactions blocks=1 txs=27 tail=13,145,264 elapsed="244.125µs"
ERROR[09-08|09:19:49.951] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:19:55.591] Imported new chain segment blocks=1 txs=257 mgas=22.678 elapsed=145.924ms mgasps=155.409 number=15,495,264 hash=496826..44cd0d dirty=1023.61MiB
INFO [09-08|09:19:55.594] Unindexed transactions blocks=1 txs=390 tail=13,145,265 elapsed=2.227ms
INFO [09-08|09:20:03.431] Imported new chain segment blocks=1 txs=86 mgas=6.456 elapsed=79.287ms mgasps=81.429 number=15,495,265 hash=ec32cb..5f678e dirty=1022.35MiB
INFO [09-08|09:20:03.433] Unindexed transactions blocks=1 txs=392 tail=13,145,266 elapsed=2.237ms
INFO [09-08|09:20:11.888] Imported new chain segment blocks=1 txs=139 mgas=9.914 elapsed=90.136ms mgasps=109.990 number=15,495,266 hash=c24198..48a919 dirty=1021.33MiB
INFO [09-08|09:20:11.890] Unindexed transactions blocks=1 txs=254 tail=13,145,267 elapsed=2.100ms
INFO [09-08|09:20:22.687] Imported new chain segment blocks=1 txs=110 mgas=8.462 elapsed=79.731ms mgasps=106.132 number=15,495,267 hash=5940af..cce06a dirty=1021.84MiB
INFO [09-08|09:20:22.688] Unindexed transactions blocks=1 txs=204 tail=13,145,268 elapsed=1.353ms
INFO [09-08|09:20:37.370] Imported new chain segment blocks=1 txs=242 mgas=20.028 elapsed=141.411ms mgasps=141.631 number=15,495,268 hash=af4b5d..a3b77e dirty=1021.95MiB
INFO [09-08|09:20:37.374] Unindexed transactions blocks=1 txs=65 tail=13,145,269 elapsed=3.154ms
INFO [09-08|09:20:44.666] Imported new chain segment blocks=1 txs=154 mgas=19.725 elapsed=97.564ms mgasps=202.170 number=15,495,269 hash=b29d40..afe084 dirty=1023.23MiB
INFO [09-08|09:20:44.667] Unindexed transactions blocks=1 txs=130 tail=13,145,270 elapsed=1.229ms
ERROR[09-08|09:20:49.957] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:21:46.431] Imported new chain segment blocks=1 txs=32 mgas=2.482 elapsed=60.172ms mgasps=41.244 number=15,495,270 hash=f36fa4..28e1a5 age=1m2s dirty=1021.16MiB
INFO [09-08|09:21:46.433] Unindexed transactions blocks=1 txs=67 tail=13,145,271 elapsed=1.411ms
ERROR[09-08|09:21:49.962] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:22:15.428] Imported new chain segment blocks=1 txs=467 mgas=29.987 elapsed=185.890ms mgasps=161.317 number=15,495,271 hash=5b791a..223254 dirty=1021.70MiB
INFO [09-08|09:22:15.429] Unindexed transactions blocks=1 txs=160 tail=13,145,272 elapsed=1.438ms
INFO [09-08|09:22:27.531] Imported new chain segment blocks=1 txs=361 mgas=29.954 elapsed=161.891ms mgasps=185.026 number=15,495,272 hash=512e34..abf652 dirty=1022.01MiB
INFO [09-08|09:22:27.534] Unindexed transactions blocks=1 txs=399 tail=13,145,273 elapsed=2.769ms
INFO [09-08|09:22:32.752] Imported new chain segment blocks=1 txs=300 mgas=29.994 elapsed=190.809ms mgasps=157.192 number=15,495,273 hash=c85ff8..89fbd4 dirty=1022.76MiB
INFO [09-08|09:22:32.753] Unindexed transactions blocks=1 txs=52 tail=13,145,274 elapsed="324.416µs"
ERROR[09-08|09:22:49.965] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:22:50.212] Imported new chain segment blocks=1 txs=276 mgas=29.987 elapsed=196.277ms mgasps=152.781 number=15,495,274 hash=953587..c86277 dirty=1022.09MiB
INFO [09-08|09:22:50.217] Unindexed transactions blocks=1 txs=353 tail=13,145,275 elapsed=4.087ms
INFO [09-08|09:23:46.333] Imported new chain segment blocks=1 txs=333 mgas=29.997 elapsed=283.713ms mgasps=105.731 number=15,495,275 hash=50ed3f..7b833a dirty=1022.76MiB
INFO [09-08|09:23:46.336] Unindexed transactions blocks=1 txs=190 tail=13,145,276 elapsed=2.195ms
ERROR[09-08|09:23:49.967] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:24:12.424] Imported new chain segment blocks=1 txs=264 mgas=29.990 elapsed=297.372ms mgasps=100.849 number=15,495,276 hash=0a5561..5c5ff2 dirty=1023.65MiB
INFO [09-08|09:24:12.425] Unindexed transactions blocks=1 txs=38 tail=13,145,277 elapsed="637.541µs"
INFO [09-08|09:24:19.139] Imported new chain segment blocks=1 txs=41 mgas=4.107 elapsed=64.939ms mgasps=63.243 number=15,495,277 hash=d889c2..ff1844 dirty=1023.10MiB
INFO [09-08|09:24:19.142] Unindexed transactions blocks=1 txs=386 tail=13,145,278 elapsed=2.888ms
INFO [09-08|09:24:28.178] Imported new chain segment blocks=1 txs=107 mgas=7.871 elapsed=122.455ms mgasps=64.275 number=15,495,278 hash=26a416..1138ad dirty=1022.45MiB
INFO [09-08|09:24:28.179] Unindexed transactions blocks=1 txs=156 tail=13,145,279 elapsed="930.916µs"
ERROR[09-08|09:24:49.972] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:25:04.174] Imported new chain segment blocks=1 txs=311 mgas=30.025 elapsed=560.864ms mgasps=53.534 number=15,495,279 hash=4bb6ac..9004ce dirty=1023.26MiB
INFO [09-08|09:25:04.180] Unindexed transactions blocks=1 txs=312 tail=13,145,280 elapsed=4.554ms
INFO [09-08|09:25:13.613] Imported new chain segment blocks=1 txs=292 mgas=29.999 elapsed=556.917ms mgasps=53.865 number=15,495,280 hash=2b18ef..5d2b9c dirty=1021.63MiB
INFO [09-08|09:25:13.617] Unindexed transactions blocks=1 txs=443 tail=13,145,281 elapsed=4.372ms
INFO [09-08|09:25:23.116] Imported new chain segment blocks=1 txs=237 mgas=22.558 elapsed=314.507ms mgasps=71.723 number=15,495,281 hash=d695c1..6ed749 dirty=1021.19MiB
INFO [09-08|09:25:23.122] Unindexed transactions blocks=1 txs=351 tail=13,145,282 elapsed=5.600ms
INFO [09-08|09:25:37.022] Imported new chain segment blocks=1 txs=138 mgas=11.558 elapsed=92.214ms mgasps=125.336 number=15,495,282 hash=b739fb..dbf886 dirty=1022.18MiB
INFO [09-08|09:25:37.024] Unindexed transactions blocks=1 txs=422 tail=13,145,283 elapsed=2.005ms
INFO [09-08|09:25:49.339] Imported new chain segment blocks=1 txs=159 mgas=17.933 elapsed=103.302ms mgasps=173.601 number=15,495,283 hash=8dc2db..696af2 dirty=1023.35MiB
INFO [09-08|09:25:49.340] Unindexed transactions blocks=1 txs=71 tail=13,145,284 elapsed="304.042µs"
ERROR[09-08|09:25:49.976] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:26:06.160] Imported new chain segment blocks=1 txs=126 mgas=13.309 elapsed=147.804ms mgasps=90.046 number=15,495,284 hash=62bb93..46d97a dirty=1021.58MiB
INFO [09-08|09:26:06.161] Unindexed transactions blocks=1 txs=78 tail=13,145,285 elapsed="449.542µs"
INFO [09-08|09:26:07.747] Imported new chain segment blocks=1 txs=72 mgas=6.774 elapsed=56.306ms mgasps=120.311 number=15,495,285 hash=b98e81..023837 dirty=1022.10MiB
INFO [09-08|09:26:07.749] Unindexed transactions blocks=1 txs=318 tail=13,145,286 elapsed=1.920ms
INFO [09-08|09:26:14.315] Downloader queue stats receiptTasks=0 blockTasks=0 itemSize=64.96KiB throttle=4036
INFO [09-08|09:26:14.486] Imported new chain segment blocks=2 txs=75 mgas=9.641 elapsed=171.003ms mgasps=56.378 number=15,495,287 hash=c12733..433e99 dirty=1020.07MiB
INFO [09-08|09:26:14.505] Unindexed transactions blocks=2 txs=166 tail=13,145,288 elapsed=19.09ms
ERROR[09-08|09:26:49.980] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
ERROR[09-08|09:27:49.983] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:27:51.621] Imported new chain segment blocks=1 txs=383 mgas=29.981 elapsed=572.654ms mgasps=52.354 number=15,495,288 hash=bdddab..899516 age=1m38s dirty=1020.91MiB
INFO [09-08|09:27:51.623] Unindexed transactions blocks=1 txs=180 tail=13,145,289 elapsed=1.581ms
INFO [09-08|09:28:06.318] Imported new chain segment blocks=1 txs=356 mgas=30.029 elapsed=222.986ms mgasps=134.668 number=15,495,289 hash=f47d2b..f2ff99 dirty=1023.20MiB
INFO [09-08|09:28:06.319] Unindexed transactions blocks=1 txs=97 tail=13,145,290 elapsed="398µs"
INFO [09-08|09:28:11.280] Imported new chain segment blocks=1 txs=54 mgas=3.016 elapsed=85.765ms mgasps=35.163 number=15,495,290 hash=539d4c..6e4d23 dirty=1023.31MiB
INFO [09-08|09:28:11.282] Unindexed transactions blocks=1 txs=406 tail=13,145,291 elapsed=2.220ms
INFO [09-08|09:28:20.300] Imported new chain segment blocks=1 txs=273 mgas=29.998 elapsed=249.527ms mgasps=120.217 number=15,495,291 hash=6af107..a9377b dirty=1023.33MiB
INFO [09-08|09:28:20.300] Unindexed transactions blocks=1 txs=158 tail=13,145,292 elapsed="737.125µs"
INFO [09-08|09:28:31.523] Imported new chain segment blocks=1 txs=220 mgas=22.268 elapsed=172.031ms mgasps=129.443 number=15,495,292 hash=0cde0c..4da53c dirty=1023.79MiB
INFO [09-08|09:28:31.543] Unindexed transactions blocks=1 txs=103 tail=13,145,293 elapsed=19.929ms
INFO [09-08|09:26:14.505] Unindexed transactions blocks=2 txs=166 tail=13,145,288 elapsed=19.09ms
ERROR[09-08|09:26:49.980] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
ERROR[09-08|09:27:49.983] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"INFO [09-08|09:28:46.595] Imported new chain segment blocks=1 txs=124 mgas=11.182 elapsed=143.813ms mgasps=77.752 number=15,495,293 hash=11afb6..3874a5 dirty=1022.85MiB
INFO [09-08|09:28:46.596] Unindexed transactions blocks=1 txs=95 tail=13,145,294 elapsed=1.017ms
ERROR[09-08|09:28:49.993] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:29:25.636] Imported new chain segment blocks=1 txs=341 mgas=29.981 elapsed=297.834ms mgasps=100.665 number=15,495,294 hash=77b543..b57f3a dirty=1021.71MiB
INFO [09-08|09:29:25.637] Unindexed transactions blocks=1 txs=257 tail=13,145,295 elapsed=1.284ms
INFO [09-08|09:29:30.306] Chain reorg detected number=15,495,293 hash=11afb6..3874a5 drop=1 dropfrom=77b543..b57f3a add=1 addfrom=f3d7e3..c1ca77
INFO [09-08|09:29:30.312] Imported new chain segment blocks=1 txs=284 mgas=25.810 elapsed=97.581ms mgasps=264.501 number=15,495,294 hash=f3d7e3..c1ca77 dirty=1022.21MiB
INFO [09-08|09:29:30.682] Chain reorg detected number=15,495,293 hash=11afb6..3874a5 drop=1 dropfrom=f3d7e3..c1ca77 add=2 addfrom=b26050..2aa7be
INFO [09-08|09:29:30.695] Imported new chain segment blocks=1 txs=115 mgas=7.863 elapsed=75.749ms mgasps=103.803 number=15,495,295 hash=b26050..2aa7be dirty=1021.09MiB
INFO [09-08|09:29:30.716] Unindexed transactions blocks=1 txs=378 tail=13,145,296 elapsed=20.962ms
ERROR[09-08|09:29:49.998] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:30:04.284] Imported new chain segment blocks=1 txs=120 mgas=15.899 elapsed=91.305ms mgasps=174.131 number=15,495,296 hash=be8884..2e6ded dirty=1022.71MiB
INFO [09-08|09:30:04.286] Unindexed transactions blocks=1 txs=181 tail=13,145,297 elapsed=1.591ms
INFO [09-08|09:30:20.704] Imported new chain segment blocks=1 txs=462 mgas=29.487 elapsed=192.403ms mgasps=153.258 number=15,495,297 hash=92fe18..6cb207 dirty=1022.57MiB
INFO [09-08|09:30:20.722] Unindexed transactions blocks=1 txs=34 tail=13,145,298 elapsed=18.583ms
INFO [09-08|09:30:48.951] Imported new chain segment blocks=1 txs=326 mgas=23.046 elapsed=155.247ms mgasps=148.445 number=15,495,298 hash=f538cc..b2cdf0 dirty=1022.90MiB
INFO [09-08|09:30:48.952] Unindexed transactions blocks=1 txs=185 tail=13,145,299 elapsed=1.110ms
ERROR[09-08|09:30:50.002] Error in block freeze operation err="block receipts missing, can't freeze block 15400841"
INFO [09-08|09:30:56.592] Imported new chain segment blocks=1 txs=116 mgas=6.628 elapsed=77.824ms mgasps=85.161 number=15,495,299 hash=e89ad4..0c86a4 dirty=1022.48MiB
INFO [09-08|09:30:56.593] Unindexed transactions blocks=1 txs=178 tail=13,145,300 elapsed="885.667µs"
INFO [09-08|09:31:10.867] Imported new chain segment blocks=1 txs=23 mgas=1.420 elapsed=41.215ms mgasps=34.444 number=15,495,300 hash=201da1..4d3f69 dirty=1021.14MiB
INFO [09-08|09:31:10.869] Unindexed transactions blocks=1 txs=313 tail=13,145,301 elapsed=1.755ms |
|
I deleted the database, but keep ancients, and sync with @rjl493456442 |
|
Yes, snap sync is the default sync mode we used nowadays. Regarding the |
|
Will close this ticket since the original one is resolved. |
HanWang233
pushed a commit
to Meshee-Team/go-ethereum
that referenced
this issue
Sep 11, 2022
It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
blakehhuynh
pushed a commit
to blakehhuynh/go-ethereum
that referenced
this issue
Oct 3, 2022
It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
gitteri
pushed a commit
to paxosglobal/go-ethereum
that referenced
this issue
Oct 3, 2022
* cmd/faucet: add sepolia network support (ethereum#25128) cmd/faucet: Add Sepolia network support to faucet * trie: fix size accounting in cleaner (ethereum#25007) Decrease children size instead of dirties size when marking dirties as cleaned up in trie cleaner * all: remove concept of public/private API definitions (ethereum#25053) * internal/ethapi: rename PublicEthereumAPI to EthereumAPI * eth: rename PublicEthereumAPI to EthereumAPI * internal/ethapi: rename PublicTxPoolAPI to TxPoolAPI * internal/ethapi: rename PublicAccountAPI to EthereumAccountAPI * internal/ethapi: rename PrivateAccountAPI to PersonalAccountAPI * internal/ethapi: rename PublicBlockChainAPI to BlockChainAPI * internal/ethapi: rename PublicTransactionPoolAPI to TransactionAPI * internal/ethapi: rename PublicDebugAPI to DebugAPI * internal/ethapi: move PrivateDebugAPI methods to DebugAPI * internal/ethapi: rename PublicNetAPI to NetAPI * les: rename PrivateLightServerAPI to LightServerAPI * les: rename PrivateLightAPI to LightAPI * les: rename PrivateDebugAPI to DebugAPI * les: rename PublicDownloaderAPI to DownloaderAPI * eth,les: rename PublicFilterAPI to FilterAPI * eth: rename PublicMinerAPI to MinerAPI * eth: rename PublicDownloaderAPI to DownloaderAPI * eth: move PrivateMinerAPI methods to MinerAPI * eth: rename PrivateAdminAPI to AdminAPI * eth: rename PublicDebugAPI to DebugAPI * eth: move PrivateDebugAPI methods to DebugAPI * node: rename publicAdminAPI to adminAPI * node: move privateAdminAPI methods to adminAPI * node: rename publicWeb3API to web3API * eth,internal/ethapi: sync comments with previous renamings * cmd/geth: drop geth js command (ethereum#25000) * cmd/geth: drop js command * cmd: simplify ipc path determination for attach * Add deprecation warning for js * rm testdata for exec * fix account unlock test cases * Update cmd/geth/consolecmd.go Co-authored-by: Martin Holst Swende <martin@swende.se> * fix Co-authored-by: Martin Holst Swende <martin@swende.se> * README,rpc: remove mention of "shh" RPC API (ethereum#25137) * eth, miner: retrieve mining state from live database (ethereum#25139) * miner: retrieve mining state from live database * eth/catalyst: ignore stale fcu events from cl * core: fix typo in txpool (ethereum#25149) Fix typo in txPool truncateQueue comment * go.mod: upgrade to latest goleveldb (ethereum#25067) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers: optimize goja buffer conversion (ethereum#25156) This changes the []byte <-> Uint8Array conversion to use an ArrayBuffer, avoiding inefficient copying of the slice data in Goja. Co-authored-by: Felix Lange <fjl@twurst.com> * eth: fix typo (ethereum#25161) * internal/ethapi: always return chain id (ethereum#25166) The error was introduced in PR ethereum#21686, but there is no good reason to enforce sync in this method, and it causes issues with EL/CL integration. * internal/ethapi: add note about eth_chainId compatibility with EIP-695 (ethereum#25168) Co-authored-by: Felix Lange <fjl@twurst.com> * all: remove `public` field from `rpc.API` (ethereum#25059) all: remove public field from rpc.API * cmd: migrate to urfave/cli/v2 (ethereum#24751) This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json * params: set TTD for sepolia testnet (ethereum#25179) * cmd/geth, p2p: add support for custom discovery UDP port (ethereum#24979) This adds a new flag to set the discovery port to be different from the TCP listener port. Co-authored-by: Felix Lange <fjl@twurst.com> * fix: linter warning (ethereum#25192) * core/rawdb: fix typo in comment (ethereum#25191) * core/rawdb: simplify TestDiskSeek to use memorydb (ethereum#25182) * cmd/utils: fix applying bootstrap nodes from config file (ethereum#25174) * internal/ethapi: return chain id for EIP-155 legacy txs (ethereum#25155) * common: increase StorageSize test coverage (ethereum#25188) * consensus/beacon: check that only the latest pow block is valid ttd block (ethereum#25187) * consensus/beacon: check that only the latest pow block is valid ttd block * consensus/beacon: move verification to async function * consensus/beacon: fix verifyTerminalPoWBlock, add test cases * consensus/beacon: cosmetic changes * consensus/beacon: apply karalabe's fixes * build: fix auto-completion scripts and include them in .deb package (ethereum#25195) Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to golangci-lint v1.46.2 (ethereum#25202) This upgrade is required to fix lint issues with urfave/cli/v2, which uses generics when built with Go 1.18 * build/deb: fix auto-completion install paths (ethereum#25204) * params: go-ethereum v1.10.20 stable * params: begin v1.10.21 release cycle * common/prque: fix typo * eth/catalyst: disallow importing blocks via newPayload during snap sync (ethereum#25210) * eth/catalyst: disallow importing blocks via newPayload during snap sync * eth/catalyst: make tests pass by using full sync only * eth/catalysts: make the import delay a bit cleaner * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Replace fmt.Errorf with errors.New in abi argument (ethereum#25181) Replace unnecessary fmt.Errorf with errors.New in accounts/abi/argument.go * all: change format `0x%x` to `%#x` (ethereum#25221) * consensus/beacon: copy td value so we can modify it (ethereum#25230) * consensus/beacon: copy td value so we can modify it * consensus/beacon: copy td value so we can modify it * core: allow external code to set the block validator for malicious tests (ethereum#25119) * core: don't validate state * core: allow external validator * core: revert * core: comments * Update blockchain_reader.go * core: move SetValidator to blockchain.go * core: rename method * core: apply ttd override to uninitialized db (ethereum#25136) * core: apply ttd override to genesis block * core: apply overrides properly * signer/core/apitypes: support primitive types int96/uint96 (ethereum#25105) I have a EIP712 typehash using uint96, but it's currently not supported by go-ethereum. This change fixes it. * cmd/geth, cmd/devp2p: fix some cli parsing issues (ethereum#25234) * cmd/geth: add some missing argument count checks * internal/flags: skip cmds with no action func in MigrateGlobalFlags * internal/flags: add Merge * cmd/devp2p: re-add listener config flags in discv4 commands * core: allow external processor (ethereum#25233) * consensus/beacon: verify timestamp is greater than parent timestamp (ethereum#25236) * go.mod: updated logfmt dependency (ethereum#25231) This fixes an issue in abigen tests with go 1.17. * internal/ethapi: add basefee to block overrides (ethereum#25219) * trie: fix typo in comment (ethereum#25241) paralallel -> parallel * core/types: fix typo in comment (ethereum#25249) * internal/ethapi: fix chain ID check to return all non-zero IDs (ethereum#25244) * rpc: add graceful shutdown timeout for HTTP server (ethereum#25258) This change ensures the HTTP server will always terminate within at most 5s, even when all connections are busy and do not become idle. Co-authored-by: Felix Lange <fjl@twurst.com> * p2p/discover: fix typos in comments (ethereum#25272) * build: upgrade -dlgo version to Go 1.18.3 * core, eth: pre-allocate map in storage copy (ethereum#25279) * eth/tracers: add initial revertReasonTracer tracer (ethereum#25265) Adds a native tracer that returns that in case of failure returns the error message or the revert reason of a transaction. Co-authored-by: Martin Holst Swende <martin@swende.se> * params: enable DNS discovery on Sepolia too * internal/build: add a timestamp to the tar archive folder * build: upgrade -dlgo version to Go 1.18.4 * accounts/abi: fix typo in comment (ethereum#25271) * accounts/abi/bind/backends: return hash of new blocks (ethereum#25163) Co-authored-by: Jens <jmw.1906@gmx.de> * all: remove version field from rpc.API * internal/ethapi: error if tx args includes chain id that doesn't match local (ethereum#25157) * internal/ethapi: error if tx args includes chain id that doesn't match local * internal/ethapi: simplify code a bit Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core: remove lock in BlockChain.ExportN (ethereum#25254) * Remove locking in (*BlockChain).ExportN Since ExportN is read-only, it shouldn't need the lock. (?) * Add hash check to detect reorgs during export. * fix check order * Update blockchain.go * Update blockchain.go Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: prevent negative fee during RPC calls (ethereum#25214) During RPC calls such as eth_call and eth_estimateGas, st.evm.Config.NoBaseFee is set which allows the gas price to be below the base fee. This results the tip being negative, and balance being subtracted from the coinbase instead of added to it, which results in a potentially negative coinbase balance interestingly. This can't happen during normal chain processing as outside of RPC calls the gas price is required to be at least the base fee, as NoBaseFee is false. This change prevents this behavior by disabling fee payment when the fee is not set. Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core, les, eth: port snap sync changes (ethereum#24898) core, eth, les, trie: rework snap sync * tests: only activate merge on london rules (ethereum#25239) * trie: fix 'gosimple' lint issue (ethereum#25309) * p2p/discover: apply netrestrict in discv5 response handler (ethereum#25304) * cmd/geth: remove redundant 0x in dbGet/dbDelete (ethereum#25315) * accounts/abi: substitude arg%d to the range keyword (ethereum#25307) * accounts/abi: substitude arg%d to the range keyword * support more keywords * review feedback * params: Add Shanghai and Cancun blocks (ethereum#25305) * params: Add Shangai and Cancun blocks * fix copy/paste error Co-authored-by: Martin Holst Swende <martin@swende.se> * fix typo in Shanghai name Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/puppeth: remove support for exporting non-Geth genesis configurations (ethereum#25329) * cmd/puppeth: remove support for exporting non-Geth genesis configurations * remove unused function * params: set goerli TTD to 10_790_000 (ethereum#25324) * signer/core: add canonical TypedData hashing methods (ethereum#25283) * params: set sepolia mergeNetsplitBlock to 1735371 (ethereum#25372) * cmd/geth: eth/catalyst: enable authrpc by default (ethereum#25152) * cmd/geth: eth/catalyst: enable authrpc by default * eth/catalyst: rename catalyst -> Engine API in logs * eth/catalyst: don't panic * deps: update goleveldb * eth/catalyst: better warning for ttd not configured (ethereum#25394) * cmd: use flags.Merge for grouping flags (ethereum#25392) * consensus/beacon: fix typo in comment (ethereum#25391) * p2p/netutil: minor code cosmetic Signed-off-by: Abirdcfly <fp544037857@gmail.com> * eth, internal, light: fix error string capitalization (ethereum#25364) * light: fix differTries err message in tests (ethereum#25358) * all: add whitespace linter (ethereum#25312) * golangci: typo Signed-off-by: Delweng <delweng@gmail.com> * golangci: add whietspace Signed-off-by: Delweng <delweng@gmail.com> * *: rm whitesapce using golangci-lint Signed-off-by: Delweng <delweng@gmail.com> * cmd/puppeth: revert accidental resurrection Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers/js: fix capitalization in tests * eth: support bubbling up bad blocks from sync to the engine API (ethereum#25190) * eth: support bubbling up bad blocks from sync to the engine API * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * eth/catalyst: fix typo Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * Update eth/catalyst/api.go * eth/catalyst: when forgetting bad hashes, also forget descendants * eth/catalyst: minor bad block tweaks for resilience Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se> * params: change Merge config to print simpler message This fixes ethereum#25366 * core: eth: rpc: implement safe rpc block (ethereum#25165) * core: eth: rpc: implement safe rpc block * core: fix setHead, panics * go.mod: downgrade leveldb (ethereum#25413) * params: go-ethereum v1.10.21 stable * params: begin v1.10.22 release cycle * core, trie, eth, cmd: rework preimage store (ethereum#25287) * core, trie, eth, cmd: rework preimage store * trie: address comment * eth/catalyst: fix NewPayload warn log when dropping due to snap sync * node: set JWT expiry to 60 seconds (ethereum#25416) * node: set JWT expiry to 60 seconds * node: rename var * eth/catalyst: return syncing not accepted (ethereum#25414) * eth/catalyst: return syncing not accepted * eth/catalyst: fix test * eth/catalyst: return 0x0 if latestvalid is pow block (ethereum#25423) * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: return 0x0 if latestvalid is pow block * eth/catalyst: fix header retrieval, fix sign check Co-authored-by: Péter Szilágyi <peterke@gmail.com> * ethereum, ethclient: add FeeHistory support (ethereum#25403) Co-authored-by: Felix Lange <fjl@twurst.com> * all: use AbsTime.Add instead of conversion (ethereum#25417) * cm/puppeth: fix crash when of ethstats specifier doesn't contain `:` (ethereum#25405) Signed-off-by: Delweng <delweng@gmail.com> * eth: fix typo in comment (ethereum#25327) * common/compiler: json unmarshalling error checks (ethereum#25449) complier/solidity:add json.Unmarshal err check * cmd, core, eth, les, params: add merge-passed chain config (ethereum#24538) * cmd, core, eth, les, params: add merge-passed chain config * eth/catalyst, params: add various warning on malfunctioning beacons * eth/catalyst: fix warning for beacons without transition exchanges * eth: fix typo in catalyst api (ethereum#25460) eth: fix typo * eth/gasprice/feehistory: support finalized block (ethereum#25442) * build: upgrade -dlgo version to Go 1.18.5 * consensus/ethash: remove temp files created during DAG generation (ethereum#25381) This makes it remove not only the actual DAG file, but also the temporary file which the DAG data is written to while generating. * cmd/devp2p/internal/ethtest: update tests for eth/67 (ethereum#25306) * node, rpc: add ReadHeaderTimeout config option (ethereum#25338) This change makes http.Server.ReadHeaderTimeout configurable separately from ReadTimeout for RPC servers. The default is set to the same as ReadTimeout, which in order to cause no change in existing deployments. * core/types: fix typo in comment (ethereum#25359) * core: preallocate batch size in bloomIndexer (ethereum#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. * internal/ethapi: don't estimate gas if no limit provided in eth_createAccessList (ethereum#25467) Because the goal of eth_createAccessList is providing the caller with the largest-possible access list, it's generally not important that the gas limit used by the tracer will match the usage of the call exactly. Avoiding the gas estimation step is a performance improvement. As long as the call does not branch based on gas limit, the returned access list will be accurate. * graphql: embed *Resolver instead of backend interface (ethereum#25468) This creates some infrastructure to share resources between graphql API objects. * node: remove noop path.Join (ethereum#25475) Signed-off-by: Delweng <delweng@gmail.com> * core, trie: rework trie committer (ethereum#25320) * all: rework trie and trie committer * all: get rid of internal cache in trie * all: fixes * trie: polish * core, trie: address comments * trie: fix imports * core/state: address comments * core/state/snapshot: polish * trie: remove unused code * trie: update tests * trie: don't set db as nil * trie: address comments * trie: unskip test * core: use TryGetAccount to read what TryUpdateAccount has written (ethereum#25458) * core: use TryGetAccount to read where TryUpdateAccount has been used to write * Gary's review feedback * implement Gary's suggestion * fix bug + rename NewSecure into NewStateTrie * trie: add backwards-compatibility aliases for SecureTrie * Update database.go * make the linter happy Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * cmd, core, ethdb, node: move chain freezer one folder deeper (ethereum#25487) * cmd, core, ethdb, node: create chain freezer in a sub folder * core/rawdb: remove unused code * core, ethdb, node: add AncientDatadir API back * cmd, core: extend freezer info dump for sub-ancient-store * core/rawdb: rework freezer inspector * core/rawdb: address comments from Peter * core/rawdb: fix build issue * eth/downloader: fix log errors of queue_test.go (ethereum#25494) * core: fix uncle creation in TestFastVsFullChains (ethereum#25476) Co-authored-by: Felix Lange <fjl@twurst.com> * eth: formatted error nit (ethereum#25499) * eth/tracers: add onlyTopCall option to callTracer (ethereum#25430) This PR allows users to pass in a config object directly to the tracers. Previously only the struct logger was configurable. It also adds an option to the call tracer which if enabled makes it ignore any subcall and collect only information about the top-level call. See ethereum#25419 for discussion. The tracers will silently ignore if they are passed a config they don't care about. * all: cleanup the APIs for initializing genesis (ethereum#25473) * all: polish tests * core: apply feedback from Guillaume * core: fix comment * signer/rules: register clef api properly when rules are used (ethereum#25455) signer/rules: register clef api properly when rules are used, fixes ethereum#25298 * core: remove unused bc ChainContext in applyTransaction * build: add static linking support (ethereum#25492) This adds support for building statically-linked executables using ci.go. Static linking is enabled by default in Docker builds, making it possible to use the geth executable in any Docker image, regardless of the Linux distribution the Dockerfile is based on. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: display name in "method/event not found" error (ethereum#25512) * internal/ethapi: rework setDefaults for tx args so fee logic is separate (ethereum#25197) Co-authored-by: bobpkr <bob.p@krustuniverse.com> * core/genesis: remove calaverasAllocData (ethereum#25516) core/genesis: calaverasAllocData no longer used * params: set ttdpassed on goerli (ethereum#25519) * params: set mainnet terminal total difficulty for the merge (ethereum#25528) * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * params: set mainnet ttd to 58_750_000_000_000_000_000_000 * core, trie: flush preimages to db on blockchain close (ethereum#25533) * core, trie: flush preimages to db on database close Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * rename Close to CommitPreimages for clarity * core, trie: nitpick fixes Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * core/state, trie, light: add a TryDeleteAccount method (ethereum#25531) * core/state, trie, light: Add a DeleteAccount method * review feedback * Update database.go * pr triage feedback Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * core: make tx journal check and open atomic (ethereum#25530) * core: reduce system call about `os` * avoid deprecated method * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * params: begin v1.10.24 release cycle * params: begin go-ethereum v1.11 release cycle * internal/ethapi: rename debug getters to match spec (ethereum#25176) Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method. * accounts/abi/bind: add const for tx fee elasticity multiplier (ethereum#25504) Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: remove duplicate word in comments (ethereum#25618) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> * cmd/geth: fix legacy receipt detection for empty db (ethereum#25609) * build: fix ignored errors (ethereum#25591) * docs: specify execution client (ethereum#25566) Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: add 'finalized' and 'safe' block number support (ethereum#25580) * node: change JWT error status to 401 Unauthorized (ethereum#25629) * node: fix regression in TestJWT (ethereum#25635) * all: move genesis initialization to blockchain (ethereum#25523) * all: move genesis initialization to blockchain * core: add one more check * core: fix tests * eth/catalyst: adjust eta for themerge (ethereum#25601) * eth/catalyst: adjust eta for themerge * squash * squash * eth/catalyst: address review concerns * mobile: close node on error (ethereum#25643) * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * trie: fix grammar in comment (ethereum#25648) * trie: cleanup stateTrie (ethereum#25640) It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR. * eth/catalyst: prevent division by zero (ethereum#25654) eth/catalyst: prevent diff by zero * trie: better error reporting (ethereum#25645) * core/state: filter out nil trie for copy (ethereum#25575) * eth/protocols/snap: fix problems due to idle-but-busy peers * mobile: register filter APIs (ethereum#25642) This fixes a regression introduced in PR ethereum#25459. * README.md: improve grammar (ethereum#25646) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers/js: fill in log.refund field (ethereum#25661) For some reason, an accessor method for this field exists in JS, but the value was never actually assigned. * eth/fetcher: throttle peers which deliver many invalid transactions (ethereum#25573) Co-authored-by: Felix Lange <fjl@twurst.com> * node, rpc: add JWT auth support in client (ethereum#24911) This adds a generic mechanism for 'dial options' in the RPC client, and also implements a specific dial option for the JWT authentication mechanism used by the engine API. Some real tests for the server-side authentication handling are also added. Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: check that "version" is "2.0" in request objects (ethereum#25570) The JSON-RPC spec requires the "version" field to be exactly "2.0", so we should verify that. This change is not backwards-compatible with sloppy client implementations, but I decided to go ahead with it anyway because the failure will be caught via the returned error. * trie: fix typo in comment (ethereum#25667) * trie: fix unhandled error in test (ethereum#25628) * eth/tracers/js: improve integer types in log object (ethereum#25668) All fields related to gas must be represented as uint64. Depth is internally tracked as int, so it makes sense to also store it as int. * trie: check childrens' existence concurrently for snap heal * core, light, trie: remove DiskDB function from trie database (ethereum#25690) * params: update chts (ethereum#25707) * core/vm: rename RANDOM to PREVRANDAO (ethereum#25691) See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4399.md > This EIP supplants the semantics of the return value of existing DIFFICULTY (0x44) opcode and renames the opcode to PREVRANDAO (0x44). * all: cleanup tests (ethereum#25641) Follow-up to PR ethereum#25523 to cleanup all relevant tests. * eth, les: rework chain tracer (ethereum#25143) This PR simplifies the logic of chain tracer and also adds the unit tests. The most important change has been made in this PR is the state management. Whenever a tracing state is acquired there is a corresponding release function be returned as well. It must be called once the state is used up, otherwise resource leaking can happen. And also the logic of state management has been simplified a lot. Specifically, the state provider(eth backend, les backend) should ensure the state is available and referenced. State customers can use the state according to their own needs, or build other states based on the given state. But once the release function is called, there is no guarantee of the availability of the state. Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracer: fix broken test (ethereum#25715) * trie: update comments + err check for preimages (ethereum#25672) This PR includes minor updates to comments in trie/committer that reference insertion to the db, and adds an err != nil check for the return value of preimages.commit. * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/msgrate: be more lenient when calculating 'mean' (ethereum#25653) The p2p msgrate tracker is a thing which tries to estimate some mean round-trip times. However, it did so in a very curious way: if a node had 200 peers, it would sort their 200 respective rtt estimates, and then it would pick item number 2 as the mean. So effectively taking third fastest and calling it mean. This probably works "ok" when the number of peers are low (there are other factors too, such as ttlScaling which takes some of the edge off this) -- however when the number of peers is high, it becomes very skewed. This PR instead bases the 'mean' on the square root of the length of the list. Still pretty harsh, but a bit more lenient. * rpc: improve error codes for internal server errors (ethereum#25678) This changes the error code returned by the RPC server in certain situations: - handler panic: code -32603 - result marshaling error: code -32603 - attempt to subscribe via HTTP: code -32001 In all of the above cases, the server previously returned the default error code -32000. Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core: place a cap on reorglogs (ethereum#25711) This PR makes the event-sending for deleted and new logs happen in batches, to prevent OOM situation due to large reorgs. Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to go 1.19 (ethereum#25726) This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change. * p2p/discover/v5wire: reject packets smaller than 63 bytes (ethereum#25740) * core: preallocate maps in TxPool helper methods (ethereum#25737) * accounts/abi: fix typo in error message (ethereum#25742) * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * cmd/geth: add a verkle subcommand (ethereum#25718) * cmd/geth: add a verkle subcommand * fix copyright year * remove unused command parameters * check that the output file was successfully written to Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: goimports fix Co-authored-by: Martin Holst Swende <martin@swende.se> * node: fix HTTP server always force closing (ethereum#25755) Co-authored-by: Felix Lange <fjl@twurst.com> * core: fix log order in "Imported new chain segment" (ethereum#25768) * node: fix lint issue in rpcstack.go (ethereum#25774) * les/catalyst/api: add support for ExchangeTransitionConfigurationV1 (ethereum#25752) This method is missing in light client mode and breaks consensus clients that require a valid response. * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: handle more batch commit errors in Database (ethereum#25674) * core/rawdb: fix leak of backoff timer (ethereum#25776) * crypto/bls12381: docfix of g1 Affine (ethereum#25729) bls12381: docfix of g1 Affine. * internal/ethapi: return error when requesting invalid trie key (ethereum#25762) This change makes eth_getProof and eth_getStorageAt return an error when the argument contains invalid hex in storage keys. Co-authored-by: Felix Lange <fjl@twurst.com> * core: don't cache zero nonce in txNoncer (ethereum#25603) This changes the nonce cache used by TxPool to not store cached nonces for non-existing accounts. * core: more compact bad block report (ethereum#25714) This shortens the chain config summary in bad block reports, and adds go-ethereum version information as well. Co-authored-by: Felix Lange <fjl@twurst.com> * core: move build version reading to its own package (ethereum#25806) This fixes the build with Go 1.17, which does not have BuildInfo.Settings yet. * eth: fix a rare datarace on CHT challenge reply / shutdown * core/vm: return copy of input slice in identity precompile, avoid returndata copy (ethereum#25183) * core/vm: return copy of input slice in identity precompile. don't deep copy return data slice upon call completion * make use of common.CopyBytes * core/blockchain: downgrade tx indexing and unindexing logs (ethereum#25832) core/blockchain: downgrade tx indexing and unindexing logs from info to debug If a user has a finite tx lookup limit, they will see an "unindexing" info level log each time a block is imported. This information might help a user understand that they are removing the index each block and some txs may not be retrievable by hash, but overall it is generally more of a nuisance than a benefit. This change downgrades the log to a debug log. * eth/tracers: fix trace config for `TraceCall` (ethereum#25821) Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> * eth/catalyst: add locking around newpayload (ethereum#25816) Sometimes we get stuck on db compaction, and the CL re-issues the "same" command to us multiple times. Each request get stuck on the same place, in the middle of the handler. This changes makes it so we do not reprocess the same payload, but instead detects it early. * eth/catalyst: make tests run faster (ethereum#25818) * cmd/utils: make --authrpc.jwtsecret a DirectoryFlag (ethereum#25849) Signed-off-by: Delweng <delweng@gmail.com> * eth/protocols/snap: make log messages more clear that sync is ongoing (ethereum#25837) * eth/protocols/snap: make log messages more clear that sync is ongoing * Update sync.go Co-authored-by: Felix Lange <fjl@twurst.com> * .github: add CL client to issue template (ethereum#25814) * p2p: add channel buffers to avoid goroutine leaks in tests (ethereum#24929) * internal/version: use gitCommit injection in version handling code (ethereum#25851) This changes the CI build to store the git commit and date into package internal/version instead of package main. Doing this essentially merges our two ways of tracking the go-ethereum version into a single place, achieving two objectives: - Bad block reports, which use version.Info(), will now have the git commit information even when geth is built in an environment such as launchpad.net where git access is unavailable. - For geth builds created by `go build ./cmd/geth` (i.e. not using `go run build/ci.go install`), git information stored by the go tool is now used in the p2p node name as well as in `geth version` and `geth version-check`. * cmd/abigen: change --exc to exclude by type name (ethereum#22620) The abigen exclusion pattern, previously on the form "path:type", now supports wildcards. Examples "*:type" to exclude a named type in all files, or "/path/to/foo.sol:*" all types in foo.sol. * tests, les, eth: remove mentions of deprecated Morden testnet (ethereum#23570) * remove morden * Update commons.go * Update handler.go * empty commit to make appveyor happy * all: clean up the configs for pruner and snapshotter (ethereum#22396) This PR cleans up the configurations for pruner and snapshotter by passing a config struct. And also, this PR disables the snapshot background generation if the chain is opened in "read-only" mode. The read-only mode is necessary in some cases. For example, we have a list of commands to open the etheruem node in "read-only" mode, like export-chain. In these cases, the snapshot background generation is non expected and should be banned explicitly. * cmd/puppeth, cmd/utils: finalize removal of gasTarget flag (ethereum#24370) This PR fully removes the --miner.gastarget flag, as previously it was only hidden from the geth --help command, but could still be used. * core/types: improve accuracy of header.Size() (ethereum#25859) The header.Size() method did not take the basefee into account. * eth/tracers: pad memory slice on OOB case (ethereum#25213) * eth/tracers: pad memory slice on oob case * eth/tracers/js: fix testfailure due to err msg capitalization Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/faucet: fix readme typos (ethereum#25867) * Fix: typos Fix: typos * Undo change Undo change * core: fix datarace in txpool, fixes ethereum#25870 and ethereum#25869 (ethereum#25872) core: fix datarace in txpool pendingnoce, fixes ethereum#25870 * eth/downloader, les/downloader: fix subtle flaw in queue delivery (ethereum#25861) * fix queue.deliver * les/downloader: fix queue.deliver Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: better handle error on eip activation check (ethereum#25131) * core/vm: correct logic for eip check of NewEVMInterpreter * refactor * cmd/geth: make dumpgenesis load genesis datadir if it exists (ethereum#25135) `geth dumpgenesis` currently does not respect the content of the data directory. Instead, it outputs the genesis block created by command-line flags. This PR fixes it to read the genesis from the database, if the database already exists. Co-authored-by: Martin Holst Swende <martin@swende.se> * tests: fix state test error checking (ethereum#25702) Some tests define an 'expectException' error but the tests runner does not check for conditions where this test value is filled (error expected) but in which no error is returned by the test runner. An example of this scenario is GeneralStateTests/stTransactionTest/HighGasPrice.json, which expects a 'TR_NoFunds' error, but the test runner does not return any error. Signed-off-by: meows <b5c6@protonmail.com> * eth/tracers: use gencodec for native tracers (ethereum#25637) The call tracer and prestate tracer store data JSON-encoded in memory. In order to support alternative encodings (specifically RLP), it's better to keep data a native format during tracing. This PR does marshalling at the end, using gencodec. OBS! This PR changes the call tracer result slightly: - Order of type and value fields are changed (should not matter). - Output fields are completely omitted when they're empty (no more output: "0x"). Previously, this was only _sometimes_ omitted (e.g. when call ended in a non-revert error) and otherwise 0x when the output was actually empty. * cmd, core, eth, les, light: track deleted nodes (ethereum#25757) * cmd, core, eth, les, light: track deleted nodes * trie: add docs * trie: address comments * cmd, core, eth, les, light, trie: trie id * trie: add tests * trie, core: updates * trie: fix imports * trie: add utility print-method for nodeset * trie: import err * trie: fix go vet warnings Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: return state error via GetEVM (ethereum#25876) * make vmError more useful * fix for review * Update api.go * revert calling site Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * eth/downloader: make flakey test less flakey (ethereum#25879) * ethclient/gethclient: fix bugs in override object encoding (ethereum#25616) This fixes a bug where contract code would be overridden to empty code ("0x") when the Code field of OverrideAccount was left nil. The change also cleans up the encoding of overrides to only send necessary fields, and improves documentation. Fixes ethereum#25615 Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * trie, eth/protocols/snap: less tiny db-writes during trie-healing (ethereum#25681) This PR prevent making tiny writes during state healing, by only performing the batch-write if the accumulated data is large enough to be meaningful. * accounts/abi/bind/backends: fix AdjustTime to respect Fork (ethereum#25225) * tests: report mgas/s metric in evm benchmarks (ethereum#25700) * test(state): report mgas/s metric in EVM benchmark * revert testdata submodule update * aggregate mgas/s results * calculate elapsed time better * tests: benchmarks - handle access list + take refund into account Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: minor trivial clean up (ethereum#25880) * dropped `vm.keccakState` for `crypto.KeccakState` * cleaned up `OpCode.IsPush()` * eth/tracers: fix a bug in prestateTracer (ethereum#25884) * internal/ethapi: handle odd length hex in decodeHash (ethereum#25883) This change adds zero-padding (prefix) of odd nibbles in the decodeHash function. Co-authored-by: ty <ty@oncoder.com> * core: rework tx indexer (ethereum#25723) This PR reworks tx indexer a bit. Compared to the original version, one scenario is no longer handled - upgrading from legacy geth without indexer support. The tx indexer was introduced in 2020 and have been present through hardforks, so it can be assumed that all Geth nodes have tx indexer already. So we can simplify the tx indexer logic a bit: - If the tail flag is not present, it means node is just initialized may or may not with an ancient store attached. In this case all blocks are regarded as unindexed - If the tail flag is present, it means blocks below tail are unindexed, blocks above tail are indexed This change also address some weird cornercases that could make the indexer not work after a crash. * accounts/abi: return toGoType error immediately (ethereum#25565) * eth/tracers: remove revertReasonTracer, add revert reason to callTracer (ethereum#25508) * eth/tracers: add revertReason to callTracer * update callframe gen json * add revertal to calltrace test * accounts/abi/bind: parse ABI only once on bind (ethereum#25574) * accounts/abi/bind: parse ABI once on bind * accounts/abi/bind: suppress 'imported and not used' error for abi package * internal/flags: fix issue with stringslice migration (ethereum#25830) This fixes a cornercase bug where the flag migration would mess up the value of StringSlice flags. * cmd/geth, cmd/utils: geth attach with custom headers (ethereum#25829) This PR makes it possible to set custom headers, in particular for two scenarios: - geth attach - geth commands which can use --remotedb, e..g geth db inspect The ability to use custom headers is typically useful for connecting to cloud-apis, e.g. providing an infura- or alchemy key, or for that matter access-keys for environments behind cloudflare. Co-authored-by: Felix Lange <fjl@twurst.com> * add market gas price to simulate duplicate nonce behavior (#7) * fix duplicated test * add back tests Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Signed-off-by: meows <b5c6@protonmail.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: int88 <106391185+int88@users.noreply.github.com> Co-authored-by: willian.eth <willian@ufpa.br> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: zeim839 <50573884+zeim839@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Ruohui Wang <nomaru@outlook.com> Co-authored-by: Andre Patta <andre_luis@outlook.com> Co-authored-by: Seungbae.yu <72970043+dbadoy@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: スパイク <1311798+spkjp@users.noreply.github.com> Co-authored-by: Brion <4777457+cifer76@users.noreply.github.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: Philip Fan <fanwengang@hotmail.com> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: Jens <jmw.1906@gmx.de> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: henridf <henridf@gmail.com> Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Ha ĐANG <dvietha@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Eval EXEC <execvy@gmail.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Rithwik Babu <rithwikbabu2020@gmail.com> Co-authored-by: Henry <101552941+henry-0@users.noreply.github.com> Co-authored-by: Manoj Kumar <mnjkmr398@gmail.com> Co-authored-by: Tristan-Wilson <87238672+Tristan-Wilson@users.noreply.github.com> Co-authored-by: yong <33920876+yzhaoyu@users.noreply.github.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: ycyraum <ycyraum@fastmail.com> Co-authored-by: 0xe3b0c4 <110295932+0xe3b0c4@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: bobpkr <bob.p@krustuniverse.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: xinbenlv <zzn@zzn.im> Co-authored-by: uji <49834542+uji@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rachel Bousfield <nfranks@protonmail.com> Co-authored-by: Jakub Freebit <49676311+jakub-freebit@users.noreply.github.com> Co-authored-by: xternet <majewski.post@gmail.com> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Co-authored-by: Nicholas <nicholas.zhaoyu@gmail.com> Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Benjamin Prosnitz <bprosnitz@gmail.com> Co-authored-by: Nicolas Gotchac <ngotchac@gmail.com> Co-authored-by: pinkiebell <40266861+pinkiebell@users.noreply.github.com> Co-authored-by: George Carder <georgercarder@gmail.com> Co-authored-by: makcandrov <108467407+makcandrov@users.noreply.github.com> Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> Co-authored-by: Boqin@MetaSecureLabs <Bobbqqin@gmail.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Leon <316032931@qq.com> Co-authored-by: meowsbits <b5c6@protonmail.com> Co-authored-by: Janko Simonovic <simonovic86@gmail.com> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: TY <45994721+tylerK1294@users.noreply.github.com> Co-authored-by: ty <ty@oncoder.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: Mikhail Vazhnov <michael.vazhnov@gmail.com> Co-authored-by: susannapaxos <86749396+susannapaxos@users.noreply.github.com>
|
Now that I think about it... Archive nodes should not be affected. They don't have a node garbage collector, so everything is immediately flushed. You should be fine.
|
roberto-bayardo
added a commit
to mdehoog/go-ethereum
that referenced
this issue
Nov 4, 2022
* cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * params: begin v1.10.24 release cycle * params: begin go-ethereum v1.11 release cycle * internal/ethapi: rename debug getters to match spec (ethereum#25176) Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method. * accounts/abi/bind: add const for tx fee elasticity multiplier (ethereum#25504) Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: remove duplicate word in comments (ethereum#25618) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> * cmd/geth: fix legacy receipt detection for empty db (ethereum#25609) * build: fix ignored errors (ethereum#25591) * docs: specify execution client (ethereum#25566) Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: add 'finalized' and 'safe' block number support (ethereum#25580) * node: change JWT error status to 401 Unauthorized (ethereum#25629) * node: fix regression in TestJWT (ethereum#25635) * all: move genesis initialization to blockchain (ethereum#25523) * all: move genesis initialization to blockchain * core: add one more check * core: fix tests * eth/catalyst: adjust eta for themerge (ethereum#25601) * eth/catalyst: adjust eta for themerge * squash * squash * eth/catalyst: address review concerns * mobile: close node on error (ethereum#25643) * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * trie: fix grammar in comment (ethereum#25648) * eth/protocols/snap: fix problems due to idle-but-busy peers * trie: cleanup stateTrie (ethereum#25640) It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR. * eth/catalyst: prevent division by zero (ethereum#25654) eth/catalyst: prevent diff by zero * trie: better error reporting (ethereum#25645) * core/state: filter out nil trie for copy (ethereum#25575) * mobile: register filter APIs (ethereum#25642) This fixes a regression introduced in PR ethereum#25459. * README.md: improve grammar (ethereum#25646) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers/js: fill in log.refund field (ethereum#25661) For some reason, an accessor method for this field exists in JS, but the value was never actually assigned. * eth/fetcher: throttle peers which deliver many invalid transactions (ethereum#25573) Co-authored-by: Felix Lange <fjl@twurst.com> * node, rpc: add JWT auth support in client (ethereum#24911) This adds a generic mechanism for 'dial options' in the RPC client, and also implements a specific dial option for the JWT authentication mechanism used by the engine API. Some real tests for the server-side authentication handling are also added. Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: check that "version" is "2.0" in request objects (ethereum#25570) The JSON-RPC spec requires the "version" field to be exactly "2.0", so we should verify that. This change is not backwards-compatible with sloppy client implementations, but I decided to go ahead with it anyway because the failure will be caught via the returned error. * trie: fix typo in comment (ethereum#25667) * trie: fix unhandled error in test (ethereum#25628) * eth/tracers/js: improve integer types in log object (ethereum#25668) All fields related to gas must be represented as uint64. Depth is internally tracked as int, so it makes sense to also store it as int. * trie: check childrens' existence concurrently for snap heal * core, light, trie: remove DiskDB function from trie database (ethereum#25690) * params: update chts (ethereum#25707) * core/vm: rename RANDOM to PREVRANDAO (ethereum#25691) See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4399.md > This EIP supplants the semantics of the return value of existing DIFFICULTY (0x44) opcode and renames the opcode to PREVRANDAO (0x44). * all: cleanup tests (ethereum#25641) Follow-up to PR ethereum#25523 to cleanup all relevant tests. * eth, les: rework chain tracer (ethereum#25143) This PR simplifies the logic of chain tracer and also adds the unit tests. The most important change has been made in this PR is the state management. Whenever a tracing state is acquired there is a corresponding release function be returned as well. It must be called once the state is used up, otherwise resource leaking can happen. And also the logic of state management has been simplified a lot. Specifically, the state provider(eth backend, les backend) should ensure the state is available and referenced. State customers can use the state according to their own needs, or build other states based on the given state. But once the release function is called, there is no guarantee of the availability of the state. Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracer: fix broken test (ethereum#25715) * trie: update comments + err check for preimages (ethereum#25672) This PR includes minor updates to comments in trie/committer that reference insertion to the db, and adds an err != nil check for the return value of preimages.commit. * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/msgrate: be more lenient when calculating 'mean' (ethereum#25653) The p2p msgrate tracker is a thing which tries to estimate some mean round-trip times. However, it did so in a very curious way: if a node had 200 peers, it would sort their 200 respective rtt estimates, and then it would pick item number 2 as the mean. So effectively taking third fastest and calling it mean. This probably works "ok" when the number of peers are low (there are other factors too, such as ttlScaling which takes some of the edge off this) -- however when the number of peers is high, it becomes very skewed. This PR instead bases the 'mean' on the square root of the length of the list. Still pretty harsh, but a bit more lenient. * rpc: improve error codes for internal server errors (ethereum#25678) This changes the error code returned by the RPC server in certain situations: - handler panic: code -32603 - result marshaling error: code -32603 - attempt to subscribe via HTTP: code -32001 In all of the above cases, the server previously returned the default error code -32000. Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core: place a cap on reorglogs (ethereum#25711) This PR makes the event-sending for deleted and new logs happen in batches, to prevent OOM situation due to large reorgs. Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to go 1.19 (ethereum#25726) This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change. * p2p/discover/v5wire: reject packets smaller than 63 bytes (ethereum#25740) * core: preallocate maps in TxPool helper methods (ethereum#25737) * accounts/abi: fix typo in error message (ethereum#25742) * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * cmd/geth: add a verkle subcommand (ethereum#25718) * cmd/geth: add a verkle subcommand * fix copyright year * remove unused command parameters * check that the output file was successfully written to Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: goimports fix Co-authored-by: Martin Holst Swende <martin@swende.se> * node: fix HTTP server always force closing (ethereum#25755) Co-authored-by: Felix Lange <fjl@twurst.com> * core: fix log order in "Imported new chain segment" (ethereum#25768) * node: fix lint issue in rpcstack.go (ethereum#25774) * les/catalyst/api: add support for ExchangeTransitionConfigurationV1 (ethereum#25752) This method is missing in light client mode and breaks consensus clients that require a valid response. * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: handle more batch commit errors in Database (ethereum#25674) * core/rawdb: fix leak of backoff timer (ethereum#25776) * crypto/bls12381: docfix of g1 Affine (ethereum#25729) bls12381: docfix of g1 Affine. * internal/ethapi: return error when requesting invalid trie key (ethereum#25762) This change makes eth_getProof and eth_getStorageAt return an error when the argument contains invalid hex in storage keys. Co-authored-by: Felix Lange <fjl@twurst.com> * core: don't cache zero nonce in txNoncer (ethereum#25603) This changes the nonce cache used by TxPool to not store cached nonces for non-existing accounts. * core: more compact bad block report (ethereum#25714) This shortens the chain config summary in bad block reports, and adds go-ethereum version information as well. Co-authored-by: Felix Lange <fjl@twurst.com> * core: move build version reading to its own package (ethereum#25806) This fixes the build with Go 1.17, which does not have BuildInfo.Settings yet. * eth: fix a rare datarace on CHT challenge reply / shutdown * core/vm: return copy of input slice in identity precompile, avoid returndata copy (ethereum#25183) * core/vm: return copy of input slice in identity precompile. don't deep copy return data slice upon call completion * make use of common.CopyBytes * core/blockchain: downgrade tx indexing and unindexing logs (ethereum#25832) core/blockchain: downgrade tx indexing and unindexing logs from info to debug If a user has a finite tx lookup limit, they will see an "unindexing" info level log each time a block is imported. This information might help a user understand that they are removing the index each block and some txs may not be retrievable by hash, but overall it is generally more of a nuisance than a benefit. This change downgrades the log to a debug log. * eth/tracers: fix trace config for `TraceCall` (ethereum#25821) Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> * eth/catalyst: add locking around newpayload (ethereum#25816) Sometimes we get stuck on db compaction, and the CL re-issues the "same" command to us multiple times. Each request get stuck on the same place, in the middle of the handler. This changes makes it so we do not reprocess the same payload, but instead detects it early. * eth/catalyst: make tests run faster (ethereum#25818) * cmd/utils: make --authrpc.jwtsecret a DirectoryFlag (ethereum#25849) Signed-off-by: Delweng <delweng@gmail.com> * eth/protocols/snap: make log messages more clear that sync is ongoing (ethereum#25837) * eth/protocols/snap: make log messages more clear that sync is ongoing * Update sync.go Co-authored-by: Felix Lange <fjl@twurst.com> * .github: add CL client to issue template (ethereum#25814) * p2p: add channel buffers to avoid goroutine leaks in tests (ethereum#24929) * internal/version: use gitCommit injection in version handling code (ethereum#25851) This changes the CI build to store the git commit and date into package internal/version instead of package main. Doing this essentially merges our two ways of tracking the go-ethereum version into a single place, achieving two objectives: - Bad block reports, which use version.Info(), will now have the git commit information even when geth is built in an environment such as launchpad.net where git access is unavailable. - For geth builds created by `go build ./cmd/geth` (i.e. not using `go run build/ci.go install`), git information stored by the go tool is now used in the p2p node name as well as in `geth version` and `geth version-check`. * cmd/abigen: change --exc to exclude by type name (ethereum#22620) The abigen exclusion pattern, previously on the form "path:type", now supports wildcards. Examples "*:type" to exclude a named type in all files, or "/path/to/foo.sol:*" all types in foo.sol. * tests, les, eth: remove mentions of deprecated Morden testnet (ethereum#23570) * remove morden * Update commons.go * Update handler.go * empty commit to make appveyor happy * all: clean up the configs for pruner and snapshotter (ethereum#22396) This PR cleans up the configurations for pruner and snapshotter by passing a config struct. And also, this PR disables the snapshot background generation if the chain is opened in "read-only" mode. The read-only mode is necessary in some cases. For example, we have a list of commands to open the etheruem node in "read-only" mode, like export-chain. In these cases, the snapshot background generation is non expected and should be banned explicitly. * cmd/puppeth, cmd/utils: finalize removal of gasTarget flag (ethereum#24370) This PR fully removes the --miner.gastarget flag, as previously it was only hidden from the geth --help command, but could still be used. * core/types: improve accuracy of header.Size() (ethereum#25859) The header.Size() method did not take the basefee into account. * eth/tracers: pad memory slice on OOB case (ethereum#25213) * eth/tracers: pad memory slice on oob case * eth/tracers/js: fix testfailure due to err msg capitalization Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/faucet: fix readme typos (ethereum#25867) * Fix: typos Fix: typos * Undo change Undo change * core: fix datarace in txpool, fixes ethereum#25870 and ethereum#25869 (ethereum#25872) core: fix datarace in txpool pendingnoce, fixes ethereum#25870 * eth/downloader, les/downloader: fix subtle flaw in queue delivery (ethereum#25861) * fix queue.deliver * les/downloader: fix queue.deliver Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: better handle error on eip activation check (ethereum#25131) * core/vm: correct logic for eip check of NewEVMInterpreter * refactor * cmd/geth: make dumpgenesis load genesis datadir if it exists (ethereum#25135) `geth dumpgenesis` currently does not respect the content of the data directory. Instead, it outputs the genesis block created by command-line flags. This PR fixes it to read the genesis from the database, if the database already exists. Co-authored-by: Martin Holst Swende <martin@swende.se> * tests: fix state test error checking (ethereum#25702) Some tests define an 'expectException' error but the tests runner does not check for conditions where this test value is filled (error expected) but in which no error is returned by the test runner. An example of this scenario is GeneralStateTests/stTransactionTest/HighGasPrice.json, which expects a 'TR_NoFunds' error, but the test runner does not return any error. Signed-off-by: meows <b5c6@protonmail.com> * eth/tracers: use gencodec for native tracers (ethereum#25637) The call tracer and prestate tracer store data JSON-encoded in memory. In order to support alternative encodings (specifically RLP), it's better to keep data a native format during tracing. This PR does marshalling at the end, using gencodec. OBS! This PR changes the call tracer result slightly: - Order of type and value fields are changed (should not matter). - Output fields are completely omitted when they're empty (no more output: "0x"). Previously, this was only _sometimes_ omitted (e.g. when call ended in a non-revert error) and otherwise 0x when the output was actually empty. * cmd, core, eth, les, light: track deleted nodes (ethereum#25757) * cmd, core, eth, les, light: track deleted nodes * trie: add docs * trie: address comments * cmd, core, eth, les, light, trie: trie id * trie: add tests * trie, core: updates * trie: fix imports * trie: add utility print-method for nodeset * trie: import err * trie: fix go vet warnings Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: return state error via GetEVM (ethereum#25876) * make vmError more useful * fix for review * Update api.go * revert calling site Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * eth/downloader: make flakey test less flakey (ethereum#25879) * ethclient/gethclient: fix bugs in override object encoding (ethereum#25616) This fixes a bug where contract code would be overridden to empty code ("0x") when the Code field of OverrideAccount was left nil. The change also cleans up the encoding of overrides to only send necessary fields, and improves documentation. Fixes ethereum#25615 Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * trie, eth/protocols/snap: less tiny db-writes during trie-healing (ethereum#25681) This PR prevent making tiny writes during state healing, by only performing the batch-write if the accumulated data is large enough to be meaningful. * accounts/abi/bind/backends: fix AdjustTime to respect Fork (ethereum#25225) * tests: report mgas/s metric in evm benchmarks (ethereum#25700) * test(state): report mgas/s metric in EVM benchmark * revert testdata submodule update * aggregate mgas/s results * calculate elapsed time better * tests: benchmarks - handle access list + take refund into account Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: minor trivial clean up (ethereum#25880) * dropped `vm.keccakState` for `crypto.KeccakState` * cleaned up `OpCode.IsPush()` * eth/tracers: fix a bug in prestateTracer (ethereum#25884) * internal/ethapi: handle odd length hex in decodeHash (ethereum#25883) This change adds zero-padding (prefix) of odd nibbles in the decodeHash function. Co-authored-by: ty <ty@oncoder.com> * core: rework tx indexer (ethereum#25723) This PR reworks tx indexer a bit. Compared to the original version, one scenario is no longer handled - upgrading from legacy geth without indexer support. The tx indexer was introduced in 2020 and have been present through hardforks, so it can be assumed that all Geth nodes have tx indexer already. So we can simplify the tx indexer logic a bit: - If the tail flag is not present, it means node is just initialized may or may not with an ancient store attached. In this case all blocks are regarded as unindexed - If the tail flag is present, it means blocks below tail are unindexed, blocks above tail are indexed This change also address some weird cornercases that could make the indexer not work after a crash. * accounts/abi: return toGoType error immediately (ethereum#25565) * eth/tracers: remove revertReasonTracer, add revert reason to callTracer (ethereum#25508) * eth/tracers: add revertReason to callTracer * update callframe gen json * add revertal to calltrace test * accounts/abi/bind: parse ABI only once on bind (ethereum#25574) * accounts/abi/bind: parse ABI once on bind * accounts/abi/bind: suppress 'imported and not used' error for abi package * internal/flags: fix issue with stringslice migration (ethereum#25830) This fixes a cornercase bug where the flag migration would mess up the value of StringSlice flags. * cmd/geth, cmd/utils: geth attach with custom headers (ethereum#25829) This PR makes it possible to set custom headers, in particular for two scenarios: - geth attach - geth commands which can use --remotedb, e..g geth db inspect The ability to use custom headers is typically useful for connecting to cloud-apis, e.g. providing an infura- or alchemy key, or for that matter access-keys for environments behind cloudflare. Co-authored-by: Felix Lange <fjl@twurst.com> * core/types: add a testcase to TestLegacyReceiptDecoding (ethereum#25909) add a testcase to TestLegacyReceiptDecoding * eth/protocols/snap: serve snap requests when possible (ethereum#25644) This PR makes it so that the snap server responds to trie heal requests when possible, even if the snapshot does not exist. The idea being that it might prolong the lifetime of a state root, so we don't have to pivot quite as often. * eth, miner: add timeout for building sealing block (ethereum#25407) * eth, miner: add timeout for building sealing block * eth, cmd, miner: add newpayloadtimeout flag * eth, miner, cmd: address comments * eth, miner: minor fixes Co-authored-by: Martin Holst Swende <martin@swende.se> * all: fix docstrings * core: fix linter complaint (ethereum#25927) * eth/tracers: add diffMode to prestateTracer (ethereum#25422) Backwards compatibility warning: The result will from now on omit empty fields instead of including a zero value (e.g. no more `balance: '0x'`). The prestateTracer will now take an option `diffMode: bool`. In this mode the tracer will output the pre state and post data for the modified parts of state. Read-only accesses will be completely omitted. Creations (be it account or slot) will be signified by omission in the `pre` list and inclusion in `post`. Whereas deletion (be it account or slot) will be signified by inclusion in `pre` and omission in `post` list. Signed-off-by: Delweng <delweng@gmail.com> * eth/traces: add state limit (ethereum#25812) This PR introduces a new mechanism in chain tracer for preventing creating too many trace states. The workflow of chain tracer can be divided into several parts: - state creator generates trace state in a thread - state tracer retrieves the trace state and applies the tracing on top in another thread - state collector gathers all result from state tracer and stream to users It's basically a producer-consumer model here, while if we imagine that the state producer generates states too fast, then it will lead to accumulate lots of unused states in memory. Even worse, in path-based state scheme it will only keep the latest 128 states in memory, and the newly generated state will invalidate the oldest one by marking it as stale. The solution for fixing it is to limit the speed of state generation. If there are over 128 states un-consumed in memory, then the creation will be paused until the states are be consumed properly. * core/bloombits: speed up windows-test (ethereum#25844) core/bloombits: remove micro-sleep * core, ethclient/gethclient: improve flaky tests (ethereum#25918) * ethclient/gethclient: improve time-sensitive flaky test * eth/catalyst: fix (?) flaky test * core: stop blockchains in tests after use * core: fix dangling blockchain instances * core: rm whitespace * eth/gasprice, eth/tracers, consensus/clique: stop dangling blockchains in tests * all: address review concerns * core: goimports * eth/catalyst: fix another time-sensitive test * consensus/clique: add snapshot test run function * core: rename stop() to stopWithoutSaving() Co-authored-by: Felix Lange <fjl@twurst.com> * node: prevent exposing engine API on unauthenticated endpoint (ethereum#25939) * node: prevent exposing engine API on unauthenticated endpoint * node: improve RPC setup * eth/filters: fix for eth_getLogs failing with finalized- and safe tag (ethereum#25922) Prior to this change, f.begin (and possibly end) stay negative, leading to strange results later in the code. With this change, filters using "safe" and "finalized" block produce results consistent w/ the overall behavior of this RPC method. Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: fix help output issues (ethereum#25941) This update resolves an issue where StringSliceFlag would not be rendered correctly in help output + mention that -H can be used multiple times Co-authored-by: Martin Holst Swende <martin@swende.se> * accounts/usbwallet: support Ledger Nano S Plus and FTS (ethereum#25933) * usbwallet support Ledger Nano S Plus * accounts/usbwallet: add definitions + ref to ledger docs Co-authored-by: Martin Holst Swende <martin@swende.se> * all: fix spelling mistakes (ethereum#25961) * cmd/geth, core: fix typo in comment (ethereum#25954) * fix typo on comment * typo "can't accept" * core/rawdb: provide more info on 'gap in the chain' error (ethereum#25938) * core/types: add more context around ErrInvalidChainID (ethereum#25367) This changes the error message for mismatching chain ID to show the given and expected value. Callers expecting this error must be changed to use errors.Is. * common/math: optimized modexp (+ fuzzer) (ethereum#25525) This adds a * core/vm, tests: optimized modexp + fuzzer * common/math: modexp optimizations * core/vm: special case base 1 in big modexp * core/vm: disable fastexp * tests/fuzzers/modexp: gofmt (ethereum#25972) * node: drop support for static & trusted node list files (ethereum#25610) This changes the node setup to ignore datadir files static-nodes.json trusted-nodes.json When these files are present, it an error will be printed to the log. * accounts/keystore: faster tests (ethereum#25827) This PR removes some optimistic tests -- a'la "do something, wait a while, and hope it has trickled through and continue" -- and instead uses some introspection to ensure that prerequisites are met. * eth/protocols/eth: fix typo in log message (ethereum#25969) * eth/filters, ethclient/gethclient: add fullTx option to pending tx filter (ethereum#25186) This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes. In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly. Co-authored-by: Felix Lange <fjl@twurst.com> * go.mod: upgrade github.com/dop251/goja (ethereum#25955) This upgrade pulls in a fix to handling of 'continue' in loops. * eth/tracers: fix the issue of panic in prestate with diffmode (ethereum#25957) In some cases, inner contract creation may not be successful, and an inner contract was not created. This PR fixes a crash that could occur when doing tracing in such situations. * Revert "go.mod: upgrade github.com/dop251/goja" (ethereum#25975) Revert "go.mod: upgrade github.com/dop251/goja (ethereum#25955)" This reverts commit 9207e34. * common/math, tests/fuzzers: use big.Int clone (ethereum#26006) * common/math, tests/fuzzers: use big.Int clone * common/math: license * cmd/utils: enable snapshot generation in import-mode (ethereum#25990) This PR fixes a regression causing snapshots not to be generated in "geth --import" mode. It also fixes the geth export command to be truly readonly, and adds a new test for geth export. * core/rawdb: refactor db key prefix (ethereum#26000) Co-authored-by: seven <seven@nodereal.io> * core/rawdb: open meta file in read only mode (ethereum#26009) * internal/ethapi, accounts/abi/backends: use error defined in core (ethereum#26012) Co-authored-by: seven <seven@nodereal.io> * eth/tracers: fix the issue prestate missing existing contract state (ethereum#25996) The prestate tracer did not report accounts that existed at a given address prior to a contract being created at that address. Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * eth/tracers: simplify test framework (ethereum#25973) Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * all: refactor txpool into it's own package in prep for 4844 * core/types: rename tx files to group them better together * core, eth: for types with accurate size calcs, return uint64, not float (ethereum#26046) * core, eth: for types with accurate size calcs, return uint64, not float * core/types: proper tx size tests * core/types: extend tx size test with decoded sizes, fix error * core/txpool: fix linter Co-authored-by: Martin Holst Swende <martin@swende.se> * build: upgrade -dlgo version to Go 1.19.2 * accounts/scwallet: fix keycard data signing error (ethereum#25331) accounts/scwallet: fix keycard data signing * build: make ios work again (ethereum#26052) * core/vm: use optimized bigint (ethereum#26021) * eth/filters: change filter block to be by-ref (ethereum#26054) This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash * core/rawdb: refactor db inspector for extending multiple ancient store (ethereum#25896) This PR ports a few changes from PBSS: - Fix the snapshot generator waiter in case the generation is not even initialized - Refactor db inspector for ancient store * cmd/evm: calc base fee if parent data is present (ethereum#26051) Currently, in order to chain together sequential valid t8n transitions the caller must manually calculate the block base fee. This PR adds support for the necessary parent fee market data to calculate the base fee for the current transition. Concretely, env is extended to accept the following: parentBaseFee parentGasUsed parentGasLimit Example usage can be found in ./cmd/evm/testdata/25. Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: fix gasUsed for native and JS tracers (ethereum#26048) * eth/tracers: fix gasUsed in call tracer * fix js tracers gasUsed * fix legacy prestate tracer * fix restGas in test * drop intrinsicGas field from js tracers * cmd, eth: implement full-sync tester (ethereum#26035) This PR adds a parameter to startup, --synctarget. The synctarget flag is a developer-flag, that can be useful in some scenarios as a replacement for a CL node. It defines a fixed block sync target: geth --syncmode=full --synctarget=./block_15816882.hex_rlp The --synctarget is only made available during syncmode=full * rpc: update docstring (ethereum#26072) Co-authored-by: seven <seven@nodereal.io> * Fix trace call for inner reverts (ethereum#25971) Inner call reverts will now return the reason similar to the top-level call. Separately, if top-level call is of type CREATE and it fails, its `to` field will now be cleared to `0x00...00` instead of being set to the created address. * eth: implement eth/68 (ethereum#25980) * eth: implement eth/68 * eth/protocols/eth: added tx size to announcement * eth/protocols/eth: check equal lengths on receiving announcement * eth/protocols/eth: add +1 to tx size because of the type byte * eth: happy lint, add eth68 tests, enable eth68 * eth: various nitpick fixes on eth/68 * eth/protocols/eth: fix announced tx size wrt type byte Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers: add withLog to callTracer (ethereum#25991) In some cases, it is desirable to capture what is triggered by each trace, when using the `callTracer`. For example: call `USDT.transfer` will trigger a `Transfer(from, to, value)` event. This PR adds the option to capture logs to the call tracer, by specifying `{"withLog": true}` in the tracerconfig. Any logs belonging to failed/reverted call-scopes are removed from the output, to prevent interpretation mistakes. Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * eth/tracers: prestateTracer - exclude unchanged storage slots in diffMode (ethereum#25944) Fixes ethereum#25943 * accounts/abi: return error on fixed bytes with size larger than 32 bytes (ethereum#26075) * fixed bytes with size larger than 32 bytes is not allowed * add testcase * consensus/ethash: fix typo (ethereum#26016) fix typo * docs/postmortems: remove wrong parentheses (ethereum#26066) Removed parentheses in line 71 because line 80 doesn't have them either. * miner, eth: implement recommit mechanism for payload building (ethereum#25836) * miner, eth: implement recommit for payload building * miner: address comments from marius * miner: fail early if core.NewBlockChain fails (ethereum#26079) don't ignore errors returned by core.NewBlockChain when initializing tests * p2p/discover: fix handling of distance 256 in lookupDistances (ethereum#26087) Noticed that lookupDistances for FINDNODE requests didn't consider 256 a valid distance. This is actually part of the example in the comment above the function, surprised that wasn't tested before. * rlp: add more tests for nil pointer / optional field encoding (ethereum#26077) * rpc: handle wrong HTTP batch response length (ethereum#26064) * cmd/clef: add `list-accounts` and `list-wallets` to CLI (ethereum#26080) This commit adds support for two new commands to clef, making it possible to list accounts / wallets from the command-line-interface. Co-authored-by: Martin Holst Swende <martin@swende.se> * merge devnet-v3 with latest master, part 1 * crypto/bls12381: docs - fix broken links to references (ethereum#26095) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Signed-off-by: meows <b5c6@protonmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: xinbenlv <zzn@zzn.im> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: uji <49834542+uji@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rachel Bousfield <nfranks@protonmail.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: Jakub Freebit <49676311+jakub-freebit@users.noreply.github.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: xternet <majewski.post@gmail.com> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Nicholas <nicholas.zhaoyu@gmail.com> Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Benjamin Prosnitz <bprosnitz@gmail.com> Co-authored-by: Nicolas Gotchac <ngotchac@gmail.com> Co-authored-by: pinkiebell <40266861+pinkiebell@users.noreply.github.com> Co-authored-by: George Carder <georgercarder@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: makcandrov <108467407+makcandrov@users.noreply.github.com> Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Boqin@MetaSecureLabs <Bobbqqin@gmail.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Leon <316032931@qq.com> Co-authored-by: meowsbits <b5c6@protonmail.com> Co-authored-by: Janko Simonovic <simonovic86@gmail.com> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: TY <45994721+tylerK1294@users.noreply.github.com> Co-authored-by: ty <ty@oncoder.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: Mikhail Vazhnov <michael.vazhnov@gmail.com> Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> Co-authored-by: jin <35813306+lochjin@users.noreply.github.com> Co-authored-by: Paul <41552663+molecula451@users.noreply.github.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: seven <seven@nodereal.io> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: vdwijden <115323661+vdwijden@users.noreply.github.com> Co-authored-by: Sebastian Supreme <106926150+SebastianSupreme@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com>
roberto-bayardo
added a commit
to mdehoog/go-ethereum
that referenced
this issue
Nov 16, 2022
* merge devnet-v3 with latest master (#43) * cmd. core: save preimages on genesis creation (ethereum#25538) force preimage dump for genesis * rlp/rlpgen: fix error handling when target type not found (ethereum#25547) typ will be nil when lookupStructType returns an error. cfg.Type should be used instead. * trie: improve node rlp decoding performance (ethereum#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input must be copied, because it is now only copied once in decodeNode. * all: fix some typos (ethereum#25551) * Fix some typos * Fix some mistakes * Revert 4byte.json * Fix an incorrect fix * Change files to fails * internal/ethapi: fix comment typo (ethereum#25548) * accounts/abi/bind/backends: typo fix (ethereum#25549) * eth, les: unlock downloader peerSet if there's an error (ethereum#25546) Unlock peerSet if there's an error in the downloader * cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545) Parse uint64 value with ParseUint instead of Atoi * consensus/beacon: check ttd reached on pos blocks (ethereum#25552) * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * consensus/beacon: check ttd reached on pos blocks * eth/filters: add global block logs cache (ethereum#25459) This adds a cache for block logs which is shared by all filters. The cache size of is configurable using the `--cache.blocklogs` flag. Co-authored-by: Felix Lange <fjl@twurst.com> * accounts/abi: fix set function (ethereum#25477) * accounts/abi: fix set function * don't break things * update test * internal/ethapi: fix build regression (ethereum#25555) * eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524) * eth/fetcher: introduce some lag in tx fetching * eth/fetcher: change conditions a bit * eth/fetcher: use per-batch quota check * eth/fetcher: fix some comments * eth/fetcher: address review concerns * eth/fetcher: fix panic + add warn log * eth/fetcher: fix log * eth/fetcher: fix log * cmd/devp2p/internal/ethtest: fix ignorign tx announcements from prev. tests * cmd/devp2p/internal/ethtest: fix TestLargeTxRequest This increases the number of tx relay messages the test waits for. Since go-ethereum now processes incoming txs in smaller batches, the announcement messages it sends are also smaller. Co-authored-by: Felix Lange <fjl@twurst.com> * Revert "eth/fetcher: don't spend too much time on transaction inclusion" (ethereum#25567) Revert "eth/fetcher: don't spend too much time on transaction inclusion (ethereum#25524)" This reverts commit 0ce494b. * eth/catalyst: warn less frequently if no beacon client is available (ethereum#25569) * eth/catalyst: warn less frequently if no beacon client is available * eth/catalyst: tweak warning frequency a bit * eth/catalyst: some more tweaks * Update api.go Co-authored-by: Felix Lange <fjl@twurst.com> * params: release go-ethereum v1.10.22 * params: begin v1.10.23 release cycle * core, eth/downloader: handle spurious junk bodies from racey rollbacks (ethereum#25578) * eth/downloader: handle junkbodies/receipts in the beacon sync * core: check for header presence when checking for blocks * core/state, trie: fix trie flush order for proper pruning * consensus/beacon: don't ignore errors * params: release Geth v1.10.23 * params: begin v1.10.24 release cycle * params: begin go-ethereum v1.11 release cycle * internal/ethapi: rename debug getters to match spec (ethereum#25176) Some small fixes to get the existing debug methods to conform to the spec. Mainly dropping the encoding information from the method name as it should be deduced from the debug context and allowing the method to be invoked by either block number or block hash. It also adds the method debug_getTransaction which returns the raw tx bytes by tx hash. This is pretty much equivalent to the eth_getRawTransactionByHash method. * accounts/abi/bind: add const for tx fee elasticity multiplier (ethereum#25504) Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * all: remove duplicate word in comments (ethereum#25618) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> * cmd/geth: fix legacy receipt detection for empty db (ethereum#25609) * build: fix ignored errors (ethereum#25591) * docs: specify execution client (ethereum#25566) Co-authored-by: Felix Lange <fjl@twurst.com> * ethclient: add 'finalized' and 'safe' block number support (ethereum#25580) * node: change JWT error status to 401 Unauthorized (ethereum#25629) * node: fix regression in TestJWT (ethereum#25635) * all: move genesis initialization to blockchain (ethereum#25523) * all: move genesis initialization to blockchain * core: add one more check * core: fix tests * eth/catalyst: adjust eta for themerge (ethereum#25601) * eth/catalyst: adjust eta for themerge * squash * squash * eth/catalyst: address review concerns * mobile: close node on error (ethereum#25643) * graphql: return correct logs for tx (ethereum#25612) * graphql: fix tx logs * minor * Use optimized search for selecting tx logs * trie: fix grammar in comment (ethereum#25648) * eth/protocols/snap: fix problems due to idle-but-busy peers * trie: cleanup stateTrie (ethereum#25640) It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR. * eth/catalyst: prevent division by zero (ethereum#25654) eth/catalyst: prevent diff by zero * trie: better error reporting (ethereum#25645) * core/state: filter out nil trie for copy (ethereum#25575) * mobile: register filter APIs (ethereum#25642) This fixes a regression introduced in PR ethereum#25459. * README.md: improve grammar (ethereum#25646) Co-authored-by: Felix Lange <fjl@twurst.com> * eth/tracers/js: fill in log.refund field (ethereum#25661) For some reason, an accessor method for this field exists in JS, but the value was never actually assigned. * eth/fetcher: throttle peers which deliver many invalid transactions (ethereum#25573) Co-authored-by: Felix Lange <fjl@twurst.com> * node, rpc: add JWT auth support in client (ethereum#24911) This adds a generic mechanism for 'dial options' in the RPC client, and also implements a specific dial option for the JWT authentication mechanism used by the engine API. Some real tests for the server-side authentication handling are also added. Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Felix Lange <fjl@twurst.com> * rpc: check that "version" is "2.0" in request objects (ethereum#25570) The JSON-RPC spec requires the "version" field to be exactly "2.0", so we should verify that. This change is not backwards-compatible with sloppy client implementations, but I decided to go ahead with it anyway because the failure will be caught via the returned error. * trie: fix typo in comment (ethereum#25667) * trie: fix unhandled error in test (ethereum#25628) * eth/tracers/js: improve integer types in log object (ethereum#25668) All fields related to gas must be represented as uint64. Depth is internally tracked as int, so it makes sense to also store it as int. * trie: check childrens' existence concurrently for snap heal * core, light, trie: remove DiskDB function from trie database (ethereum#25690) * params: update chts (ethereum#25707) * core/vm: rename RANDOM to PREVRANDAO (ethereum#25691) See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-4399.md > This EIP supplants the semantics of the return value of existing DIFFICULTY (0x44) opcode and renames the opcode to PREVRANDAO (0x44). * all: cleanup tests (ethereum#25641) Follow-up to PR ethereum#25523 to cleanup all relevant tests. * eth, les: rework chain tracer (ethereum#25143) This PR simplifies the logic of chain tracer and also adds the unit tests. The most important change has been made in this PR is the state management. Whenever a tracing state is acquired there is a corresponding release function be returned as well. It must be called once the state is used up, otherwise resource leaking can happen. And also the logic of state management has been simplified a lot. Specifically, the state provider(eth backend, les backend) should ensure the state is available and referenced. State customers can use the state according to their own needs, or build other states based on the given state. But once the release function is called, there is no guarantee of the availability of the state. Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracer: fix broken test (ethereum#25715) * trie: update comments + err check for preimages (ethereum#25672) This PR includes minor updates to comments in trie/committer that reference insertion to the db, and adds an err != nil check for the return value of preimages.commit. * eth/protocols/snap: throttle trie heal requests when peers DoS us (ethereum#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <martin@swende.se> * p2p/msgrate: be more lenient when calculating 'mean' (ethereum#25653) The p2p msgrate tracker is a thing which tries to estimate some mean round-trip times. However, it did so in a very curious way: if a node had 200 peers, it would sort their 200 respective rtt estimates, and then it would pick item number 2 as the mean. So effectively taking third fastest and calling it mean. This probably works "ok" when the number of peers are low (there are other factors too, such as ttlScaling which takes some of the edge off this) -- however when the number of peers is high, it becomes very skewed. This PR instead bases the 'mean' on the square root of the length of the list. Still pretty harsh, but a bit more lenient. * rpc: improve error codes for internal server errors (ethereum#25678) This changes the error code returned by the RPC server in certain situations: - handler panic: code -32603 - result marshaling error: code -32603 - attempt to subscribe via HTTP: code -32001 In all of the above cases, the server previously returned the default error code -32000. Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com> * core: place a cap on reorglogs (ethereum#25711) This PR makes the event-sending for deleted and new logs happen in batches, to prevent OOM situation due to large reorgs. Co-authored-by: Felix Lange <fjl@twurst.com> * build: upgrade to go 1.19 (ethereum#25726) This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change. * p2p/discover/v5wire: reject packets smaller than 63 bytes (ethereum#25740) * core: preallocate maps in TxPool helper methods (ethereum#25737) * accounts/abi: fix typo in error message (ethereum#25742) * graphql: fixes missing tx logs (ethereum#25745) * graphql: fix tx logs * graphql: refactor test service setup * graphql: add test for tx logs * cmd/geth: add a verkle subcommand (ethereum#25718) * cmd/geth: add a verkle subcommand * fix copyright year * remove unused command parameters * check that the output file was successfully written to Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: goimports fix Co-authored-by: Martin Holst Swende <martin@swende.se> * node: fix HTTP server always force closing (ethereum#25755) Co-authored-by: Felix Lange <fjl@twurst.com> * core: fix log order in "Imported new chain segment" (ethereum#25768) * node: fix lint issue in rpcstack.go (ethereum#25774) * les/catalyst/api: add support for ExchangeTransitionConfigurationV1 (ethereum#25752) This method is missing in light client mode and breaks consensus clients that require a valid response. * params: set TerminalTotalDifficultyPassed to true (ethereum#25769) * params: set TerminalTotalDifficultyPassed to true * Update params/config.go Co-authored-by: Martin Holst Swende <martin@swende.se> * trie: handle more batch commit errors in Database (ethereum#25674) * core/rawdb: fix leak of backoff timer (ethereum#25776) * crypto/bls12381: docfix of g1 Affine (ethereum#25729) bls12381: docfix of g1 Affine. * internal/ethapi: return error when requesting invalid trie key (ethereum#25762) This change makes eth_getProof and eth_getStorageAt return an error when the argument contains invalid hex in storage keys. Co-authored-by: Felix Lange <fjl@twurst.com> * core: don't cache zero nonce in txNoncer (ethereum#25603) This changes the nonce cache used by TxPool to not store cached nonces for non-existing accounts. * core: more compact bad block report (ethereum#25714) This shortens the chain config summary in bad block reports, and adds go-ethereum version information as well. Co-authored-by: Felix Lange <fjl@twurst.com> * core: move build version reading to its own package (ethereum#25806) This fixes the build with Go 1.17, which does not have BuildInfo.Settings yet. * eth: fix a rare datarace on CHT challenge reply / shutdown * core/vm: return copy of input slice in identity precompile, avoid returndata copy (ethereum#25183) * core/vm: return copy of input slice in identity precompile. don't deep copy return data slice upon call completion * make use of common.CopyBytes * core/blockchain: downgrade tx indexing and unindexing logs (ethereum#25832) core/blockchain: downgrade tx indexing and unindexing logs from info to debug If a user has a finite tx lookup limit, they will see an "unindexing" info level log each time a block is imported. This information might help a user understand that they are removing the index each block and some txs may not be retrievable by hash, but overall it is generally more of a nuisance than a benefit. This change downgrades the log to a debug log. * eth/tracers: fix trace config for `TraceCall` (ethereum#25821) Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> * eth/catalyst: add locking around newpayload (ethereum#25816) Sometimes we get stuck on db compaction, and the CL re-issues the "same" command to us multiple times. Each request get stuck on the same place, in the middle of the handler. This changes makes it so we do not reprocess the same payload, but instead detects it early. * eth/catalyst: make tests run faster (ethereum#25818) * cmd/utils: make --authrpc.jwtsecret a DirectoryFlag (ethereum#25849) Signed-off-by: Delweng <delweng@gmail.com> * eth/protocols/snap: make log messages more clear that sync is ongoing (ethereum#25837) * eth/protocols/snap: make log messages more clear that sync is ongoing * Update sync.go Co-authored-by: Felix Lange <fjl@twurst.com> * .github: add CL client to issue template (ethereum#25814) * p2p: add channel buffers to avoid goroutine leaks in tests (ethereum#24929) * internal/version: use gitCommit injection in version handling code (ethereum#25851) This changes the CI build to store the git commit and date into package internal/version instead of package main. Doing this essentially merges our two ways of tracking the go-ethereum version into a single place, achieving two objectives: - Bad block reports, which use version.Info(), will now have the git commit information even when geth is built in an environment such as launchpad.net where git access is unavailable. - For geth builds created by `go build ./cmd/geth` (i.e. not using `go run build/ci.go install`), git information stored by the go tool is now used in the p2p node name as well as in `geth version` and `geth version-check`. * cmd/abigen: change --exc to exclude by type name (ethereum#22620) The abigen exclusion pattern, previously on the form "path:type", now supports wildcards. Examples "*:type" to exclude a named type in all files, or "/path/to/foo.sol:*" all types in foo.sol. * tests, les, eth: remove mentions of deprecated Morden testnet (ethereum#23570) * remove morden * Update commons.go * Update handler.go * empty commit to make appveyor happy * all: clean up the configs for pruner and snapshotter (ethereum#22396) This PR cleans up the configurations for pruner and snapshotter by passing a config struct. And also, this PR disables the snapshot background generation if the chain is opened in "read-only" mode. The read-only mode is necessary in some cases. For example, we have a list of commands to open the etheruem node in "read-only" mode, like export-chain. In these cases, the snapshot background generation is non expected and should be banned explicitly. * cmd/puppeth, cmd/utils: finalize removal of gasTarget flag (ethereum#24370) This PR fully removes the --miner.gastarget flag, as previously it was only hidden from the geth --help command, but could still be used. * core/types: improve accuracy of header.Size() (ethereum#25859) The header.Size() method did not take the basefee into account. * eth/tracers: pad memory slice on OOB case (ethereum#25213) * eth/tracers: pad memory slice on oob case * eth/tracers/js: fix testfailure due to err msg capitalization Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/faucet: fix readme typos (ethereum#25867) * Fix: typos Fix: typos * Undo change Undo change * core: fix datarace in txpool, fixes ethereum#25870 and ethereum#25869 (ethereum#25872) core: fix datarace in txpool pendingnoce, fixes ethereum#25870 * eth/downloader, les/downloader: fix subtle flaw in queue delivery (ethereum#25861) * fix queue.deliver * les/downloader: fix queue.deliver Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: better handle error on eip activation check (ethereum#25131) * core/vm: correct logic for eip check of NewEVMInterpreter * refactor * cmd/geth: make dumpgenesis load genesis datadir if it exists (ethereum#25135) `geth dumpgenesis` currently does not respect the content of the data directory. Instead, it outputs the genesis block created by command-line flags. This PR fixes it to read the genesis from the database, if the database already exists. Co-authored-by: Martin Holst Swende <martin@swende.se> * tests: fix state test error checking (ethereum#25702) Some tests define an 'expectException' error but the tests runner does not check for conditions where this test value is filled (error expected) but in which no error is returned by the test runner. An example of this scenario is GeneralStateTests/stTransactionTest/HighGasPrice.json, which expects a 'TR_NoFunds' error, but the test runner does not return any error. Signed-off-by: meows <b5c6@protonmail.com> * eth/tracers: use gencodec for native tracers (ethereum#25637) The call tracer and prestate tracer store data JSON-encoded in memory. In order to support alternative encodings (specifically RLP), it's better to keep data a native format during tracing. This PR does marshalling at the end, using gencodec. OBS! This PR changes the call tracer result slightly: - Order of type and value fields are changed (should not matter). - Output fields are completely omitted when they're empty (no more output: "0x"). Previously, this was only _sometimes_ omitted (e.g. when call ended in a non-revert error) and otherwise 0x when the output was actually empty. * cmd, core, eth, les, light: track deleted nodes (ethereum#25757) * cmd, core, eth, les, light: track deleted nodes * trie: add docs * trie: address comments * cmd, core, eth, les, light, trie: trie id * trie: add tests * trie, core: updates * trie: fix imports * trie: add utility print-method for nodeset * trie: import err * trie: fix go vet warnings Co-authored-by: Martin Holst Swende <martin@swende.se> * eth: return state error via GetEVM (ethereum#25876) * make vmError more useful * fix for review * Update api.go * revert calling site Co-authored-by: rjl493456442 <garyrong0905@gmail.com> * eth/downloader: make flakey test less flakey (ethereum#25879) * ethclient/gethclient: fix bugs in override object encoding (ethereum#25616) This fixes a bug where contract code would be overridden to empty code ("0x") when the Code field of OverrideAccount was left nil. The change also cleans up the encoding of overrides to only send necessary fields, and improves documentation. Fixes ethereum#25615 Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Martin Holst Swende <martin@swende.se> * trie, eth/protocols/snap: less tiny db-writes during trie-healing (ethereum#25681) This PR prevent making tiny writes during state healing, by only performing the batch-write if the accumulated data is large enough to be meaningful. * accounts/abi/bind/backends: fix AdjustTime to respect Fork (ethereum#25225) * tests: report mgas/s metric in evm benchmarks (ethereum#25700) * test(state): report mgas/s metric in EVM benchmark * revert testdata submodule update * aggregate mgas/s results * calculate elapsed time better * tests: benchmarks - handle access list + take refund into account Co-authored-by: Martin Holst Swende <martin@swende.se> * core/vm: minor trivial clean up (ethereum#25880) * dropped `vm.keccakState` for `crypto.KeccakState` * cleaned up `OpCode.IsPush()` * eth/tracers: fix a bug in prestateTracer (ethereum#25884) * internal/ethapi: handle odd length hex in decodeHash (ethereum#25883) This change adds zero-padding (prefix) of odd nibbles in the decodeHash function. Co-authored-by: ty <ty@oncoder.com> * core: rework tx indexer (ethereum#25723) This PR reworks tx indexer a bit. Compared to the original version, one scenario is no longer handled - upgrading from legacy geth without indexer support. The tx indexer was introduced in 2020 and have been present through hardforks, so it can be assumed that all Geth nodes have tx indexer already. So we can simplify the tx indexer logic a bit: - If the tail flag is not present, it means node is just initialized may or may not with an ancient store attached. In this case all blocks are regarded as unindexed - If the tail flag is present, it means blocks below tail are unindexed, blocks above tail are indexed This change also address some weird cornercases that could make the indexer not work after a crash. * accounts/abi: return toGoType error immediately (ethereum#25565) * eth/tracers: remove revertReasonTracer, add revert reason to callTracer (ethereum#25508) * eth/tracers: add revertReason to callTracer * update callframe gen json * add revertal to calltrace test * accounts/abi/bind: parse ABI only once on bind (ethereum#25574) * accounts/abi/bind: parse ABI once on bind * accounts/abi/bind: suppress 'imported and not used' error for abi package * internal/flags: fix issue with stringslice migration (ethereum#25830) This fixes a cornercase bug where the flag migration would mess up the value of StringSlice flags. * cmd/geth, cmd/utils: geth attach with custom headers (ethereum#25829) This PR makes it possible to set custom headers, in particular for two scenarios: - geth attach - geth commands which can use --remotedb, e..g geth db inspect The ability to use custom headers is typically useful for connecting to cloud-apis, e.g. providing an infura- or alchemy key, or for that matter access-keys for environments behind cloudflare. Co-authored-by: Felix Lange <fjl@twurst.com> * core/types: add a testcase to TestLegacyReceiptDecoding (ethereum#25909) add a testcase to TestLegacyReceiptDecoding * eth/protocols/snap: serve snap requests when possible (ethereum#25644) This PR makes it so that the snap server responds to trie heal requests when possible, even if the snapshot does not exist. The idea being that it might prolong the lifetime of a state root, so we don't have to pivot quite as often. * eth, miner: add timeout for building sealing block (ethereum#25407) * eth, miner: add timeout for building sealing block * eth, cmd, miner: add newpayloadtimeout flag * eth, miner, cmd: address comments * eth, miner: minor fixes Co-authored-by: Martin Holst Swende <martin@swende.se> * all: fix docstrings * core: fix linter complaint (ethereum#25927) * eth/tracers: add diffMode to prestateTracer (ethereum#25422) Backwards compatibility warning: The result will from now on omit empty fields instead of including a zero value (e.g. no more `balance: '0x'`). The prestateTracer will now take an option `diffMode: bool`. In this mode the tracer will output the pre state and post data for the modified parts of state. Read-only accesses will be completely omitted. Creations (be it account or slot) will be signified by omission in the `pre` list and inclusion in `post`. Whereas deletion (be it account or slot) will be signified by inclusion in `pre` and omission in `post` list. Signed-off-by: Delweng <delweng@gmail.com> * eth/traces: add state limit (ethereum#25812) This PR introduces a new mechanism in chain tracer for preventing creating too many trace states. The workflow of chain tracer can be divided into several parts: - state creator generates trace state in a thread - state tracer retrieves the trace state and applies the tracing on top in another thread - state collector gathers all result from state tracer and stream to users It's basically a producer-consumer model here, while if we imagine that the state producer generates states too fast, then it will lead to accumulate lots of unused states in memory. Even worse, in path-based state scheme it will only keep the latest 128 states in memory, and the newly generated state will invalidate the oldest one by marking it as stale. The solution for fixing it is to limit the speed of state generation. If there are over 128 states un-consumed in memory, then the creation will be paused until the states are be consumed properly. * core/bloombits: speed up windows-test (ethereum#25844) core/bloombits: remove micro-sleep * core, ethclient/gethclient: improve flaky tests (ethereum#25918) * ethclient/gethclient: improve time-sensitive flaky test * eth/catalyst: fix (?) flaky test * core: stop blockchains in tests after use * core: fix dangling blockchain instances * core: rm whitespace * eth/gasprice, eth/tracers, consensus/clique: stop dangling blockchains in tests * all: address review concerns * core: goimports * eth/catalyst: fix another time-sensitive test * consensus/clique: add snapshot test run function * core: rename stop() to stopWithoutSaving() Co-authored-by: Felix Lange <fjl@twurst.com> * node: prevent exposing engine API on unauthenticated endpoint (ethereum#25939) * node: prevent exposing engine API on unauthenticated endpoint * node: improve RPC setup * eth/filters: fix for eth_getLogs failing with finalized- and safe tag (ethereum#25922) Prior to this change, f.begin (and possibly end) stay negative, leading to strange results later in the code. With this change, filters using "safe" and "finalized" block produce results consistent w/ the overall behavior of this RPC method. Co-authored-by: Martin Holst Swende <martin@swende.se> * cmd/geth: fix help output issues (ethereum#25941) This update resolves an issue where StringSliceFlag would not be rendered correctly in help output + mention that -H can be used multiple times Co-authored-by: Martin Holst Swende <martin@swende.se> * accounts/usbwallet: support Ledger Nano S Plus and FTS (ethereum#25933) * usbwallet support Ledger Nano S Plus * accounts/usbwallet: add definitions + ref to ledger docs Co-authored-by: Martin Holst Swende <martin@swende.se> * all: fix spelling mistakes (ethereum#25961) * cmd/geth, core: fix typo in comment (ethereum#25954) * fix typo on comment * typo "can't accept" * core/rawdb: provide more info on 'gap in the chain' error (ethereum#25938) * core/types: add more context around ErrInvalidChainID (ethereum#25367) This changes the error message for mismatching chain ID to show the given and expected value. Callers expecting this error must be changed to use errors.Is. * common/math: optimized modexp (+ fuzzer) (ethereum#25525) This adds a * core/vm, tests: optimized modexp + fuzzer * common/math: modexp optimizations * core/vm: special case base 1 in big modexp * core/vm: disable fastexp * tests/fuzzers/modexp: gofmt (ethereum#25972) * node: drop support for static & trusted node list files (ethereum#25610) This changes the node setup to ignore datadir files static-nodes.json trusted-nodes.json When these files are present, it an error will be printed to the log. * accounts/keystore: faster tests (ethereum#25827) This PR removes some optimistic tests -- a'la "do something, wait a while, and hope it has trickled through and continue" -- and instead uses some introspection to ensure that prerequisites are met. * eth/protocols/eth: fix typo in log message (ethereum#25969) * eth/filters, ethclient/gethclient: add fullTx option to pending tx filter (ethereum#25186) This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes. In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly. Co-authored-by: Felix Lange <fjl@twurst.com> * go.mod: upgrade github.com/dop251/goja (ethereum#25955) This upgrade pulls in a fix to handling of 'continue' in loops. * eth/tracers: fix the issue of panic in prestate with diffmode (ethereum#25957) In some cases, inner contract creation may not be successful, and an inner contract was not created. This PR fixes a crash that could occur when doing tracing in such situations. * Revert "go.mod: upgrade github.com/dop251/goja" (ethereum#25975) Revert "go.mod: upgrade github.com/dop251/goja (ethereum#25955)" This reverts commit 9207e34. * common/math, tests/fuzzers: use big.Int clone (ethereum#26006) * common/math, tests/fuzzers: use big.Int clone * common/math: license * cmd/utils: enable snapshot generation in import-mode (ethereum#25990) This PR fixes a regression causing snapshots not to be generated in "geth --import" mode. It also fixes the geth export command to be truly readonly, and adds a new test for geth export. * core/rawdb: refactor db key prefix (ethereum#26000) Co-authored-by: seven <seven@nodereal.io> * core/rawdb: open meta file in read only mode (ethereum#26009) * internal/ethapi, accounts/abi/backends: use error defined in core (ethereum#26012) Co-authored-by: seven <seven@nodereal.io> * eth/tracers: fix the issue prestate missing existing contract state (ethereum#25996) The prestate tracer did not report accounts that existed at a given address prior to a contract being created at that address. Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * eth/tracers: simplify test framework (ethereum#25973) Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * all: refactor txpool into it's own package in prep for 4844 * core/types: rename tx files to group them better together * core, eth: for types with accurate size calcs, return uint64, not float (ethereum#26046) * core, eth: for types with accurate size calcs, return uint64, not float * core/types: proper tx size tests * core/types: extend tx size test with decoded sizes, fix error * core/txpool: fix linter Co-authored-by: Martin Holst Swende <martin@swende.se> * build: upgrade -dlgo version to Go 1.19.2 * accounts/scwallet: fix keycard data signing error (ethereum#25331) accounts/scwallet: fix keycard data signing * build: make ios work again (ethereum#26052) * core/vm: use optimized bigint (ethereum#26021) * eth/filters: change filter block to be by-ref (ethereum#26054) This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash * core/rawdb: refactor db inspector for extending multiple ancient store (ethereum#25896) This PR ports a few changes from PBSS: - Fix the snapshot generator waiter in case the generation is not even initialized - Refactor db inspector for ancient store * cmd/evm: calc base fee if parent data is present (ethereum#26051) Currently, in order to chain together sequential valid t8n transitions the caller must manually calculate the block base fee. This PR adds support for the necessary parent fee market data to calculate the base fee for the current transition. Concretely, env is extended to accept the following: parentBaseFee parentGasUsed parentGasLimit Example usage can be found in ./cmd/evm/testdata/25. Co-authored-by: Martin Holst Swende <martin@swende.se> * eth/tracers: fix gasUsed for native and JS tracers (ethereum#26048) * eth/tracers: fix gasUsed in call tracer * fix js tracers gasUsed * fix legacy prestate tracer * fix restGas in test * drop intrinsicGas field from js tracers * cmd, eth: implement full-sync tester (ethereum#26035) This PR adds a parameter to startup, --synctarget. The synctarget flag is a developer-flag, that can be useful in some scenarios as a replacement for a CL node. It defines a fixed block sync target: geth --syncmode=full --synctarget=./block_15816882.hex_rlp The --synctarget is only made available during syncmode=full * rpc: update docstring (ethereum#26072) Co-authored-by: seven <seven@nodereal.io> * Fix trace call for inner reverts (ethereum#25971) Inner call reverts will now return the reason similar to the top-level call. Separately, if top-level call is of type CREATE and it fails, its `to` field will now be cleared to `0x00...00` instead of being set to the created address. * eth: implement eth/68 (ethereum#25980) * eth: implement eth/68 * eth/protocols/eth: added tx size to announcement * eth/protocols/eth: check equal lengths on receiving announcement * eth/protocols/eth: add +1 to tx size because of the type byte * eth: happy lint, add eth68 tests, enable eth68 * eth: various nitpick fixes on eth/68 * eth/protocols/eth: fix announced tx size wrt type byte Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de> Co-authored-by: Péter Szilágyi <peterke@gmail.com> * eth/tracers: add withLog to callTracer (ethereum#25991) In some cases, it is desirable to capture what is triggered by each trace, when using the `callTracer`. For example: call `USDT.transfer` will trigger a `Transfer(from, to, value)` event. This PR adds the option to capture logs to the call tracer, by specifying `{"withLog": true}` in the tracerconfig. Any logs belonging to failed/reverted call-scopes are removed from the output, to prevent interpretation mistakes. Signed-off-by: Delweng <delweng@gmail.com> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> * eth/tracers: prestateTracer - exclude unchanged storage slots in diffMode (ethereum#25944) Fixes ethereum#25943 * accounts/abi: return error on fixed bytes with size larger than 32 bytes (ethereum#26075) * fixed bytes with size larger than 32 bytes is not allowed * add testcase * consensus/ethash: fix typo (ethereum#26016) fix typo * docs/postmortems: remove wrong parentheses (ethereum#26066) Removed parentheses in line 71 because line 80 doesn't have them either. * miner, eth: implement recommit mechanism for payload building (ethereum#25836) * miner, eth: implement recommit for payload building * miner: address comments from marius * miner: fail early if core.NewBlockChain fails (ethereum#26079) don't ignore errors returned by core.NewBlockChain when initializing tests * p2p/discover: fix handling of distance 256 in lookupDistances (ethereum#26087) Noticed that lookupDistances for FINDNODE requests didn't consider 256 a valid distance. This is actually part of the example in the comment above the function, surprised that wasn't tested before. * rlp: add more tests for nil pointer / optional field encoding (ethereum#26077) * rpc: handle wrong HTTP batch response length (ethereum#26064) * cmd/clef: add `list-accounts` and `list-wallets` to CLI (ethereum#26080) This commit adds support for two new commands to clef, making it possible to list accounts / wallets from the command-line-interface. Co-authored-by: Martin Holst Swende <martin@swende.se> * merge devnet-v3 with latest master, part 1 * crypto/bls12381: docs - fix broken links to references (ethereum#26095) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Signed-off-by: meows <b5c6@protonmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: xinbenlv <zzn@zzn.im> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: uji <49834542+uji@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rachel Bousfield <nfranks@protonmail.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: Jakub Freebit <49676311+jakub-freebit@users.noreply.github.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: xternet <majewski.post@gmail.com> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Nicholas <nicholas.zhaoyu@gmail.com> Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Benjamin Prosnitz <bprosnitz@gmail.com> Co-authored-by: Nicolas Gotchac <ngotchac@gmail.com> Co-authored-by: pinkiebell <40266861+pinkiebell@users.noreply.github.com> Co-authored-by: George Carder <georgercarder@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: makcandrov <108467407+makcandrov@users.noreply.github.com> Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Boqin@MetaSecureLabs <Bobbqqin@gmail.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Leon <316032931@qq.com> Co-authored-by: meowsbits <b5c6@protonmail.com> Co-authored-by: Janko Simonovic <simonovic86@gmail.com> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: TY <45994721+tylerK1294@users.noreply.github.com> Co-authored-by: ty <ty@oncoder.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: Mikhail Vazhnov <michael.vazhnov@gmail.com> Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> Co-authored-by: jin <35813306+lochjin@users.noreply.github.com> Co-authored-by: Paul <41552663+molecula451@users.noreply.github.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: seven <seven@nodereal.io> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: vdwijden <115323661+vdwijden@users.noreply.github.com> Co-authored-by: Sebastian Supreme <106926150+SebastianSupreme@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com> * remove legacy kzg verification, put all initialization on top (#44) * add header & block fields for Withdrawals (#45) * add header & block fields for Withdrawals * Update cmd/evm/internal/t8ntool/block.go Co-authored-by: Inphi <mlaw2501@gmail.com> Co-authored-by: Inphi <mlaw2501@gmail.com> * use go-kzg PolyLinComb instead of local impl * make verify_kzg_proof apis more closely mimic the specs (#46) * move more low-level kzg stuff into kzg_new (#48) * start using custom types from the 4844 spec * move ComputePowers into kzg_new * 1) move BlobsToKZGCommitment functionality into kzg_new and make it more closely follow the spec. 2) Remove the BlobsBatch stuff which seems only to be for legacy benchmarking. * Replace kzg-related data_blob.go type methods Parse, ComputeCommitment, and Point, so we can move methods that depend on them into the kzg package. * Remove ComputeCommitments which is unused. * Add BytesToBLSField go kzg_new, use it instead of hashToFr * Update KZG library according to latest consensus spec changes (#49) * Replace kzg-related data_blob.go type methods Parse, ComputeCommitment, and Point, so we can move methods that depend on them into the kzg package. * Remove ComputeCommitments which is unused. * Migrate remaining EIP-4844 consensus spec code into kzg_new, updated to include the latest consensus spec updates. * Start implementing a bytes API with appropriate interfaces Also fix incorrect hash type (Keccac -> Sha256) when computing versioned hash. * pure bytes API for VerifyKZGProof per 3097, and move kzg_new back into kzg.go now that updates are near complete * rename verifyBlobs validateBlobTransactionWrapper per updated spec, and make implementation more closely follow it * fix tests & type bug in kzg verification * more consensus layer support in kzg package * remove aggregated proof from blobs bundle * propagate malformed blob errors when processing a sent transaction so that these get rejected * move more CL eip-4844 methods from prysm to shared lib (#50) Signed-off-by: Abirdcfly <fp544037857@gmail.com> Signed-off-by: Delweng <delweng@gmail.com> Signed-off-by: meows <b5c6@protonmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Co-authored-by: rjl493456442 <garyrong0905@gmail.com> Co-authored-by: ucwong <ucwong@126.com> Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: zhiqiangxu <652732310@qq.com> Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Péter Szilágyi <peterke@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: xinbenlv <zzn@zzn.im> Co-authored-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: uji <49834542+uji@users.noreply.github.com> Co-authored-by: Marius Kjærstad <sandakersmann@users.noreply.github.com> Co-authored-by: Rachel Bousfield <nfranks@protonmail.com> Co-authored-by: Seungbae Yu <dbadoy4874@gmail.com> Co-authored-by: Jakub Freebit <49676311+jakub-freebit@users.noreply.github.com> Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Co-authored-by: xternet <majewski.post@gmail.com> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Joshua Gutow <jgutow@optimism.io> Co-authored-by: Amir Hossein <77993374+Kamandlou@users.noreply.github.com> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Nicholas <nicholas.zhaoyu@gmail.com> Co-authored-by: Nicholas Zhao <nicholas.zhao@gmail.com> Co-authored-by: Benjamin Prosnitz <bprosnitz@gmail.com> Co-authored-by: Nicolas Gotchac <ngotchac@gmail.com> Co-authored-by: pinkiebell <40266861+pinkiebell@users.noreply.github.com> Co-authored-by: George Carder <georgercarder@gmail.com> Co-authored-by: jwasinger <j-wasinger@hotmail.com> Co-authored-by: makcandrov <108467407+makcandrov@users.noreply.github.com> Co-authored-by: AtomicAzzaz <AtomicAzzaz@users.noreply.github.com> Co-authored-by: ewile <ewile@users.noreply.github.com> Co-authored-by: Delweng <delweng@gmail.com> Co-authored-by: Boqin@MetaSecureLabs <Bobbqqin@gmail.com> Co-authored-by: Sebastian Stammler <stammler.s@gmail.com> Co-authored-by: Zachinquarantine <Zachinquarantine@protonmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: Leon <316032931@qq.com> Co-authored-by: meowsbits <b5c6@protonmail.com> Co-authored-by: Janko Simonovic <simonovic86@gmail.com> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: TY <45994721+tylerK1294@users.noreply.github.com> Co-authored-by: ty <ty@oncoder.com> Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Co-authored-by: Mikhail Vazhnov <michael.vazhnov@gmail.com> Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com> Co-authored-by: jin <35813306+lochjin@users.noreply.github.com> Co-authored-by: Paul <41552663+molecula451@users.noreply.github.com> Co-authored-by: Jens W <8270201+DragonDev1906@users.noreply.github.com> Co-authored-by: s7v7nislands <s7v7nislands@gmail.com> Co-authored-by: seven <seven@nodereal.io> Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com> Co-authored-by: Marius Kjærstad <mkjaerstad@protonmail.com> Co-authored-by: vdwijden <115323661+vdwijden@users.noreply.github.com> Co-authored-by: Sebastian Supreme <106926150+SebastianSupreme@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Joseph Cook <33655003+jmcook1186@users.noreply.github.com> Co-authored-by: Inphi <mlaw2501@gmail.com>
MoonShiesty
pushed a commit
to MoonShiesty/go-ethereum
that referenced
this issue
Aug 30, 2023
It's a trivial PR to hide the error log when the trie node is not found in the database. The idea for this change is for all TryXXX functions, the error is already returned and we don't need to fire a log explicitly. Recently there are a few tickets ethereum#25613 ethereum#25589 reporting that the trie nodes are missing because of debug.SetHead. The root cause is after resetting, the chain rewinds to a historical point and re-imports the blocks on top. Since the node is already synced and started to accept transactions previously, these transactions are still kept in the txpool and verified by txpool with a live state. This live state is constructed based on the live trie database, which is changed fast by node referencing and de-referencing. Unfortunately, when we construct a live state(like the state in txpool), we don't reference the state we have. The blockchain will garbage collect the intermediate version nodes in another thread which leads the broken live state. The best solution for this is to forcibly obtain a reference for all live states we create and call release function once it's used up. But it might end up with more junks persisted into disk. Will try to find an elegant solution later in the following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Hey, this morning I started using the 1.10.22 version this morning for maybe 1 hour, and then I saw that there were reports about regression bug with it. So I followed the instructions in the release notes for 1.10.23 to use
debug.setHeadwith a blocknumber older than when I moved from 1.10.21 to 1.10.22. I used block number 15400840 from 8 hours ago.0d15400840is0xEAFF88in hex, so I did this commandwhich looked like it hanged, and then after maybe a minute, I got this error output.:
Then I wanted to know which block I was at and if I was syncing:
So it looks like it used some other block number than what I specified, because currentBlock was set to
15371819and not15400840as I specified, which was weird.Now I see a crazy amount of errors in log
Maybe not relevant, I also saw:
But lighthouse is not running now, because of cannot start it sigp/lighthouse#3500
So what does this ocean of
Unhandled trie error: missing trie nodemean? Am I f**ked, do I have to do a clean sync from start (7 days)? Or is this normal, i.e. these errors will disappear onceseth.syncinggoes tofalse? Because when checking, it looks that I'm making progress:But I don't remember having seen
Unhandled trie error: missing trie nodebefore!Please please help <3
System information
Geth version: 1.10.23
OS & Version: macOS Monterey 12.5.1 (21G83)
Expected behaviour
Actual behaviour
Steps to reproduce the behaviour
Backtrace
When submitting logs: please submit them as text and not screenshots.
The text was updated successfully, but these errors were encountered: