TODO List #6

obscuren · 2014-01-25T15:28:28Z

suhr · 2014-03-02T22:24:14Z

Support Tor

What about I2P support?

obscuren · 2014-03-02T23:51:28Z

@suhr Undecided. We might roll our own session based for simplicities sake. We'll see.

Fix typo(?) in naming - s/GenisisHeader/GenesisHeader/

Changes from debris

Run JSHint on all code using Travis CI

eth: look in private an public state on reading state data

Tests and Benchmarks for Metro

Pull in the latest changes from go-ethereum

Update Readme.md

Ucwong

Fixed gas limit setting was not enforced Approved-by: Uh Sado <sadoc@metadium.com>

…) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function.

* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * typo fix

* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * typo fix * goerli flag finalized * config mod

* go modules added; preparing to write aura consensus * adding goerli flag * goerli flag added * adding configs * core/vm: Hide read only flag from Interpreter interface (ethereum#17461) (#6) Makes Interface interface a bit more stateless and abstract. Obviously this change is dictated by EVMC design. The EVMC tries to keep the responsibility for EVM features totally inside the VMs, if feasible. This makes VM "stateless" because VM does not need to pass any information between executions, all information is included in parameters of the execute function. * configuring genesis * removing duplicate imports * adding configs for aura api * configuring goerli cli flag * flag function fix * modifying configs

This reverts commit dabca31.

* added tests for new abi encoding features (#4) * added tests from bytes32[][] and string[] * added offset to other types * formatting * Abi/dynamic types (#5) * Revert "Abi/dynamic types (#5)" (#6) This reverts commit dabca31. * Abi/dynamic types (#7) * some cleanup * Apply suggestions from code review apply suggestions Co-Authored-By: vedhavyas <vedhavyas.singareddi@gmail.com> * added better formatting (#8) * review chnages * better comments

wijittrapha · 2018-12-27T07:20:36Z

I still not understand. But thank you.

* added tests for new abi encoding features (ethereum#4) * added tests from bytes32[][] and string[] * added offset to other types * formatting * Abi/dynamic types (ethereum#5) * Revert "Abi/dynamic types (ethereum#5)" (ethereum#6) This reverts commit dabca31. * Abi/dynamic types (ethereum#7) * some cleanup * Apply suggestions from code review apply suggestions Co-Authored-By: vedhavyas <vedhavyas.singareddi@gmail.com> * added better formatting (ethereum#8) * review chnages * better comments

Trie gen PR-ception

Rebase 1.2.2

Fixing broken tests, skipping tests we intentionally break, and configuring CI within Github Actions

* Get basic getStorage/setStorage stubs working * Clean up tests * Add state_manager * Add StateManager set & getStorage * Add state mananger create function * Add get & increment nonce * Add getCodeContractBytecode * Add GetCodeContractHash * Add getCodeContractHash to the state manager * Add associateCodeContract to state manager * Pass the tests * go fmt * Add stateTransition to test with * Fix tests * Test deploying contract with transition state * Call executeTransaction on contract deployment * Added ExecutionManager deployment * Get contract deployments working * Cleanup logging * Get stubbed ExecutionManager working * Get a simple contract to deploy through the ExecutionManager * Refactor simpleAbiEncode * Revert unnecessary changes * Remove comments * Revert changes outside of this PR * Revert changes outside of this PR * Revert changes outside of this PR * Fix broken tests * Move OVM bytecode & ABI into constants * Add crazy printlines * Remove crazy comments * Add a bunch of debug printlns * Add helper fn for applying msgs to the EVM * Update ExecutionManager bytecode * Shim CREATE for EM to use correct addr * Add SimpleStorage test * Add the EM/SM to all new states * Force all txs to be routed through the EM * Remove unused files * Remove unused comments * Increment nonce after failed tx * Add debug statements * Use evm.Time for timestamp * Change EM deployment, fix broken tests, clean up * Add an OVM test & remove printlns * Fix lint errors & remove final printlns * Final cleanup--remove some comments * Limiting Geth to one transaction per block (#3) * Limiting Geth to one transaction per block * Adding TransitionBatchBuilder to build & submit rollup blocks * Adding L1MessageSender to Transaction (#4) * Adding L1MessageSender to Transaction * Adding logic to omit L1MessageSender in encoding / decoding when nil and never use it in hash computation Co-authored-by: ben-chain <ben@pseudonym.party> * Fixing Geth Tests (ethereum#6) Fixing broken tests, skipping tests we intentionally break, and configuring CI within Github Actions * Hex Trie -> Binary Trie (ethereum#7) *** Changing Hex Trie to Binary Trie *** Note: This changes and/or comments out a bunch of tests, so if things break down the line, this is likely the cause! * Ingest Block Batches (ethereum#8) Handling BlockBatches in Geth at `SendBlockBatches` endpoint (eth_sendBlockBatches) Other: * Adding PR template * Adding ability to set timestamp and making blocks use configured timestamp * Adding ability to encode original tx nonce in calldata * Adding L1MessageSender to Contract Creation Txs * Add L1MessageSender to Message * Increment nonce on CREATE failure * Fix bug where evm.Time=0 * Use state dump with hardcoded EM & SM addrs - ExecutionMgr address should always be 0x0000...dead0000 - StateMgr address should always be 0x0000...dead0001 * Move EM deployment into genesis block maker * Update EM contracts to latest version * Update EM to remove events * Fix the OVM tests * Skip an ungodly number of tests * Fix lint errors * Clean up logging * Cleanup more logs * Use local reference to state manager * Rename applyOvmToState(..) * Remove unneeded check * Clean up logging & add EM ABI panic * Add gas metering to SM & small refactor * Update core/vm/state_manager.go Co-authored-by: Kevin Ho <kevinjho1996@gmail.com> Co-authored-by: Mason Fischer <mason@kissr.co> Co-authored-by: Will Meister <william.k.meister@gmail.com> Co-authored-by: ben-chain <ben@pseudonym.party> Co-authored-by: Kevin Ho <kevinjho1996@gmail.com>

* internal/build: implement signify's signing func * Add signify to the ci utility * fix output file format * Add unit test for signify * holiman's + travis' feedback * internal/build: verify signify's output * crypto: move signify to common dir * use go-minisign to verify binaries * more holiman feedback * crypto, ci: support minisign output * only accept one-line trusted comments * configurable untrusted comments * code cleanup in tests * revert to use ed25519 from the stdlib * bug: fix for empty untrusted comments * write timestamp as comment if trusted comment isn't present * rename line checker to commentHasManyLines * crypto: added signify fuzzer (#6) * crypto: added signify fuzzer * stuff * crypto: updated signify fuzzer to fuzz comments * crypto: repro signify crashes * rebased fuzzer on build-signify branch * hide fuzzer behind gofuzz build flag * extract key data inside a single function * don't treat \r as a newline * travis: fix signing command line * do not use an external binary in tests * crypto: move signify to crypto/signify * travis: fix formatting issue * ci: fix linter build after package move Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>

Fix 3

[R4R] modify params for Parlia consensus with 21 validators

* internal/build: implement signify's signing func * Add signify to the ci utility * fix output file format * Add unit test for signify * holiman's + travis' feedback * internal/build: verify signify's output * crypto: move signify to common dir * use go-minisign to verify binaries * more holiman feedback * crypto, ci: support minisign output * only accept one-line trusted comments * configurable untrusted comments * code cleanup in tests * revert to use ed25519 from the stdlib * bug: fix for empty untrusted comments * write timestamp as comment if trusted comment isn't present * rename line checker to commentHasManyLines * crypto: added signify fuzzer (ethereum#6) * crypto: added signify fuzzer * stuff * crypto: updated signify fuzzer to fuzz comments * crypto: repro signify crashes * rebased fuzzer on build-signify branch * hide fuzzer behind gofuzz build flag * extract key data inside a single function * don't treat \r as a newline * travis: fix signing command line * do not use an external binary in tests * crypto: move signify to crypto/signify * travis: fix formatting issue * ci: fix linter build after package move Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>

MAT-373 Repackage to bor

For whatever reasons the miners would appear to deadlock when this backoff time was 7s, 10s has been working reliably for a couple weeks.

Delete dependency about docker

…t-evaluation Fix point evaluation

Update config.go

core: do not try to reinject deposit txs

This commit squashes the op-geth fork history into a more maintainable diff for rebasing upon upstream geth. reference-optimistic-geth changes (origins of op-geth in early Bedrock development stage): - Deposit TX Type - Enable deposit tx in EVM/tx pool - Change deposit nonce to not be the max nonce - Extend PayloadAttributesV1 with a Transactions field - Force deposits at the start of each L2 block - Fix height check - noTxPool flag, reproduce block in verifier mode without tx pool interference - Fix RPC json marshalling (ref op-geth PR 4) - Deposit txs block height check in block body validation (ref op-geth PR 5) - core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6) - deposit source hash field instead of L2 block height and tx index combination - Include invalid deposits, rewind state, but always persist mint (ethereum#10) - Provide gas to Call/Create in deposit transactions (ethereum#12) - Add docker builds (ref-op-geth PR 16, 17) - Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18) - core: Add version to DepositTx (ref-op-geth PR 19) - Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23) - core: Include guaranteed gas in the gas pool (ref-op-geth PR 21) - core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27) - fix: deposit tx hash - fix l1 fee cache, rpc, tracing and tx pool - core: remove deposit-tx sub-type (a.k.a. deposit version byte) - eth/catalyst: allow engine user to reorg own chain - miner: restore ability to reorg deep as block builder - params: print Optimism consensus type in banner - core/types: remove unused protected() method, see upstream PR 23376 - core: do not mutate original balance value in tx pool l1 cost adjustment - core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit - core/types: deposits do not tip, avoid basefee subtraction - Unmeter the L1 Attributes Transaction - miner: handle force tx errors as critical, clean up diff - ci: Switch branch - eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40) - verifier: forward tx to sequencer based on flag - txpool: add flag to disable tx gossip (ref-op-geth PR 42) - Add op-geth version in addition to geth version (ref-op-geth PR 43) - ci: CircleCI improvements (ref-op-geth PR 44) - Rename to op-geth - Build latest tag on optimism branch op-geth changes: - Expose cache config in simulated backend (#2) - Add EIP-1559 parameters - eth/catalyst: update payload id computation (#1) - make eip1559 configurable (#4) - post-merge network should not log warnings about missing transition information (#5) - Make the simulator more configurable (ethereum#6) - fix OPB-6 - IsDepositTx check instead of artificial nonce value check (ethereum#7) - Simulated backend - enable proof of stake consensus type and fix performance issue (ethereum#8) - accounts: simulated backend consensus engine option and immediate tx indexing - consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config - Add --rollup.historicalhttp CLI flag and fix backend iface - Flags and interfaces for historical RPC requests (ethereum#12) - Redirect historical RPC requests (ethereum#13) - Use the pre-existing ethereum.NotFound error (ethereum#18) - Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (ethereum#19) - Add historical endpoint to TraceTransaction (ethereum#20) - Add historical endpoint to TraceCall (ethereum#21) - optimism: fee params from info txi, update l1 cost func GPO params read (ethereum#15) - add hardcoded addresses for fee payouts (ethereum#23) - dynamic gas limit via engine API (ethereum#22) Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Maurelian <maurelian@protonmail.ch>

* Implement block validation API * Validate proposer payment assuming its the last transaction in the block (ethereum#4) * Validate that the coinbase and feeRecipient are not blacklisted (ethereum#5) * Validate that the proposer payment has no calldata and its gas usage (ethereum#6) * Validate gas limit is set correctly wrt registered (ethereum#8) * Pass validation-specific config (ethereum#9)

add rpc ext_

…orage Create protected storage on the CREATE2 opcode

check chainid on nil

Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

add image release workflow

ghost assigned obscuren Jan 25, 2014

obscuren closed this as completed May 8, 2014

zelig referenced this issue in ethersphere/swarm Oct 23, 2014

Merge pull request #6 from sdboyer/genisis

3dae732

Fix typo(?) in naming - s/GenisisHeader/GenesisHeader/

obscuren pushed a commit that referenced this issue Jan 29, 2015

Merge pull request #6 from cubedro/develop

67e3eff

Changes from debris

obscuren added a commit that referenced this issue Jan 29, 2015

Merge pull request #6 from frewsxcv/master

c966a5c

Run JSHint on all code using Travis CI

ghost mentioned this issue Dec 13, 2015

iGeth mach_msg_trap #2069

Closed

devktor mentioned this issue Sep 18, 2016

Geth nodes crashes, memory leak #3002

Closed

bts pushed a commit to bts/go-ethereum that referenced this issue Feb 1, 2017

Merge pull request ethereum#6 from jpmorganchase/privpub

1491101

eth: look in private an public state on reading state data

ligi mentioned this issue May 7, 2017

Mobile: crash after Invalid odr response #14437

Closed

holiman referenced this issue in holiman/go-ethereum Jul 18, 2017

Merge pull request #6 from holiman/metro_benchmark_on_karalabe

d4a2269

Tests and Benchmarks for Metro

mazi5769 mentioned this issue Aug 16, 2017

Cannot run GDB with geth #14788

Closed

cdetrio pushed a commit to cdetrio/go-ethereum that referenced this issue Feb 24, 2018

Merge pull request ethereum#6 from ethereum/master

12c3eda

Pull in the latest changes from go-ethereum

phucnguyenit added a commit to phucnguyenit/go-ethereum that referenced this issue Jun 12, 2018

Merge pull request ethereum#6 from phucnguyenit/gkai/release/1.0

53a2b44

Update Readme.md

shiotoli pushed a commit to CortexFoundation/MinerInterface that referenced this issue Aug 14, 2018

Merge pull request ethereum#6 from CortexFoundation/ucwong

c1016a6

Ucwong

MetadiumRelease referenced this issue in METADIUM/go-metadium Aug 25, 2018

Merged in coinplugin/go-metadium (pull request #6)

83bf5db

Fixed gas limit setting was not enforced Approved-by: Uh Sado <sadoc@metadium.com>

xmxanuel pushed a commit to xmxanuel/go-ethereum that referenced this issue Nov 15, 2018

Revert "Abi/dynamic types (ethereum#5)" (ethereum#6)

fc490af

This reverts commit dabca31.

gballet referenced this issue in gballet/go-ethereum Feb 17, 2020

Merge pull request #6 from gballet/trie_gen

b483b0b

Trie gen PR-ception

rewrewby pushed a commit to rewrewby/mev-geth that referenced this issue Mar 3, 2020

Merge pull request ethereum#6 from expanse-project/rebase-1.2.1

7df403e

Rebase 1.2.2

tynes pushed a commit to tynes/go-ethereum that referenced this issue Sep 13, 2020

Fixing Geth Tests (ethereum#6)

57f1ac2

Fixing broken tests, skipping tests we intentionally break, and configuring CI within Github Actions

rjl493456442 referenced this issue in rjl493456442/go-ethereum Feb 2, 2021

Merge pull request #6 from AbnerDBFan/fix-3

94619cb

Fix 3

recmo pushed a commit to recmo/go-ethereum that referenced this issue Feb 17, 2021

Merge pull request ethereum#6 from guagualvcha/stale_depth

ce14f2c

[R4R] modify params for Parlia consensus with 21 validators

maoueh referenced this issue in streamingfast/go-ethereum Aug 13, 2021

Merge pull request #6 from maticnetwork/repackage

455b93a

MAT-373 Repackage to bor

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022

Reset backoff to 10s (ethereum#6)

89abf1a

For whatever reasons the miners would appear to deadlock when this backoff time was 7s, 10s has been working reliably for a couple weeks.

lochjin pushed a commit to lochjin/go-ethereum that referenced this issue Mar 18, 2022

Merge pull request ethereum#6 from lochjin/v1.10.9-qng

b6911f1

Delete dependency about docker

Inphi pushed a commit to Inphi/go-ethereum that referenced this issue Jun 21, 2022

Merge pull request ethereum#6 from dapperscene6/dapperscene6/fix-poin…

35856fb

…t-evaluation Fix point evaluation

duguyifang pushed a commit to btccom/go-ethereum that referenced this issue Aug 31, 2022

Merge pull request ethereum#6 from Polandia94/patch-1

233c5b9

Update config.go

protolambda added a commit to protolambda/go-ethereum that referenced this issue Sep 16, 2022

Merge pull request ethereum#6 from ethereum-optimism/no-deposit-reinject

99fad45

core: do not try to reinject deposit txs

protolambda added a commit to protolambda/go-ethereum that referenced this issue Jan 4, 2023

Merge pull request ethereum#6 from ethereum-optimism/no-deposit-reinject

7011ad0

core: do not try to reinject deposit txs

protolambda pushed a commit to protolambda/go-ethereum that referenced this issue Jan 4, 2023

Make the simulator more configurable (ethereum#6)

b07316f

XWJACK added a commit to XWJACK/go-ethereum that referenced this issue Jul 25, 2023

Merge pull request ethereum#6 from XWJACK/rpc-ext

a4fcff4

add rpc ext_

sbellem pushed a commit to sbellem/go-ethereum that referenced this issue Jul 25, 2023

Merge pull request ethereum#6 from zama-ai/petar/create2-protected-st…

2b6939d

…orage Create protected storage on the CREATE2 opcode

nikicat pushed a commit to nikicat/go-ethereum that referenced this issue Sep 11, 2023

Merge pull request ethereum#6 from 0rac1e/symbiosis/master

3c00391

check chainid on nil

allnil pushed a commit to allnil/go-ethereum that referenced this issue Feb 24, 2024

Merge pull request ethereum#6 from flashbots/release-action

7141a37

add image release workflow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TODO List #6

TODO List #6

obscuren commented Jan 25, 2014

suhr commented Mar 2, 2014

obscuren commented Mar 2, 2014

wijittrapha commented Dec 27, 2018

TODO List #6

TODO List #6

Comments

obscuren commented Jan 25, 2014

suhr commented Mar 2, 2014

obscuren commented Mar 2, 2014

wijittrapha commented Dec 27, 2018