miner: move agent logic to worker #17351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
remove_mining_agent
branch
6 times, most recently
from
5c01fa1
to
8ddee3f
Compare
rjl493456442
force-pushed
the
remove_mining_agent
branch
from
8ddee3f
to
dc9c87e
Compare
karalabe
reviewed
Aug 13, 2018
miner/worker.go
Outdated
| // worker is the main object which takes care of applying messages to the new state | ||
| type worker struct { | ||
| // Task contains all information for consensus engine sealing and result submitting. | ||
| type Task struct { |
miner/worker.go
Outdated
|
|
||
| // Worker is the main object which takes care of submitting new work to consensus engine | ||
| // and gathering the sealing result. | ||
| type Worker struct { |
There was a problem hiding this comment.
Similarly, does the worker need to be public?
miner/worker.go
Outdated
|
|
||
| block := result.block |
There was a problem hiding this comment.
Nitpick, please move this back above the empty line. It's easier on the eye that the first core-block is "initialization" and then an empty line, then comment and continuation.
miner/worker.go
Outdated
| // makeCurrent creates a new environment for the current cycle. | ||
| func (self *worker) makeCurrent(parent *types.Block, header *types.Header) error { | ||
| state, err := self.chain.StateAt(parent.Root()) | ||
| // makeCurrent creates an new environment for the current cycle. |
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* miner: move agent logic to worker * miner: polish * core: persist block before reorg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor miner package a bit and fix some issues.
This PR includes:
ChainEventonly when we insert a canonical block