Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current implementation does not support the OR-condition filter by RPC #18444

Closed
wants to merge 1 commit into from

Conversation

TanakaFairwayCorp
Copy link

{{A, B}, {C, D}} matches topic (A OR B) in first position, (C OR D) in second position

…hich is required by the RPC

{{A, B}, {C, D}}   matches topic (A OR B) in first position, (C OR D) in second position
@karalabe karalabe closed this Jan 16, 2019
@karalabe
Copy link
Member

Your code doesn't even compile. The filter on the other hand works.

@TanakaFairwayCorp TanakaFairwayCorp deleted the patch-3 branch January 17, 2019 01:54
@hackmod
Copy link
Contributor

hackmod commented Jan 28, 2019

I guess he was trying to report an issue.
(please see PR #18955)

as described at https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_newfilter

  • [null, B] "anything in first position AND B in second position (and anything after)"
  • [A, B] "A in first position AND B in second position (and anything after)"
  • [[A, B], [A, B]] "(A OR B) in first position AND (A OR B) in second position (and anything after)"

only AND cases supported.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants