les: prefer nil slices over zero-length slices #19081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4n6a1ka
added a commit
to t4n6a1ka/go-ethereum
that referenced
this pull request
Jul 1, 2019
/*/ # * eth: fix sync bloom panic (ethereum#19757). # * eth: fix sync bloom panic. # * eth: delete useless test cases. * mobile: fix mobile interface (ethereum#19180) * mobile: fix mobile interface * mobile, accounts: generate correct java binding * accounts: fix java type binding * mobile: support integer slice * accounts/abi/bind, cmd/abigen: implement java binding tests * les: prefer nil slices over zero-length slices (ethereum#19081) * all: on-chain oracle checkpoint syncing (ethereum#19543) * all: implement simple checkpoint syncing cmd, les, node: remove callback mechanism cmd, node: remove callback definition les: simplify the registrar les: expose checkpoint rpc services in the light client les, light: don't store untrusted receipt cmd, contracts, les: discard stale checkpoint cmd, contracts/registrar: loose restriction of registeration cmd, contracts: add replay-protection all: off-chain multi-signature contract params: deploy checkpoint contract for rinkeby cmd/registrar: add raw signing mode for registrar cmd/registrar, contracts/registrar, les: fixed messages * cmd/registrar, contracts/registrar: fix lints * accounts/abi/bind, les: address comments * cmd, contracts, les, light, params: minor checkpoint sync cleanups * cmd, eth, les, light: move checkpoint config to config file * cmd, eth, les, params: address comments * eth, les, params: address comments * cmd: polish up the checkpoint admin CLI * cmd, contracts, params: deploy new version contract * cmd/checkpoint-admin: add another flag for clef mode signing * cmd, contracts, les: rename and regen checkpoint oracle with abigen * accounts/abi: Fix method overwritten by same name methods. (ethereum#17099) * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: avoid possible name conflict Co-authored-by: Guillaume Ballet <gballet@gmail.com> * Delete COPYING * Create LICENSE /*/
t4n6a1ka
added a commit
to t4n6a1ka/go-ethereum
that referenced
this pull request
Sep 25, 2019
* eth: fix sync bloom panic (ethereum#19757) * eth: fix sync bloom panic * eth: delete useless test cases * mobile: fix mobile interface (ethereum#19180) * mobile: fix mobile interface * mobile, accounts: generate correct java binding * accounts: fix java type binding * mobile: support integer slice * accounts/abi/bind, cmd/abigen: implement java binding tests * les: prefer nil slices over zero-length slices (ethereum#19081) * all: on-chain oracle checkpoint syncing (ethereum#19543) * all: implement simple checkpoint syncing cmd, les, node: remove callback mechanism cmd, node: remove callback definition les: simplify the registrar les: expose checkpoint rpc services in the light client les, light: don't store untrusted receipt cmd, contracts, les: discard stale checkpoint cmd, contracts/registrar: loose restriction of registeration cmd, contracts: add replay-protection all: off-chain multi-signature contract params: deploy checkpoint contract for rinkeby cmd/registrar: add raw signing mode for registrar cmd/registrar, contracts/registrar, les: fixed messages * cmd/registrar, contracts/registrar: fix lints * accounts/abi/bind, les: address comments * cmd, contracts, les, light, params: minor checkpoint sync cleanups * cmd, eth, les, light: move checkpoint config to config file * cmd, eth, les, params: address comments * eth, les, params: address comments * cmd: polish up the checkpoint admin CLI * cmd, contracts, params: deploy new version contract * cmd/checkpoint-admin: add another flag for clef mode signing * cmd, contracts, les: rename and regen checkpoint oracle with abigen * accounts/abi: Fix method overwritten by same name methods. (ethereum#17099) * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: avoid possible name conflict Co-authored-by: Guillaume Ballet <gballet@gmail.com> * Delete COPYING * Create LICENSE * Master (#2) (#3) * Create .loc * Rename core/.go/.loc to core/go./loc.js * Delete loc.js * Create .JS * Delete .JS * Update main.yml * Create main.workflow * Update .travis.yml * Update .travis.yml * Delete .travis.yml
t4n6a1ka
added a commit
to t4n6a1ka/go-ethereum
that referenced
this pull request
Sep 29, 2019
* eth: fix sync bloom panic (ethereum#19757) * eth: fix sync bloom panic * eth: delete useless test cases * mobile: fix mobile interface (ethereum#19180) * mobile: fix mobile interface * mobile, accounts: generate correct java binding * accounts: fix java type binding * mobile: support integer slice * accounts/abi/bind, cmd/abigen: implement java binding tests * les: prefer nil slices over zero-length slices (ethereum#19081) * all: on-chain oracle checkpoint syncing (ethereum#19543) * all: implement simple checkpoint syncing cmd, les, node: remove callback mechanism cmd, node: remove callback definition les: simplify the registrar les: expose checkpoint rpc services in the light client les, light: don't store untrusted receipt cmd, contracts, les: discard stale checkpoint cmd, contracts/registrar: loose restriction of registeration cmd, contracts: add replay-protection all: off-chain multi-signature contract params: deploy checkpoint contract for rinkeby cmd/registrar: add raw signing mode for registrar cmd/registrar, contracts/registrar, les: fixed messages * cmd/registrar, contracts/registrar: fix lints * accounts/abi/bind, les: address comments * cmd, contracts, les, light, params: minor checkpoint sync cleanups * cmd, eth, les, light: move checkpoint config to config file * cmd, eth, les, params: address comments * eth, les, params: address comments * cmd: polish up the checkpoint admin CLI * cmd, contracts, params: deploy new version contract * cmd/checkpoint-admin: add another flag for clef mode signing * cmd, contracts, les: rename and regen checkpoint oracle with abigen * accounts/abi: Fix method overwritten by same name methods. (ethereum#17099) * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: avoid possible name conflict Co-authored-by: Guillaume Ballet <gballet@gmail.com> * Delete COPYING * Create LICENSE * Master (#2) (#3) * Create .loc * Rename core/.go/.loc to core/go./loc.js * Delete loc.js * Create .JS * Delete .JS * Update main.yml * Create main.workflow * Update .travis.yml * Update .travis.yml * Delete .travis.yml
t4n6a1ka
added a commit
to t4n6a1ka/go-ethereum
that referenced
this pull request
Oct 19, 2019
* eth: fix sync bloom panic (ethereum#19757) * eth: fix sync bloom panic * eth: delete useless test cases * mobile: fix mobile interface (ethereum#19180) * mobile: fix mobile interface * mobile, accounts: generate correct java binding * accounts: fix java type binding * mobile: support integer slice * accounts/abi/bind, cmd/abigen: implement java binding tests * les: prefer nil slices over zero-length slices (ethereum#19081) * all: on-chain oracle checkpoint syncing (ethereum#19543) * all: implement simple checkpoint syncing cmd, les, node: remove callback mechanism cmd, node: remove callback definition les: simplify the registrar les: expose checkpoint rpc services in the light client les, light: don't store untrusted receipt cmd, contracts, les: discard stale checkpoint cmd, contracts/registrar: loose restriction of registeration cmd, contracts: add replay-protection all: off-chain multi-signature contract params: deploy checkpoint contract for rinkeby cmd/registrar: add raw signing mode for registrar cmd/registrar, contracts/registrar, les: fixed messages * cmd/registrar, contracts/registrar: fix lints * accounts/abi/bind, les: address comments * cmd, contracts, les, light, params: minor checkpoint sync cleanups * cmd, eth, les, light: move checkpoint config to config file * cmd, eth, les, params: address comments * eth, les, params: address comments * cmd: polish up the checkpoint admin CLI * cmd, contracts, params: deploy new version contract * cmd/checkpoint-admin: add another flag for clef mode signing * cmd, contracts, les: rename and regen checkpoint oracle with abigen * accounts/abi: Fix method overwritten by same name methods. (ethereum#17099) * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: Fix method overwritten by same name methods. * accounts/abi: avoid possible name conflict Co-authored-by: Guillaume Ballet <gballet@gmail.com> * Delete COPYING * Create LICENSE * Master (#2) (#3) * Create .loc * Rename core/.go/.loc to core/go./loc.js * Delete loc.js * Create .JS * Delete .JS * Update main.yml * Create main.workflow * Update .travis.yml * Update .travis.yml * Delete .travis.yml * Delete SECURITY.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang best practice is to use a nil slice variable declaration instead of instantiating a zero-length slice [1].
[1] https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices