travis: extend race detection for swarm p2p packages #19287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2019 12:02
By removing -v our output will be cleaner, but the Travis job still won't be terminated - due to 'no output for 10 minutes' - as keepalive .sh produces a log line every 5 minutes.
As p2p/protocols, p2p/simulations and p2p/testing packages mostly belong to the Swarm team.
acud
approved these changes
Mar 20, 2019
zelig
approved these changes
Mar 21, 2019
kiku-jw
pushed a commit
to kiku-jw/go-ethereum
that referenced
this pull request
Mar 29, 2019
* travis: remove verbose from Swarm race tests By removing -v our output will be cleaner, but the Travis job still won't be terminated - due to 'no output for 10 minutes' - as keepalive .sh produces a log line every 5 minutes. * travis: extend Swarm race detection to p2p subpackages As p2p/protocols, p2p/simulations and p2p/testing packages mostly belong to the Swarm team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As p2p/protocols, p2p/simulations and p2p/testing packages mostly
belong to the Swarm team. We want to keep our code race free.
This PR makes sure we run Go's builtin race detector towards our code.
fixes ethersphere/swarm#1249