swarm/storage: fix SubscribePull to not skip chunks #19599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
fix-from-1
branch
3 times, most recently
from
63b46fa
to
3cc9354
Compare
nonsense
changed the title
|
@justelad I believe this is fixing the bug that was incorrectly solved with Now we don't have endless stream of Offered/Wanted messages, and we also don't have missing chunks in syncing. This PR however does not address the complete lack of proper testing of |
acud
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing a bug in SubscribePull where on occasion it would skip the chunk pointed to by the
sincecursor.SubscribePull has always been accepting a closed interval with respect to its arguments
sinceanduntil- the godoc has been amended.endless stream of OfferedHashesMsg ethersphere/swarm#1375 is fixed as a result.
The bug this PR is addressing is that if on first iteration, the iterator within
SubscribePullreturns chunks - then the behaviour ofSubscribePullis correct.However if on first iteration, the iterator returns no chunks, and the
sincechunk is stored after the subscription is established, then it the chunk pointed at bysinceis not returned by the iterator, becausefirstis set tofalse, and the item is skipped.