les: reject client connection if it makes too much invalid req #19691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
rjl493456442
force-pushed
the
client-simple-reputation
branch
from
d59ed65
to
e8fd364
Compare
holiman
approved these changes
Jun 10, 2019
|
Please rebase onto master. |
rjl493456442
force-pushed
the
client-simple-reputation
branch
from
e8fd364
to
3fd7804
Compare
|
@karalabe Updated. |
karalabe
reviewed
Jun 12, 2019
karalabe
reviewed
Jun 12, 2019
karalabe
requested changes
Jun 12, 2019
holiman
reviewed
Jun 12, 2019
les/handler.go
Outdated
| @@ -853,6 +866,7 @@ func (pm *ProtocolManager) handleMsg(p *peer) error { | |||
|
|
|||
| if number = rawdb.ReadHeaderNumber(pm.chainDb, request.BHash); number == nil { | |||
| p.Log().Warn("Failed to retrieve block num for proof", "hash", request.BHash) | |||
| atomic.AddUint64(&p.invalidReq, 1) | |||
There was a problem hiding this comment.
If the request contain N internal requests for the same missing hash, then this path won't trigger. Might be better to base it off #19701 , and add the counter here: https://github.com/ethereum/go-ethereum/pull/19701/files#diff-d1e187d1b095dcfc1cc773abfd8c4066R873
holiman
reviewed
Jun 12, 2019
| @@ -853,6 +866,7 @@ func (pm *ProtocolManager) handleMsg(p *peer) error { | |||
|
|
|||
| if number = rawdb.ReadHeaderNumber(pm.chainDb, request.BHash); number == nil { | |||
| p.Log().Warn("Failed to retrieve block num for proof", "hash", request.BHash) | |||
| atomic.AddUint32(&p.invalidCount, 1) | |||
There was a problem hiding this comment.
If the request contain N internal requests for the same missing hash, then this path won't trigger. Might be better to base it off #19701 , and add the counter here: https://github.com/ethereum/go-ethereum/pull/19701/files#diff-d1e187d1b095dcfc1cc773abfd8c4066R873
rjl493456442
force-pushed
the
client-simple-reputation
branch
from
b322e53
to
2b349f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #19689.
This PR introduces a very simple reputation system on the server side. If a client sends too much invalid request(e.g. request some non-exist data), it will be kicked out.
The rationale here is: A client should send the requests to servers which can serve the requests.
The server will push the new head announcements steadily. This information is totally enough for clients to manage their requests.