whisper: PoW calculations as specified in EIP-627 #19753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
changed the title
kdeme
reviewed
Jun 25, 2019
There was a problem hiding this comment.
The hashing / leadingZeros calculation looks good now.
However, I noticed (I could/should have spotted this already in #19330) that the size taken at the end is the size of rlpWithoutNonce while the EIP specifies: where size is the size of the full RLP-encoded envelope.
I do acknowledge that this is somewhat an annoying requirement in the specification as it makes the reverse calculation when mining to a specific PoW target a bit more complicated (e.g. need to recalculate size each time if you want your PoW target 100% exact).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @kdeme in #18070 the calculation of the nonce is not what is specified in EIP-627 and that adds to the list of incompatibilities with Parity's version.