Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade golangci to 1.22.2 #20566

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 15, 2020

The arm64 linter build seems to be broken, and indeed the arm64 version of golangci is not available for this platform. This PR upgrades the ci build to match the latest version, that has support for arm64.

@gballet gballet requested a review from fjl January 15, 2020 16:02
@gballet gballet force-pushed the build-ci-upgrade-golangci-1.22.2 branch 2 times, most recently from d1ffb13 to 9b0b5ef Compare January 15, 2020 18:23
@fjl
Copy link
Contributor

fjl commented Jan 16, 2020

Please add an exclude for misspell in core/genesis_alloc.go

@gballet
Copy link
Member Author

gballet commented Jan 16, 2020

@fjl misspell has no effect 😠 This is because the warning doesn't come from misspell itself but from the fact that misspell fails because the line is too long.

@gballet gballet force-pushed the build-ci-upgrade-golangci-1.22.2 branch from 9b0b5ef to a348312 Compare January 16, 2020 11:16
@karalabe karalabe added this to the 1.9.10 milestone Jan 16, 2020
@karalabe karalabe merged commit 1ee754b into ethereum:master Jan 16, 2020
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
* build: upgrade golangci to 1.22.2

* .golangci.yml: don't fail on asset deadcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants