tracers: avoid panic on invalid arguments #20612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintinweb
requested review from
holiman,
karalabe and
rjl493456442
as code owners
tintinweb
changed the title
debug_traceTransaction regression tests for panics files as #20611debug_traceTransaction regression tests for panics see issue #20611
|
Thanks for this @tintinweb ! |
holiman
changed the title
debug_traceTransaction regression tests for panics see issue #20611
|
I pushed fixes on top! |
holiman
approved these changes
Feb 3, 2020
holiman
force-pushed
the
tin/regression/debug_traceTransaction
branch
from
8440690
to
cc6e5ce
Compare
holiman
force-pushed
the
tin/regression/debug_traceTransaction
branch
from
cc6e5ce
to
5455869
Compare
karalabe
reviewed
Feb 3, 2020
holiman
force-pushed
the
tin/regression/debug_traceTransaction
branch
from
5455869
to
ee9ef1f
Compare
9 tasks
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* add regression tests for ethereum#20611 * eth/tracers: fix panics occurring for invalid params in js-tracers Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds regression tests for the panics outlined in #20611.
This PR is not providing a fix for #20611.
cheers,
tin