core: use errors.Is for consensus errors check #21095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
holiman,
karalabe and
rjl493456442
as code owners
|
We'll merge this after the builders are updated to drop Go 1.12. Martin has a PR. |
|
I rebased this on |
|
Thanks for merging. |
This was referenced Feb 24, 2021
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often it's useful to wrap errors to provide more contextual information about errors. Go
errorsstandard library have few convenient functions to inspect wrapped errors: errors.Is and errors.As.consensuspackage defines few constant errors (egconsensus.ErrUnknownAncestor), which don't carry much information.In a fork I'm developing, I'm wrapping errors from
consensuspackage, but this breaks some of thecorefunctionality, as it is using static checks, which is not very scaleable (functional wise). For start I would like to port some of this changes here and maybe in the future we can wrap errors.