Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/testdata: make submodule shallow #23412

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

ligi
Copy link
Member

@ligi ligi commented Aug 18, 2021

As @MariusVanDerWijden mentioned the tests submodule is quite heavy added the shallow setting for it - does not help that much as most weight is in the actual data - not the history - but it helps a bit - hence the PR.
Before:

316M .git/modules/tests/

After:

171M .git/modules/tests/

so 145M saved - not much - but also not nothing.

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl changed the title Make tests submodule shallow tests/testdata: make submodule shallow Aug 24, 2021
@fjl fjl merged commit 5c66bab into ethereum:master Aug 24, 2021
@fjl fjl added this to the 1.10.9 milestone Aug 24, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 24, 2021
Before:

316M .git/modules/tests/

After:

171M .git/modules/tests/
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Before:

316M .git/modules/tests/

After:

171M .git/modules/tests/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants