Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity check in insert #19

Closed
wants to merge 1 commit into from
Closed

sanity check in insert #19

wants to merge 1 commit into from

Conversation

gballet
Copy link
Member

@gballet gballet commented Apr 13, 2021

No description provided.

Copy link
Collaborator

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. leaf.Insert is being called by leaf.InsertOrdered, but I couldn't find where leaf.InsertOrdered itself is being called to this code might be right now unused.

@gballet
Copy link
Member Author

gballet commented Apr 15, 2021

yeah, it shouldn't be called. Might as well panic in any case. This is just here in case we switch to an iterative approach, and the code will be incorrect in that case anyway. I'll mull it over.

The code is currently unused, but that's because we haven't tried updating values. This function (or maybe one very similar called Update) should indeed update the code.

@gballet
Copy link
Member Author

gballet commented Apr 15, 2021

Closing, this is mixing Insert and Update.

@gballet gballet closed this Apr 15, 2021
@gballet gballet mentioned this pull request Apr 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants