This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
feat: ignoreIfEmpty flag setting #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertonfraga
suggested changes
Nov 11, 2019
There was a problem hiding this comment.
Looks good!
please add test cases to this new feature: https://github.com/ethereum/grid-ui/blob/dev/src/test/settings.test.js
| this.setState({ setupState: `Downloading ${downloadProgress}%` }) | ||
| } else { | ||
| this.setState({ setupState: null }) | ||
| } |
Thanks for the reminder 👍 Here they are: |
|
That's great, thanks. Because of this |
wolovim
approved these changes
Nov 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do? Does it close any issues?
Introduces property
ignoreIfEmptyto flag settings.See ethereum/grid#518
Closes one of the issues in ethereum/grid#512
Pairs with ethereum/grid#518