This repository has been archived by the owner on Feb 12, 2021. It is now read-only.
feat: ignore flag if empty #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do? Does it close any issues?
Removes trying to define default data directory and keystore directory across platforms, and instead introduces property
ignoreIfEmptyto flag settings.Closes one of the issues in #512
Pairs with ethereum/grid-ui#159
To test, run this branch with the paired grid-ui branch and see what your values in Settings are for Geth for
Data DirectoryandKeystore Directory. Clear them empty, and see if the generated flags hide --datadir and/or --keystoredir