Fix trusted setup outputs by using correct transcript.json #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#2 used an incorrect version of the
transcript.json
resulting in incorrectoutput_setups
.Solution
Re-run with the final transcript sha256:
8ed1c73857e77ae98ea23e36cdcf828ccbf32b423fddc7480de6
Detailed explanation
Due to me working too quickly, and not verifying which transcript I used to create the files in #2, I ended up using the incorrect version of the transcript which resulted the
output_setups
being entirely incorrect. This happened due to me using a random copy of thetranscript.json
I had lying around, instead of re-downloading it, and then I did not verify the file was actually correct.The updated
output_setups
in this PR are from transcript sha256 hash8ed1c73857e77ae98ea23e36cdcf828ccbf32b423fddc7480de658f9d116c848
which yields the sameg1_lagrange
andg2_monomial
outputs as before #2.Attribution
Huge thank you to @zilm13 for finding this! 🙏🙏
This was a stupid mistake on my part and this is a great example of why open source is so important. Trust, but verify!