This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Fix node download logic #1048
Merged
Fix node download logic #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| toDownload.push({ |
hiccups during the unzip stage. |
|
Fixed unzipping. |
|
Sweet, works for me. Let's wait for travis to ACK. |
|
|
||
| return merge.apply(null, streams); | ||
| if (0 <= osArch.indexOf('linux')) { | ||
| ret = shell.exec(`tar -xzf ./nodes/geth/${zipFileName} -C ./nodes/geth/${osArch}`); |
There was a problem hiding this comment.
tar -xf suffices as it is not gunzipped. This should fix travis. (http://stackoverflow.com/a/15744167)
Though I wonder about this behaviour
There was a problem hiding this comment.
@luclu should be fixed
|
Works great for me on with all --platform combinations. |
This was referenced Aug 3, 2016
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up and fixes the node download logic, fixing the Linux x64 geth node problem too.