Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

remove postinstall hook from package.json #987

Closed
5chdn opened this issue Jul 18, 2016 · 4 comments · Fixed by #988
Closed

remove postinstall hook from package.json #987

5chdn opened this issue Jul 18, 2016 · 4 comments · Fixed by #988

Comments

@5chdn
Copy link

5chdn commented Jul 18, 2016

The package.json contains the following:

"scripts": {
  "ci": "gulp --platform=linux",
  "postinstall": "gulp update-nodes"
},

Which causes each npm install to trigger a gulp update-nodes after the installation. Took me a while to figure out where that came from.

In the docs you describe the installation as follows:

Installation

Now you're ready to install Mist:

$ git clone https://github.com/ethereum/mist.git
$ cd mist
$ git submodule update --init
$ npm install
$ gulp update-nodes

Which describes the intentions of npm install and gulp update-notes to be separated commands. As for now it is not possible to install mist without triggering a full download of all nodes for all operating systems (this is yet another issue).

[14:03:42] Starting 'clean:nodes'...
[14:03:42] Finished 'clean:nodes' after 10 ms
[14:03:42] Starting 'downloadNodes'...
[14:03:42] Downloading https://github.com/ethereum/go-ethereum/releases/download/v1.4.10/geth-OSX-20160716155225-1.4.10-5f55d95.zip...
[14:03:42] Downloading https://github.com/ethereum/go-ethereum/releases/download/v1.4.10/geth-Linux64-20160716160600-1.4.10-5f55d95.tar.bz2...
[14:03:42] Downloading https://github.com/ethereum/go-ethereum/releases/download/v1.4.10/Geth-Win64-20160716155900-1.4.10-5f55d95.zip...
[14:03:42] Downloading https://bintray.com/karalabe/ethereum/download_file?file_path=geth-1.4.10-stable-5f55d95-linux-386.tar.bz2...
[14:03:42] Downloading https://bintray.com/karalabe/ethereum/download_file?file_path=geth-1.4.10-stable-5f55d95-windows-4.0-386.exe.zip...
^C

Please remove the postinstall hook from package.json or provide a convenient way of disabling the update-nodes command. Also I would strongly recommend to only download the target OS version of the node.

@hiddentao
Copy link
Contributor

PR is #988, thanks @luclu

@5chdn
Copy link
Author

5chdn commented Jul 26, 2016

Jeez, what a mess, now I run into the following.

 ERROR: YOUR NODES NEED TO BE UPDATED run $ gulp update-nodes

I do not want to use the mist nodes but the system wide nodes. Please, help a desperate package maintainer :-)

I totally understand your motivation, you want it straight forward easy and simple for the end user. But for those who know their tools, please allow alternative paths! Thanks :-)

Related: #264

@luclu
Copy link
Contributor

luclu commented Aug 3, 2016

Try now, this PR should solve your problem:

Fix node download logic #1048

@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants