This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
[refactor] Download signature optimized #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evertonfraga, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexvandesande, @luclu and @hiddentao to be potential reviewers. |
evertonfraga
force-pushed
the
download_signature_optimized
branch
from
5be7b3f
to
e798200
Compare
alexvandesande
approved these changes
Nov 11, 2016
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted code from PR #1155, so it gets merged faster. This refactor was made by @hiddentao in order to run much faster than before, as it uses a single request with a 20,000 entries limit.
The
download-signaturestask is now integrated into the build process. It's a requirement forbuild-dist.