Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

[ESLint] add meteor specific style guide #1416

Merged
merged 4 commits into from
Nov 14, 2016

Conversation

luclu
Copy link
Contributor

@luclu luclu commented Nov 14, 2016

Unfortunately ESLint is unable to relate to meteor's scopes, thus variables are recognized as undefined. There are two ways around this:

  1. disable the no-undef rule for the interface directory
  2. add any defined variables in a config-comment line in each file specifically
  3. leverage meteor lint command (more complicated setup)

This PR currently opted for (1).

There is also a nice meteor-plugin for ESLint https://github.com/dferber90/eslint-plugin-meteor,
unfortunately it is not yet supported by code-climate and will error out.

@mention-bot
Copy link

@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @frozeman, @hiddentao and @alexvandesande to be potential reviewers.

@luclu luclu force-pushed the luclu_eslint-interface-config branch from 215d94c to f8df93b Compare November 14, 2016 17:43
Copy link
Member

@evertonfraga evertonfraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

@evertonfraga evertonfraga merged commit f44f179 into develop Nov 14, 2016
@evertonfraga evertonfraga deleted the luclu_eslint-interface-config branch November 14, 2016 20:03
@evertonfraga evertonfraga modified the milestone: 0.8.8 Nov 16, 2016
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants