Eth 01 cure

[frozeman]

Fixes:

• ETH-01-007
• ETH-01-008
• ETH-01-009
• ETH-01-012
• ETH-01-014

Preventing link click-redirects from within tabs is currently not possible due to a pending issue in electron: electron/electron#8008

One issue: If a web content is selected (clicked in a webview), then file dropping doesn't work anymore.
TODO: We can think about re-activating it or blocking it completely.

• ETH-01-014 needs to be retested on a windows system! @evertonfraga @luclu ?

for ETH 008 and 002 see:

[alexvandesande]

This does not solve # 22 yet. I am testing and still can see it.

[frozeman]

This PR is also solving the flickering of icons issue, which was cause by using {{> elements_img }} which fades images in when loaded. As the tabs where changed often and meteor seemed to "reload" the templates all the time, this lead to the flickering.

[frozeman]

@alexvandesande The last PR also removed the behaviour where when you clicked in the browser bar, it selected the whole text.
This made it impossible to select parts of the URL.
If we want to have the one click connivence we have to come up with a way which doesn't block selecting text.

[frozeman]

Can everybody please test now all issues again? :)
I deactivated the mist:// protocol for now, as it was never actually meant to be used yet

[luclu]

This regex might be a better fit:
/^(?:file|javascript|data):/

instead of:
/^((?:file)?(?:javascript)?(?:data)?:)/

Perhaps we should even add the \/\/ to the end (more for completeness sake and uniformity to the other sanitizer regex).

[luclu]

This looks malformed:
/^[:\/\/]{1,3}/

I think you rather want "add http if empty scheme string"?
/^:\/\//

[alexvandesande]

Finally getting rid of this horrible variable name! 😜

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.