Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

[editorconfig] change json indent from 2 to 4 spaces #1444

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

luclu
Copy link
Contributor

@luclu luclu commented Nov 21, 2016

No description provided.

@mention-bot
Copy link

@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hiddentao to be a potential reviewer.

@frozeman
Copy link
Contributor

But you are changing it here from 4 to 2, as far as i see.

@evertonfraga
Copy link
Member

@frozeman json's default is 4 spaces. luclu removed the override that changed it to 2 only.

@frozeman
Copy link
Contributor

Lets discuss this in gitter.

@frozeman frozeman merged commit cc4722a into develop Nov 21, 2016
@evertonfraga evertonfraga deleted the luclu_editorconfig-json-indent branch November 21, 2016 18:03
@evertonfraga evertonfraga modified the milestone: 0.8.8 Dec 5, 2016
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants