Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

detect ropstein testnet #1463

Merged
merged 19 commits into from
Nov 29, 2016
Merged

detect ropstein testnet #1463

merged 19 commits into from
Nov 29, 2016

Conversation

alexvandesande
Copy link
Collaborator

This adds the automatic detection of the Ropstein as “testnet” and not “privatenet”

@mention-bot
Copy link

@alexvandesande, thanks for your PR! By analyzing the history of the files in this pull request, we identified @frozeman, @hiddentao and @evertonfraga to be potential reviewers.

Copy link
Contributor

@luclu luclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frozeman
Copy link
Contributor

Dont merge yet, as discussed with @alexvandesande he wants to make it more modular and display the name of the network in the title="" tag of the red button.

@alexvandesande
Copy link
Collaborator Author

@frozeman I updated the code. Couldn't think of a way to include web3.eth.getBlock(0,) into the helper functions..

@frozeman
Copy link
Contributor

@alexvandesande where are you setting the name of the network to the title tag?
You can also pass the object to the TemplateVar.set()and then use it in the template as network.type or whatever its named.

Copy link
Contributor

@luclu luclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@frozeman frozeman merged commit 056d3df into develop Nov 29, 2016
@evertonfraga evertonfraga modified the milestone: 0.8.8 Dec 5, 2016
@frozeman frozeman deleted the add-ropstein-support branch December 6, 2016 15:05
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants