This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
ETH-02-cure-fixes #2 #1477
Merged
ETH-02-cure-fixes #2 #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frozeman
commented
Nov 29, 2016
frozeman
commented
- ETH-02-001
- ETH-02-002
- ETH-02-003
- ETH-02-004
|
@frozeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @evertonfraga and @alexvandesande to be potential reviewers. |
evertonfraga
suggested changes
Nov 29, 2016
| @@ -114,7 +114,7 @@ Helpers.generateBreadcrumb = function (url) { | |||
| return el === ''; | |||
| }); | |||
|
|
|||
| return new Spacebars.SafeString(_.flatten(['<span>' + filteredUrl.host + ' </span>', pathname]).join(' ▸ ')); | |||
| return new Spacebars.SafeString(url.protocol +'//'+ _.flatten(['<span>' + filteredUrl.host + ' </span>', pathname]).join(' ▸ ')); | |||
There was a problem hiding this comment.
@frozeman here I'd recommend using the Blaze._escape the same way we're using on host and pathname.
There was a problem hiding this comment.
Will do, but as far as i understand whats put into the protocol is already stripped out. if invalid, it would be returned empty by webkit.
But we can certainly do it to increase security
evertonfraga
approved these changes
Nov 29, 2016
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.