Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts within dev requirements installation. #1484

Closed
pipermerriam opened this issue Nov 20, 2018 · 9 comments
Closed

Conflicts within dev requirements installation. #1484

pipermerriam opened this issue Nov 20, 2018 · 9 comments

Comments

@pipermerriam
Copy link
Member

What is wrong?

A pip install -e .[dev] from the current master (https://github.com/ethereum/py-evm/tree/6fca8f723244c2e7f920a6aa18689ae61e257d03) results in the following errors:

eth-abi 1.2.2 has requirement eth-typing<2, but you'll have eth-typing 2.0.0 which is incompatible.
pytest 3.6.4 has requirement pluggy<0.8,>=0.5, but you'll have pluggy 0.8.0 which is incompatible.

How can it be fixed

  • The pytest/pluggy conflict comes from tox
  • The eth-abi/typing conflict comes from web3.py

We should be able to fix the pytest/pluggy/tox issue by futzing until we find a compatable pair of pytest/tox versions. Note that both have had major version bumps so we should work to upgrade them.

We should be able to fix the eth-abi one by making a 1.x release of eth-abi that supports eth-typing>=2 as well as a web3.py release that allows for this if needed.

@pipermerriam pipermerriam changed the title Issue with requirements Conflicts within dev requirements installation. Nov 20, 2018
@javimaravillas
Copy link

javimaravillas commented Dec 1, 2018

Fix for: The pytest/pluggy conflict comes from tox
#1538

Pytest build is not running successfulll after that, I will post in a different issue (tested with all the possibles pluggy versions to avoid that the pluggy version I have added is introducing the issue and it is not looking to)

@javimaravillas
Copy link

I will continue with this issue to fix:

eth-abi 1.2.2 has requirement eth-typing<2, but you'll have eth-typing 2.0.0 which is incompatible.

@rayrapetyan
Copy link
Contributor

@javimaravillas, could you also upgrade coincurve to v10 as part of this task? Outdated v8 produces some issues on certain OSes (FreeBSD).
Basically replace:

coincurve>=8.0.0,<9.0.0

with

coincurve>=10.0.0,<11.0.0

in two places. I don't think it worth a separate PR. Thanks.

@javimaravillas
Copy link

javimaravillas commented Dec 1, 2018

Done

I'm setting the PR to WIP until I'm able to fix

eth-abi 1.2.2 has requirement eth-typing<2, but you'll have eth-typing 2.0.0 which is incompatible.

@javimaravillas
Copy link

Waiting for ethereum/eth-abi#110 to be merged and a new version released from eth-abi 1.x for updating the PR and fixing this issue.

@javimaravillas
Copy link

The previous two error has been fixed, but another error has come:

requests 2.20.1 has requirement idna<2.8,>=2.5, but you'll have idna 2.8 which is incompatible.

Fixing idna to 2.7 is making this error to disappear.

@javimaravillas
Copy link

This issue is fixed now in: #1538

@javimaravillas
Copy link

This one could be closed now

@carver
Copy link
Contributor

carver commented Dec 11, 2018

Thanks @javimaravillas !

@carver carver closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants