eth-abi 1.2.2 has requirement eth-typing<2, but you'll have eth-typing 2.0.0 which is incompatible.but you'll ha… #1538
Conversation
…ve pluggy 0.8.0 which is incompatible.
javimaravillas
changed the title
| @@ -40,7 +40,7 @@ | |||
| "async-generator==1.10", | |||
| "bloom-filter==1.3", | |||
| "cachetools>=2.1.0,<3.0.0", | |||
| "coincurve>=8.0.0,<9.0.0", | |||
| "coincurve>=10.0.0,<11.0.0", | |||
There was a problem hiding this comment.
@javimaravillas what's the reason for bumping these?
There was a problem hiding this comment.
Ah, ok I just read it was suggested here as lower versions have issues with FreeBSD. Sounds fair.
| @@ -83,6 +83,7 @@ | |||
| "bumpversion>=0.5.3,<1", | |||
| "wheel", | |||
| "setuptools>=36.2.0", | |||
| "pluggy==0.7.1", | |||
There was a problem hiding this comment.
I think if we add this as a standalone dependency to workaround the issue, we should put a comment above that line as an explainer. Something like:
Pinning pluggy version to workaround incompatibility issues between certain
pytestandtoxversions.
|
This PR is waiting for ethereum/eth-abi#110 |
javimaravillas
changed the title
javimaravillas
changed the title
…dna 2.8 which is incompatible.
|
This PR is complete to review and merge |
| #Fixing this dependency due to: pytest 3.6.4 has requirement pluggy<0.8,>=0.5, but you'll have pluggy 0.8.0 which is incompatible. | ||
| "pluggy==0.7.1", | ||
| #Fixing this dependency due to: requests 2.20.1 has requirement idna<2.8,>=2.5, but you'll have idna 2.8 which is incompatible. | ||
| "idna==2.7", |
There was a problem hiding this comment.
Just as an FYI, I think it would be ideal to do >=2.5,<2.8 here, but since it's only a dev dependency, I'm okay pinning it.
#1484
What was wrong?
How was it fixed?
tox was installing the latest version of pluggy 0.8 that is incompatible with pytest so pytest was not working. Fixing a version of pluggy minor to 0.8 makes pytest work without an issue for tox
Releasing a new version of eth-abi using eth-typing 2.0.0 (waiting for a PR in eth-abi to be ready)
Fixing idna to use 2.7 is fixing the issue
Cute Animal Picture