updating to eth-typing to 2.0.0 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesque
suggested changes
Dec 3, 2018
setup.py
Outdated
| @@ -18,7 +18,7 @@ | |||
| include_package_data=True, | |||
| install_requires=[ | |||
| 'eth-utils>=1.2.0,<2.0.0', | |||
| 'eth-typing<2', | |||
| 'eth-typing==2.0.0', | |||
There was a problem hiding this comment.
We typically use version ranges for install requirements. That makes it so that things are less likely to break when several packages are installed at once that all require eth-typing.
Suggested change
| 'eth-typing==2.0.0', | |
| 'eth-typing>=2.0.0,<3.0.0', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-typing was fixed to the minor version of 2.0.0. Due to ethereum/py-evm#1484, we need a new version with that dependency updated.
How was it fixed?
Updating the dependency was enough. Test are passing. Didn't find any breaking change from 1.3 to 2.0.0, neither in code or documentation.