-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Hashing Function from Blake2b to Sha3 #1564
Comments
The spec says keccak is used now and might switch to another hash function in the future. This means that we are replacing all hash in the codebase now and will do the same in the future. # eth/utils/hash_function.py
from eth_typing import Hash32
from eth_hash.auto import keccak
def hash_(data: bytes) -> Hash32:
return Hash32(keccak(data)) and in the rest of the codebase just do from eth.utils.hash_function import hash_
hash_(something) so the future switch of hash function would become just a one-liner fix in |
Should this be based in
|
Ahhhh ... sorry @jannikluhn, I missed your comment. I would recommend I agree the point that |
IMO
But it's not only for beacon chain! Maybe |
What is wrong?
Per ethereum/consensus-specs#227
How can it be fixed
eth/utils/blake.py
and related tests.The text was updated successfully, but these errors were encountered: