Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort #2094

Closed
pacrob opened this issue Mar 7, 2023 · 3 comments
Closed

Add isort #2094

pacrob opened this issue Mar 7, 2023 · 3 comments

Comments

@pacrob
Copy link
Collaborator

pacrob commented Mar 7, 2023

What is wrong?

Imports are not sorted.

How can it be fixed

Add isort to the linting process.
@ketan3108
Copy link

ketan3108 commented Mar 17, 2023 •
edited

Hi @pacrob , I would like to contribute in this issue . Can you please elaborate in which all files it needs to be implemented ?
And could you please provide reference .

@pacrob
Copy link
Collaborator Author

pacrob commented Mar 20, 2023

isort is part of our linting process, so would apply to most of the files in the repo. You can read more about it here. For implementation, you can use web3.py as an example.

This was referenced Apr 19, 2023
Closed
Merged
Merged
Closed
@pacrob
Copy link
Collaborator Author

pacrob commented May 5, 2023

Closed by #2099

@pacrob pacrob closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pacrob @ketan3108