[3/3] Add isort check to tox #2103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-tox
branch
2 times, most recently
from
be0307f
to
a8d06b0
Compare
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-tox
branch
from
a8d06b0
to
0ab955e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Final PR which will add
isortcheck totox.Related to Issue #2094
How was it fixed?
Add command to
tox.iniwhich runsisort --check-only. This will cause CI failure if isort produces a different output than expected.flowchart LR pr1[Added isort to setup, makefile and tox] --> pr2[Linted file with isort in eth and tests directory] pr2 --> pr3[Add isort check to tox - This PR]Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture