Added isort for reorganizing imports #2098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort
branch
8 times, most recently
from
a3978e6
to
b623df0
Compare
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort
branch
from
b623df0
to
527d1e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Imports are not sorted.
Related to Issue #2094
How was it fixed?
Added
isort, a tool to sort imports, in the linting process.Adding lint setup + linting files would be a large PR to review. I've decided to split it up into two parts.
This is first PR.
In this PR, I've added
isortand related commands tosetup.py,Makefileandtox.In the follow up PR, I will be running
make lint-roll. It will be easier for repo maintainers to checksum the changes and review the lint changes.Let me know if I missed anything in the contribution process.
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture