Use some general state tests as transaction tests; Ensure txn type_id
#2157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
SpoofTransaction
is usually used to turn an unsigned transaction into a "signed" transaction for estimating gas for example. eth-tester usesSpoofTransaction
for these purposes and we need to make sure that it also accounts for atype_id
which is a part of theSignedTransactionAPI
.How was it fixed?
type_id
values toSpoofTransaction
since it should use all attributes from theSignedTransactionAPI
.Todo:
Cute Animal Picture
prompt:
iterate on 'snakes transitioning from the Shanghai city life to a life in Cancun with a sign that says "Cancun"' but make 'transactions' a theme