JournalDB.latest_id speedup #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A mainnet test previously showed this method took 7.0% of the total import_block() time. After this change it was 0.6% of the total. Tested against blocks: (7620447, 7620450, 7620453, 7620454)
carver
added a commit
that referenced
this pull request
May 3, 2019
carver
added a commit
that referenced
this pull request
May 20, 2019
* Add release notes for PR #1716 * Add release notes for PR #1751 * Add release notes for PR #1747 * Release notes for #1735 * Add release notes for #1765 and #1766 * Add release notes for #1764 Also add notes on performance gains * Add release notes for #1770 #1771 #1772 * Add release notes for #1776 * Add release notes for #1773 * Add release notes for #1777 * Add release notes for #1778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mainnet test previously showed this method took 7.0% of the total
import_block() time. After this change it was 0.6% of the total.
Tested against blocks: (7620447, 7620450, 7620453, 7620454)
How was it fixed?
OrderedDict docs say that
__reversed__is natively supported, so I took a shot atfirst(reversed(...keys()))and that gave a significant speedup.Cute Animal Picture