Bugfix: don't crash on re-org of header-only chain #1810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When a chain reorg's, it tries to remove the canonical transactions from the lookup db. If that chain is header-only, it crashes, because the canonical transactions were never inserted.
How was it fixed?
Catch and drop the exception if canonical transactions were missing. The point was to delete them, so if they are missing: mission accomplished.
To-Do
Cute Animal Picture