Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: don't crash on re-org of header-only chain #1810

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@carver
Copy link
Contributor

commented Aug 5, 2019

What was wrong?

When a chain reorg's, it tries to remove the canonical transactions from the lookup db. If that chain is header-only, it crashes, because the canonical transactions were never inserted.

How was it fixed?

Catch and drop the exception if canonical transactions were missing. The point was to delete them, so if they are missing: mission accomplished.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver carver requested a review from pipermerriam Aug 5, 2019

@carver carver merged commit d2ccc1e into ethereum:master Aug 5, 2019

17 of 20 checks passed

ci/circleci: py36-benchmark CircleCI is running your tests
Details
ci/circleci: py36-native-blockchain-constantinople CircleCI is running your tests
Details
ci/circleci: py36-native-blockchain-petersburg CircleCI is running your tests
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-database Your tests passed on CircleCI!
Details
ci/circleci: py36-docs Your tests passed on CircleCI!
Details
ci/circleci: py36-lint Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-byzantium Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-frontier Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-homestead Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-spurious_dragon Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-tangerine_whistle Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-transition Your tests passed on CircleCI!
Details
ci/circleci: py36-transactions Your tests passed on CircleCI!
Details
ci/circleci: py36-vm Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-database Your tests passed on CircleCI!
Details
ci/circleci: py37-lint Your tests passed on CircleCI!
Details
ci/circleci: py37-transactions Your tests passed on CircleCI!
Details
ci/circleci: py37-vm Your tests passed on CircleCI!
Details

@carver carver deleted the carver:reorg-with-missing-block-bodies branch Aug 5, 2019

@carver carver referenced this pull request Aug 8, 2019
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.