Upgrade py-trie to v2-alpha.3, and eth-utils to v1.9.4 #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically need to fix the typing-extensions conflict resolved here: ethereum/py-trie#117
Fixes this message:
File "/home/circleci/repo/.tox/py36-docs/lib/python3.6/site-packages/sphinxcontrib/asyncio.py", line 2, in <module>
from sphinx.domains.python import PyFunction, PyMethod
ImportError: cannot import name 'PyFunction'
carver
force-pushed
the
upgrade-py-trie
branch
from
86487ea
to
3c1dcec
Compare
This comment has been minimized.
This comment has been minimized.
carver
force-pushed
the
upgrade-py-trie
branch
from
0cd89b6
to
af9d35a
Compare
carver
changed the title
pipermerriam
approved these changes
Aug 28, 2020
cburgdorf
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Old py-trie version has typing-extensions conflict resolved here:
ethereum/py-trie#117
How was it fixed?
Upgrade it. Also fix unrelated eth-utils typing issues and sphinx incompatible upgrade issue.
To-Do
Cute Animal Picture