Support py310 & py311 #2088
Merged
Support py310 & py311 #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
support-py310
branch
from
3187c99
to
9c30594
Compare
fselmo
force-pushed
the
support-py310
branch
15 times, most recently
from
f961634
to
7bdfa9b
Compare
fselmo
force-pushed
the
support-py310
branch
5 times, most recently
from
ec0c61d
to
08e1d27
Compare
fselmo
force-pushed
the
support-py310
branch
5 times, most recently
from
71175cf
to
e1edece
Compare
- Add py310 runs to circleci config and tox - Use current master branch of ``pyethash`` as version to test broken tests - Update ``tox`` to ``>=4.0.0`` + related changes (e.g. ``whitelist_externals`` -> ``allowlist_externals``) - Remove ``python_paths`` from ``pytest`` config - Update ``pytest-timeout`` to ``>=2.0.0<3`` - Update ``blake2b-py`` - Update ``pytest-xdist``
fselmo
force-pushed
the
support-py310
branch
from
e1edece
to
2813486
Compare
- Can try to turn ``warn_unused_ignores`` back on after py39 support is dropped
It seems like binaries for some platforms are hard to come by for plyvel. It may no longer be maintained. We either subscribe to plyvel-ci or something similar or rip leveldb support out. I think at some point this may have served a more specific purpose anyhow for the Trinity client and perhaps there is little use for what seems like a decent amount of maintenance.
fselmo
force-pushed
the
support-py310
branch
from
b85f59c
to
9949363
Compare
Closed
fselmo
added a commit
to fselmo/py-evm
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
pyethashupdates for Python 3.10 led to segfaults. PoW, along with the Ethash algorithm, was de-prioritized in Remove dependence onethash(pyethash) #2121 which opened the way for a much cleaner version of this PR to add support to python 3.10 and 3.11.How was it fixed?
plyvelas that library is no longer maintained and lacked certain system binariesTodo:
Cute Animal Picture