Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize project structure #68

Closed
pipermerriam opened this issue Oct 17, 2018 · 10 comments
Closed

Modernize project structure #68

pipermerriam opened this issue Oct 17, 2018 · 10 comments

Comments

@pipermerriam
Copy link
Member

pipermerriam commented Oct 17, 2018

This project was made without the use of our standard project template.

https://github.com/carver/ethereum-python-project-template

The following should be cleaned up to closer match our modern project structure.

  • remove requirements-dev.txt in favor of using extras_require pattern.
  • add classifiers to setup.py
  • update the readme to contain the appropriate badgest, title and general structure.
  • update the tox.ini flake8 environment to use the more modern lint name as well as the same approach, installing from extras_require.
  • add python_requires (and exclude python==3.5.2)

Extra credit for finding other tangible differences and fixing them.

@gitcoinbot
Copy link

gitcoinbot commented Oct 17, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month, 3 weeks ago.
Please review their action plans below:

1) aashutoshrathi has been approved to start work.

I'll modernize the project structure by adding travis and tox and removing reqs file and adding pipenv.
I have done this in my own packages

Learn more on the Gitcoin Issue Details page.

@pipermerriam
Copy link
Member Author

@aashutoshrathi if you'll go ahead and get a pull request open I'll consider this reserved for you.

@6ug
Copy link
Contributor

6ug commented Oct 19, 2018

@aashutoshrathi, can you update status here so we have proper CI fixes running?

@pipermerriam, I like to wait till @aashutoshrathi adds PR, let me know if you want me to start working on this.

@pipermerriam
Copy link
Member Author

looks like @aashutoshrathi has a PR open #72

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

  1. @aashutoshrathi

@ceresstation please take a look at the submitted work:


@spm32
Copy link

spm32 commented Oct 21, 2018

@aashutoshrathi Once you make that last change I'll pay this out :) Thanks again!

@aashutoshrathi
Copy link
Contributor

Hi, @ceresstation Please take a look at #72
CircleCI throws weird errors on squashing.

@pipermerriam
Copy link
Member Author

@ceresstation 👍 to pay bounty.

@spm32
Copy link

spm32 commented Oct 23, 2018

👍 paying out now, great work @aashutoshrathi!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @aashutoshrathi.

kclowes pushed a commit to kclowes/py-trie that referenced this issue Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants